DoString and getting values from it?

[SKU]

I am copy and pasting ASM code from here as I simply have no idea about it at the moment. And I was just trying to get things work without thinking of design, patterns or organizing code.

Not to be rude, but.. why are you trying to call functions of another process if you don't understand it? There's really no point in copypasting this stuff and then wonder why it doesn't work. Start with something easier. Go have a look at the "Lena's Reversing for Newbies" tutorial series. (Tuts 4 You: Downloads / Lenas Reversing for Newbies)

[Viano]

Not to be rude, but.. why are you trying to call functions of another process if you don't understand it? There's really no point in copypasting this stuff and then wonder why it doesn't work. Start with something easier. Go have a look at the "Lena's Reversing for Newbies" tutorial series. (Tuts 4 You: Downloads / Lenas Reversing for Newbies)

It's not rude. I totally agree. Currently I am reading "Reversing. Secrets of Reverse Engineering.". Still, if I have nothing that motivates me, like writing bots, then I will simply drop it. Reading into C++ will be helpful as I want to understand bobbysing's WoWBase.

My bot is currently walking to a target and attacking it. And only offsets and ASM code is copy&pasta and it's so much fun watching my toon doing it all

Perhaps I should stop injecting code (which I know almost nothing about and which would spare you my stupid questions ) to WoW as I am not able to reverse Warden to see what it is scanning. It is possible to cast spells by posting keys into the WoW window, so it is not necessary.

[ramey]

It's not rude. I totally agree. Currently I am reading "Reversing. Secrets of Reverse Engineering.". Still, if I have nothing that motivates me, like writing bots, then I will simply drop it. Reading into C++ will be helpful as I want to understand bobbysing's WoWBase.

My bot is currently walking to a target and attacking it. And only offsets and ASM code is copy&pasta and it's so much fun watching my toon doing it all

Perhaps I should stop injecting code (which I know almost nothing about and which would spare you my stupid questions ) to WoW as I am not able to reverse Warden to see what it is scanning. It is possible to cast spells by posting keys into the WoW window, so it is not necessary.

Regarding you not being able to reverse Warden to see what it is scanning... Not a lot of people can, so don't think you're too different in that sense.

[vulcanaoc]

I am copy and pasting ASM code from here as I simply have no idea about it at the moment. And I was just trying to get things work without thinking of design, patterns or organizing code.

Simply put, programming is not among the easiest things to do; there are reasons that designs patterns exist. Often, the time that you put in to do things *right* will end up being less than the time you put in to do things *wrong*.

Even if you get whatever it is you're trying to do to work, it will still be terribly complicated and nearly impossible to maintain and expand upon.

In all honesty, I got into programming by taking other people's source and trying to understand it. Not too unlike what you're doing, except I can't tell if you're trying to understand.

[Viano]

I cleaned up my code as Shynd suggested and was playing around with my bot but I still have issues with the following function. WoW is crashing with access violation. Ideas anyone?

public static String GetLocalizedText(string variable)
{
    uint codecave = wow.AllocateMemory();

    bm.WriteASCIIString(codecave + 0x100, variable);

    bm.Asm.Clear();

    AsmUpdateCurrentManager();

    bm.Asm.AddLine("mov ecx, {0}", Globals.Player.LocalPlayerGUID);
    bm.Asm.AddLine("push {0}", -1);
    bm.Asm.AddLine("push {0}", codecave + 0x100);
    bm.Asm.AddLine("call {0}", Globals.Functions.Lua_GetLocalizedText);
    bm.Asm.AddLine("retn");
      
    bm.SuspendThread();

    uint result = bm.Asm.InjectAndExecute(codecave);

    String sResult = "null";
    if (result != 0)
    {
        sResult = bm.ReadASCIIString(result);
    }

    bm.FreeMemory(codecave);

    bm.ResumeThread();

    return sResult;
}

[TheWolph]

You just wrote something to your cave then cleared it right away (or I'm miss understanding that method)

bm.WriteASCIIString(codecave + 0x100, variable)
bm.Asm.Clear();

I could be wrong but I think you want to push whats in the code cave address (use code cave as a pointer) not push the code cave address "push [{0}]", codecave + 0x100

bm.Asm.AddLine("push {0}", codecave + 0x100);

The main reason why wow is crashing is because you pushed 2 things onto the stack and in order for wow to be happy you have to pop them or move the ESP (stack pointer) back 4 bytes a push

[Viano]

You just wrote something to your cave then cleared it right away (or I'm miss understanding that method)


I could be wrong but I think you want to push whats in the code cave address (use code cave as a pointer) not push the code cave address "push [{0}]", codecave + 0x100


The main reason why wow is crashing is because you pushed 2 things onto the stack and in order for wow to be happy you have to pop them or move the ESP (stack pointer) back 4 bytes a push

Asm.Clear() does not clear the cave as far as I know.
I want to push the code cave address.
And I am not sure but doesn't "retn" sets the stack pointer back and wow should be happy?

Besides Gorzul is doing exact the same thing (http://www.mmowned.com/forums/wow-me...ml#post1535811) and he seems to be ok. I'm confused :/

[ramey]

Besides Gorzul is doing exact the same thing (http://www.mmowned.com/forums/wow-me...ml#post1535811 (IsSpellUsable (Lua))) and he seems to be ok. I'm confused :/

You sir have the best copypasta going!

[SKU]

bm.Asm.AddLine("mov ecx, {0}", Globals.Player.LocalPlayerGUID);

blackMagic.Asm.AddLine("mov ecx, {0}", localPlayer.BaseAddress);

Don't eat half the pasta on the way!

[Viano]

Don't eat half the pasta on the way!

You see what I get when I at least try to think on pasting

[ramey]

You see what I get when I at least try to think on pasting

Maybe it's time to learn what you're doing? lol

[Nesox]

Go read some books

[Apoc]

Seeing as how Viano wants to do absolutely no work whatsoever to resolve his/her own problems. I'm closing this thread. Enjoy your infractions as well. (For the love of god, read the section rules.)