[General C++] Problems with my FindPattern

[flo8464]

Hi.

Today I was bored and I wanted to write an out-of-process version of FindPattern for myself.

But for some reason it just doesn't work..maybe someone can look at my code for a sec? Thanks

bool Process::DataCompare(string data, int index, string pattern, string mask)
{
    for (unsigned int i = 0; i < pattern.length(); i++)
    {
        if (mask[i] == 'x' && data[index + i] != pattern[i])
            return false;
    }

    return true;
}

DWORD Process::FindBinaryPattern(DWORD StartAddress, int Length, string pattern, string mask)
{
    int index = 0;
    string buffer;

    if(FINDBINARYPATTERN_BYTESTOREAD > Length)
    {
        buffer = ReadMemString(StartAddress, Length);

        for(unsigned int i = 0; i < (Length - pattern.length()); i++)
        {
            if(DataCompare(buffer, i, pattern, mask))
                return static_cast<DWORD>(StartAddress + i);
        }
    }
    else
    {
        while(index < Length)
        {
            buffer = ReadMemString(StartAddress + index, FINDBINARYPATTERN_BYTESTOREAD + pattern.length());

            for (unsigned int i = 0; i < FINDBINARYPATTERN_BYTESTOREAD; i++)
            {
                if(DataCompare(buffer, i, pattern, mask))
                    return static_cast<DWORD>(StartAddress + index + i);
            }

            index += FINDBINARYPATTERN_BYTESTOREAD;
        }
    }

    return static_cast<DWORD>(NULL);
}

Greetings...

[Cypher]

Don't use DWORD's to hold addresses, use a DWORD_PTR. Don't use an 'unsigned int' in a loop that takes the length of a STL container, use container::size_type. Don't manually loop over STL containers unless you have to, the STL algorithms are there for a reason.

Yawn.

None of that is actually going to solve your current problem (probably) but it will likely solve future ones if you ever intend to make your code portable.

[amadmonk]

Have you considered grading CS101 projects?

Nah... never mind. You'd run out of red ink...

[Cypher]

Have you considered grading CS101 projects?

Nah... never mind. You'd run out of red ink...

Rofl, there's a thought! That would be fun, I'd be getting paid to complain all day long. Woot!

[flo8464]

Whoooodawooop, changed every DWORD to a DWORD_PTR.
As long as the code is dirty i ll keep on doing that dirty loop, but thanks anyway.

Anyone a hint what I did wrong in my code?