Bot Causing LUA Errors

[undrgrnd59]

Hello. I just got DoString and GetLocalizedText working, but I noticed DoString occasionally causes these in-game LUA errors. It isn't really imperative to get rid of them but its kinda annoying. It says the error is coming from Carbonite but it is definitely my bot that was doing
DoString("CastSpellByName(\"Fishing\")");

Date: 2009-06-14 13:12:33
ID: 1
Error occured in: AddOn: Carbonite
Count: 1
Message: Error: AddOn Carbonite attempted to call a forbidden function (CastSpellByName()) from a tainted execution path.
Debug:
   [C]: CastSpellByName()
   [string "CastSpellByName("Fishing")"]:1: in main chunk
   Carbonite\Carbonite.lua:6527: UpI()
   Carbonite\Carbonite.lua:4298: Upd()
   Carbonite\Carbonite.lua:19683:
      Carbonite\Carbonite.lua:19642

[Cypher]

Let me guess. You're doing it in .NET and using BlackMagic or the likes?

The problem is likely that you're calling engine functions from a seperate thread, when said functions are strictly single-threaded. Obviously when two threads are calling the same function and that functions is assumed to be single threaded only (and hence using static data) some taint is likely to occur.

If you're NOT though then that's very strange, because I've never seen that issue when calling engine functions from the correct thread,

If you ARE, then you'll have to find someone here who uses .NET. Freezing the primary thread will probably work MOST of the time, but due to the inherent randomness of thread context switches you could still call in at a time when the environment is "tainted" (very likely in fact, especially as you start using the game engine functions more and more).

[undrgrnd59]

Yea thats my situation lol. Oh boy I guess I can deal with it, not like it causes catastophic errors for now at least.

[Shynd]

http://www.mmowned.com/forums/wow-me...ml#post1564189

Like I say in that post, it's an inelegant solution, but it does solve threading issues.

[vulcanaoc]

Let me guess. You're doing it in .NET and using BlackMagic or the likes?

The problem is likely that you're calling engine functions from a seperate thread, when said functions are strictly single-threaded. Obviously when two threads are calling the same function and that functions is assumed to be single threaded only (and hence using static data) some taint is likely to occur.

If you're NOT though then that's very strange, because I've never seen that issue when calling engine functions from the correct thread,

If you ARE, then you'll have to find someone here who uses .NET. Freezing the primary thread will probably work MOST of the time, but due to the inherent randomness of thread context switches you could still call in at a time when the environment is "tainted" (very likely in fact, especially as you start using the game engine functions more and more).

First off, apologies for the necro bump.

I am doing the following:

-Suspend WoW's main thread
-Get the thread context
-Inject some code
-Set the thread context such that it will run my code on resume
-Resume WoW's main thread
-Wait for return and cleanup.


However, I am experiencing the same problems that undrgrnd59 had (AND graphical artifacts, screwy mouse behavior, etc) and show-stopping crashes.

Is there any way around this?

[amadmonk]

You can actually run into taint issues even in the main UI thread in some cases, but this issue doesn't sound like the issue I ran into (posted in the elite forum under "watch your taint.")

[amadmonk]

First off, apologies for the necro bump.

I am doing the following:

-Suspend WoW's main thread
-Get the thread context
-Inject some code
-Set the thread context such that it will run my code on resume
-Resume WoW's main thread
-Wait for return and cleanup.


However, I am experiencing the same problems that undrgrnd59 had (AND graphical artifacts, screwy mouse behavior, etc) and show-stopping crashes.

Is there any way around this?

Inject and run off of an EndScene hook? Realistically, you're already injecting, so why not just stay injected and avoid all of the timing/threading weirdness that you get trying to sync with an OOP solution?

[vulcanaoc]

Inject and run off of an EndScene hook? Realistically, you're already injecting, so why not just stay injected and avoid all of the timing/threading weirdness that you get trying to sync with an OOP solution?

Sure, that would be nice, but I don't want to stay injected..

[undrgrnd59]

Injection is very messy I don't like it. There isn't a good forum post (maybe theres more information on other websites but...) about how to do injection properly. It caused more problems than just UI errors for me, WoW kept randomly crashing. I'm guessing its because of thread synchronization or something but I don't know how to fix it.

[amadmonk]

Injection is very messy I don't like it. There isn't a good forum post (maybe theres more information on other websites but...) about how to do injection properly. It caused more problems than just UI errors for me, WoW kept randomly crashing. I'm guessing its because of thread synchronization or something but I don't know how to fix it.

Guess I'll have to disagree there. Injection cleaned up my code by orders of magnitude.

If you're running code in the WoW process you are injecting, but now you have to deal with thread synch issues, out-of-process issues, and so on.

IMO, either stay completely passive (memory reads/packet scanning) or inject. The "in between" options (like running OOP but constantly injecting and executing little disposable code caves) just don't make sense. Again, in my opinion. I know some people are making it work, but I certainly wouldn't choose it.

[lanman92]

Amadmonk, do you ever plan on releasing any of your code from when you were running off of packets?

[ramey]

Amadmonk, do you ever plan on releasing any of your code from when you were running off of packets?

What a lovely question, comparable to HI CAN I HAVE YOUR CODEZ

[lanman92]

Jesus christ ramey. Quit ****ing trolling. Seriously. It's annoying.

[BoogieManTM]

Amadmonk, do you ever plan on releasing any of your code from when you were running off of packets?

what do you want to do with packets? It's probably best to avoid them like the plague. It's easier to do pretty much everything via other methods.

[lanman92]

Just to use them for simple things like casting spells and recording damage being taken. Would be easier than being in-process and hooking BCastCombatLog/BCastEvent imo. I like the idea of the OOP-ness.