Blizzard blocking Interact()... sometimes.

[jbrauman]

So I've got interact working, and it works great. However, sometimes (I'd say about one in twenty) the Blizzard UI blocks it, for some reason.


Note how it says that Bartender4 has been blocked. Its a seemingly random addon every time this message comes up (last time it said Questhelper had been blocked.)

This is how I'm calling Interact() (a bit ugly, maybe.)

publicstaticvoid Interact(WowObject obj)
{
// create a code cave for our injected code
uint codeCave = ObjectManager.WowReader.AllocateMemory();

// find the address of the interact function of our object
uint interactAddress = ObjectManager.WowReader.ReadUInt(ObjectManager.WowReader.ReadUInt(obj.BaseAddress) + (36 * 4));
// clear out any previous asm
ObjectManager.WowReader.Asm.Clear();
// write out the code
ObjectManager.WowReader.Asm.AddLine("fs mov eax, [0x2C]");
ObjectManager.WowReader.Asm.AddLine("mov eax, [eax]");
ObjectManager.WowReader.Asm.AddLine("add eax, 8");
ObjectManager.WowReader.Asm.AddLine("mov dword [eax], {0}", ObjectManager.objectManagerBase);
ObjectManager.WowReader.Asm.AddLine("mov ecx, {0}", obj.BaseAddress);
ObjectManager.WowReader.Asm.AddLine("call {0}", interactAddress); //read pointer to Interact method
ObjectManager.WowReader.Asm.AddLine("retn");
// find wows main thread
Process[] wowProcesses = Process.GetProcessesByName("Wow");
IntPtr threadHandle = OpenThread(ThreadAccess.SUSPEND_RESUME, false, (uint)wowProcesses[0].Threads[0].Id);
// suspend wows main thread
SuspendThread(threadHandle);
// do our funky injection
ObjectManager.WowReader.Asm.InjectAndExecute(codeCave);
// resume wows main thread
ResumeThread(threadHandle);
// clean up
ObjectManager.WowReader.FreeMemory(codeCave);
}

Just wondering if this happens / has happened to anyone else? Its not like its a bot-killer (I can just check whether the mine has disappeared and call it again if it hasnt) but I'm curious as to why it doesnt happen ALL the time, only sometimes.

Cheers.

[jbrauman]

And now we crash:



= /

[luciferc]

Look up how to Suspend/Resume a main thread...

Then do it to Wow.

Aka

suspendthread();

//ASM
//ASM

//Inject&Execute

resumethread();

that will make it so it never crashes :P

[jbrauman]

Look up how to Suspend/Resume a main thread...

Then do it to Wow.

Aka

 
suspendthread();
 
//ASM
//ASM
 
//Inject&Execute
 
resumethread();

that will make it so it never crashes :P

I'm already suspending and resuming wow's main thread.

[ramey]

I never had problems with that, never gets blocked. Weird issue.

[KrisBG]

jbrauman omg what is that addon please tell me the name, your wow interface is nice

[ramey]

Spartan User Interface

[kynox]

I would have said it was a threading issue, but if you say you're locking wows thread (Are you sure its their main thread? If you stop it, does it stop rendering?) then i'm not sure.

[Cursed]

I would have said it was a threading issue, but if you say you're locking wows thread (Are you sure its their main thread? If you stop it, does it stop rendering?) then i'm not sure.

Omg, look at your rep oO
kynox is evil!

[SKU]

Now he's good again! :P

Ontopic: No idea, sorry. :-(

[jbrauman]

I would have said it was a threading issue, but if you say you're locking wows thread (Are you sure its their main thread? If you stop it, does it stop rendering?) then i'm not sure.

Actually, I'm not sure if its wows main thread. I read somewhere that in .NET, Process.Threads[0] is always the main thread but... seems I am finding the main thread every time the function is called, perhaps Process.Threads[0] is not always the main thread.

I'll look into it.

[jbrauman]

Apparently I have to monitor the call stack of each thread of w/e to find out which is the main thread. Screw that. Now Im just looping through every one of wows threads and disabling it, injecting, and then re-enabling them all.

Yay for brute force.

// find and suspend all of wows threads
Process[] wowProcesses = Process.GetProcessesByName("Wow");
foreach (ProcessThread curThread in wowProcesses[0].Threads)
{
    IntPtr threadHandle = OpenThread(ThreadAccess.SUSPEND_RESUME, false, (uint)curThread.Id);
    SuspendThread(threadHandle);
}
// do our funky injection
ObjectManager.WowReader.Asm.InjectAndExecute(codeCave);
/ find and resume all of wows threads
foreach (ProcessThread curThread in wowProcesses[0].Threads)
{
    IntPtr threadHandle = OpenThread(ThreadAccess.SUSPEND_RESUME, false, (uint)curThread.Id);
    ResumeThread(threadHandle);
}

Edit: Even though I haven't had a crash yet, it seems the Wow is still being blocked from doing Interact sometimes, with the same addon-message as above. Even though I'm now suspending ALL of wow's threads.

[Nesox]

You dont want to resume it before the injected code has finished executing, make sure it has finished make it send a message or something

[naa]

If you use Black Magic you can do:

        public static int ProcessId;
        public static void suspendMainThread(int dwProcessId)
        {
            ProcessId = dwProcessId;
            ProcessThread wowMainThread = SThread.GetMainThread(ProcessId);
            IntPtr hThread = SThread.OpenThread(wowMainThread.Id);

            SThread.SuspendThread(hThread);
        }

        public static void resumeMainThread(int dwProcessId)
        {
            ProcessId = dwProcessId;
            ProcessThread wowMainThread = SThread.GetMainThread(ProcessId);
            IntPtr hThread = SThread.OpenThread(wowMainThread.Id);

            SThread.ResumeThread(hThread);
        }

[jbrauman]

If you use Black Magic you can do:

        public static int ProcessId;
        public static void suspendMainThread(int dwProcessId)
        {
            ProcessId = dwProcessId;
            ProcessThread wowMainThread = SThread.GetMainThread(ProcessId);
            IntPtr hThread = SThread.OpenThread(wowMainThread.Id);
 
            SThread.SuspendThread(hThread);
        }
 
        public static void resumeMainThread(int dwProcessId)
        {
            ProcessId = dwProcessId;
            ProcessThread wowMainThread = SThread.GetMainThread(ProcessId);
            IntPtr hThread = SThread.OpenThread(wowMainThread.Id);
 
            SThread.ResumeThread(hThread);
        }

In that code, what does SThread represent?