[PQR Profile] CodeMyLife MoP Paladin Protection/Retribution Rotation.

[CodeMyLife]

Looking at retri, if we are low on prio, ie we are on CD on generators and below 3 Holy Power we should have low prio stuff. At the moment it is Sacred Shield that are cast if we dont have the buff.

So i added a Selfless Healer ability that could be used in low prio instead of Sacred Shield

local SelflessHealerStacks = select(4,UnitBuffID("player",114250)) or 0
local PlayerHealthPercentage = 100 * UnitHealth("player") / UnitHealthMax("player")

if SelflessHealerStacks == 3 then
	--First Cater for myself
	if PlayerHealthPercentage < 70 then
		PQR_CustomTarget = "player"
		return true
	end
	
	--Then see if any in the raid need healing
	if Nova_ActiveHealingCheck and Nova_ActiveHealing == 1 and members[1].HP < 70  then 
		PQR_CustomTarget = members[1].Unit
		return true
	end		
end

The value is hardcoded to 70 since that is pretty much what it heals me with my current gear.

Thanks you very much Gabbz I integrated it to my profile along Sacred Shield! Actually left it Hardcoded I don't think it need's a value for it, I was however wondering why looking at us first? I think it is a bit selfish isn't it?!(haha kidding I understand for retribution it's not that bad) I will probly reverse this part for tanking as saving others while tanking is one of the top priority, heals are going on me anyway so better keep others up if they have feets at wrong place!

I also added a /debuffme macro and I hope you guyz will like it!
It will automatically take care of the Reckoning if you are tanking when you activate it and it will remove the shield 3 seconds after cast. Might have to decrease this delay to 2 or even 1.5, really depends of your haste rating. I did lots of test with dummies and all was being handled beside the TargetThreatSituation wich I enabled at the end so now we need real situations to test it more.

Two new options are attached to this feature in the panel:
DebuffRemover - Checkbox to activate this feature.
HoPRemover - To enable Hand of Protection or not.

If let's say Debuffremover is on and HoPRemover is not, the Divine Shield will be used instead of HoP.
If both are checked, both will be used and HoP will be used first.

You can Disactivate Hand of Protection checkbox to ensure the Profile will keep the Hand of Protection for Debuff Removing instead of using it for aggro management. If you don't you will still have Divine Shield to Work with if the HoPs are gone!

I will test it tonight for raid, I'll post how it worked!

CodeMyLife

[Gabbz]

Thanks you very much Gabbz I integrated it to my profile along Sacred Shield! Actually left it Hardcoded I don't think it need's a value for it, I was however wondering why looking at us first? I think it is a bit selfish isn't it?!(haha kidding I understand for retribution it's not that bad) I will probly reverse this part for tanking as saving others while tanking is one of the top priority, heals are going on me anyway so better keep others up if they have feets at wrong place!

For Retri we need to help out by taking care of ourself and then others This is the low prio Selfless Healer, we could/should add a higher prio to check for more critical values for example < 20 on self or others and cast it then.

I also added a /debuffme macro and I hope you guyz will like it!
It will automatically take care of the Reckoning if you are tanking when you activate it and it will remove the shield 3 seconds after cast. Might have to decrease this delay to 2 or even 1.5, really depends of your haste rating. I did lots of test with dummies and all was being handled beside the TargetThreatSituation wich I enabled at the end so now we need real situations to test it more.

Thanks alot for this, will take a spin in LFR and see how it goes.

[Gabbz]

I looked into Judgement and double Jeopardy and i think that setting focus for double jeopardy is a limitation that could be avoided. My suggestion is this

First an Event Handler that record who we judged

function CombatLog_OnEvent(self, event, ...)
	local type, _, sourceGUID, sourceNAME, _, _, destGUID, destNAME = select(2, ...)
	if (event=="COMBAT_LOG_EVENT_UNFILTERED") then
		if type == "SPELL_DAMAGE" 
			and select(12, ...) == 20271
			and sourceNAME == UnitName("player")
			then
				JudgeTargetGUID = destGUID
               end 
       end 
end

We also need to define UnitIdsTargets that we are allowed to use in API calls

-- List if targets based on UnitIds
if not UnitIdTargets then
	UnitIdTargets = {"target","focus","mouseover",""boss1","boss2","boss3","boss4","boss5", 
                                 arena1","arena2","arena3","arena4","arena5","arenapet1","arenapet2","arenapet3","arenapet4","arenapet5","pettarget"
                               }
end

And finally in the ability it self

if GetShapeshiftForm() == 0 then 
	print("No Seal Activated")
	return false
end

if SpellCheck(20271) and UnitPower("player", 9) < 5 then
	--if we do not have the glyph then we should just judge our main target
	if UnitBuffID("player", 121027) then -- We have the double Jeopardy buff
		if JudgeTargetGUID then
			print("Found TargetGUID")
			--Check if current target is our last Judged target
			if JudgeTargetGUID == UnitGUID("target") then
				for i=1,#UnitIdTargets do
					if UnitExists(UnitIdTargets[i]) then
						if JudgeTargetGUID ~= UnitGUID(UnitIdTargets[i]) and TargetCheck(UnitIdTargets[i], 20271) and PQR_UnitFacing("player",UnitIdTargets[i])
							then
							PQR_CustomTarget = UnitIdTargets[i]
							return true	
						end	
					end
				end
			end
		end
	end
	--Default value if no other target is available for Double Jeopardy
	PQR_CustomTarget = "target"
	return true
end

Tested on dummies and it works
I looked on what paintpuller did for Avery and then refined it a bit. SpellCheck and TargetCheck is just functions i created that handles the normal checks we have for each ability.

[CodeMyLife]

To be honest Gabbz I totally agree. Focus usage is a limitation that, if can be avoided, should be of course! Especially when time comes to do interupts on multiple targets, I like to be able to choose my focus target and the interupt can do his job.

Again I thank you very much for this code, I'm truly a beginner when time comes to write special codes. I'm not a coder myself in real life and I'm learning by seeing you guyz do. I did this Double Jeopardy script by myself and it was working not bad I think but I want to learn more and more and all the thing you are showing me makes me think and learn a lot.

I'm definetly gonna put this in as soon as I can!


On another note, yesterday was a nice wipe fest for me and my friends (some people calls it progression lol) and using my rotation at this moment made me face some issues. In fact not lua errors, nothing unusual except a nasty nasty lag issue when I turn the activehealing on. It usually is not that bad even in 25 but for ji-kun heroic where everyone have to fly everywhere i think the range check might be kicking too often when people needs healing out of my range. It is probably what was experiencing some other people in previous pages of this thread.

I will take a look to it soon when I get a chance but for now, might turn activehealing off if you experiment this lag issue.

[Gabbz]

I think Ji Kun is one of the bosses where range check are not possible due to the plattform. At least when i did my own code i noticed that he tried to cast TV when i was not in range.
I will check when i get there with LFR

Br

[Apocalypse59]

Amazing profile, really nice work.

What would be the easiest method to make Right Shift toggle AoE, and Right Ctrl toggle Single Target?

[Apocalypse59]

Any plans in the future for PQI integration or dynamic Sacred Shield refreshing?

[CodeMyLife]

New PQI implementation is in progress atm im working on it! For Sacred shield yo mean ya want a way to make it used more?

[Gabbz]

I think he means that we should refresh Sacred Shield if our AP is increased. I think i pm you Code already regarding this. So basically before pull we pre shield us using Sacred Shield. That is based on our Holy Spell Power however as soon as we start tanking our Vengeance goes up and we get more Holy Spell Power and therefore if we refresh it the shield will absorb alot more. So basically we would like to track how much Holy Spell Power(Haste should also be tracked for faster ticks) and if we are exceeding it we should refresh Sacred Shield to get larger absorbs.

At the moment the profile is just refreshing when its off but doing this "dynamic" we should always make sure that we get the best shield up.

Anyways that is my interpration of dynamic Sacred Shield logic.

■
Buff before you start a fight, buff 10 sec later (Vengeance bonus grants a 10 sec peak)

■
Rebuff always momentarily before Vengeance fades

■
Do not overwrite a Sacred Shield if Vengeance has faded

■
Overwrite Sacred Shield if you have just used a big cooldown to soak a big hit (like Impale)


Br

[CodeMyLife]

Oh gotcha Gabbz I never ever tought about it. Personally I find Eternal Flame is just clever for the setup I have. Vengeance makes it heal crazily and EF requires no GCD so no lost of time on the rotation.. I never notice SS was getting stronger with vengeance but it is logic. I will try to work around it a bit probly this week-end.

I work all week and raid all nights as I leading 2 different raids since the other leader had a RL car accident I'm keeping his raid going.. Have few time for me (and the lady) recently. Hopefully she plays too lol

I will keep you informed, again thanks Gabbz for the clarification!

CodeMyLife.

[CodeMyLife]

This post makes me wonder what a non-RL car accident would be

Haha well he would probly not have his back broke!

[Ninjaderp]

Haha well he would probly not have his back broke!

Holy shiet, hope he get a speedy recovery and suffer no permanent damage!

[CodeMyLife]

He is going better everyday, should recover all his mobility and shape sometime soon. Thanks for caring guyz! I was only stating why I'm low on time these days.

This week-end I get 3 days, I think I'll step on these lasts comments and hopefully I'll get all the do-list done and My new PQI Rotation Config set.


Again thanks for Ideas and feedback!

CodeMyLife

Edit: I forgot to report about the Debuff Remover. It works like a charm, removes debuffs really well. The timer was a bit high however so I lowered it a bit to 2 seconds instead of 3. It's not "final" still some code I'd like to refine when I have some time for certain situations where the overlay message is not right (says complete while cant do it, Id like it to report that cannot be done instead). Other than that I definetly like it. Thanks Gabbz!

[Apocalypse59]

I think he means that we should refresh Sacred Shield if our AP is increased. I think i pm you Code already regarding this. So basically before pull we pre-shield us using Sacred Shield. That is based on our Holy Spell Power however as soon as we start tanking our Vengeance goes up and we get more Holy Spell Power and therefore if we refresh it the shield will absorb a lot more. So basically we would like to track how much Holy Spell Power(Haste should also be tracked for faster ticks) and if we are exceeding it we should refresh Sacred Shield to get larger absorbs.

This is exactly what I meant by dynamic. Thanks for the accurate clarification.

[CodeMyLife]

This is exactly what I meant by dynamic. Thanks for the accurate clarification.

Yup we are gonna take a look into it this week-end.

Something that I really like that I shared this with you guyz is that you really have awesome ideas. Some mechanics I never realized before last week just make the tanking so much easier now. That Holy avenger, I never tried it before but now I would never live without it anymore.

I'm planning to code Prot new tier 2 pieces block via Word of Glory buff this wek-end. Was wondering if there would be changes for actual tiers for Ret? If anyone is aware please let me know

CodeMyLife