[PQR] Rubim Profiles

[JUANNY]

As far as i remember.

Back on PTR, it was a 3~4% DPS gain.

the 4 piece bonus itself mighta been a 3-4 gain but i dont think nobody has provided simcraft results showing that only using soul reaper on KM procs was a DPS gain-while you were gone i made personal edits to my profile to test only using SR on KM procs by using under the soul reaper ability a "and KillingMachine" requirement to be able to only fire off soul reaper when KM procs. The results were pretty negative overall. One of the advantages for the 4 piece bonus is getting more soul reaper attacks by starting at 45 instead of 35. That advantage was pretty much negated when i made the change and since then i reverted back to normal.Also keep in mind that KM procs only increase SR critical strike chance it is not guaranteed like it is for oblits. But it is your profile so is totally up to you. can always edit out unwanted changes personally

[Rubim]

the 4 piece bonus itself mighta been a 3-4 gain but i dont think nobody has provided simcraft results showing that only using soul reaper on KM procs was a DPS gain-while you were gone i made personal edits to my profile to test only using SR on KM procs by using under the soul reaper ability a "and KillingMachine" requirement to be able to only fire off soul reaper when KM procs. The results were pretty negative overall. One of the advantages for the 4 piece bonus is getting more soul reaper attacks by starting at 45 instead of 35. That advantage was pretty much negated when i made the change and since then i reverted back to normal.Also keep in mind that KM procs only increase SR critical strike chance it is not guaranteed like it is for oblits. But it is your profile so is totally up to you. can always edit out unwanted changes personally

I usually follow a simcraft.

USUALLY.

I'm still changing things on my new profiles, most of then are design choices, like having PQR rotation for every spec instead of one big file. I'm aiming at performance, some features are gone (auto-equip) and others revamped (spell queue), still working on it and i dont have an ETA.

[alexxjr]

I usually follow a simcraft.

USUALLY.

I'm still changing things on my new profiles, most of then are design choices, like having PQR rotation for every spec instead of one big file. I'm aiming at performance, some features are gone (auto-equip) and others revamped (spell queue), still working on it and i dont have an ETA.

Sounds good Rubim, looking forward to it. Take your time on it, we know it will be awesome when you finally release it

[JUANNY]

hey rubim or anyone else there that has some knowledge of the WOW API functions and PQR specific functions-is there any code that i can use to check that a battle rez is available for my edited chunk that i put together for an automatic battle rez without hanging the profile-it seems that if a battle rez (in 10 mans) is used by someone else in the raid and someone else dies my profile hangs on the raise ally ability probably due to the use of the 1 avail battle rez-other then that 1 prob this works great

local GROUP = ""

if IsInRaid() then
   GROUP = "raid"
else
   GROUP = "party"
end

local members = GetNumGroupMembers() - 1

if PQR_SpellAvailable(61999) 
and IsSpellKnown(61999)
then
for i = 1, members, 1 do
        member = GROUP..tostring(i)
        if ( UnitIsDead(member) or UnitIsCorpse(member) )
          and not PQR_IsOutOfSight(member)
          and IsSpellInRange(GetSpellInfo(61999), member) == 1
          and UnitAffectingCombat("player")
          then
            PQR_CustomTarget = member
            return true
          end
        end
end 

[Holobyte]

Hey, Rubim, have you fixed that blood tap problems? I felt the need to write my own Frost profile since I wanted to see the DPS difference when using Blood Tap and, man, it's worth it. It gives me a flat 10% DPS increase just by switching talents from Runic Empowerment to Blood Tap. Let me know if you want to see my code, i'll gladly share it with you.

Another thing. While I was making my profile (I still am, btw, it's far from ready) I often used yours as base for writing my abilities and I found that your logic for checking runes is wrong, at least for the FROST rotations.
You check runes by TYPE (blood/unholy/frost/death), while Simcraft is obviously checking runes by SLOT (blood/unholy/frost). I'll give you one example: simcraft's Frost 2H single target rotation:

- actions.single_target+=/obliterate,if=blood=2|frost=2|unholy=2

It won't make any sense to look for blood runes here because frost DK's simply do not have blood runes. So they are checking for the blood SLOTS, the ones that always contains 2 death runes.

Ok, so what?

Let's look at your translation to PQR of this part of the rotation:

if 
    TargetValidation("target",Obliterate)
    and (RuneCheck("Blood") == 2
    or RuneCheck("Frost") == 2
    or RuneCheck("Unholy") == 2)
then    
    CastSpell(Obliterate)
end 

You are correctly checking for blood runes = 2, but let's look at your RuneCheck() method:

function RuneCheck(Rune)
    FrostRune = 0
    UnholyRune = 0
    BloodRune = 0
    DeathRune = 0
    for i=1, 6 do
        if GetRuneType(i) == 1 and select(1,GetRuneCooldown(i)) + select(2,GetRuneCooldown(i)) - GetTime() < 0 then 
           BloodRune = BloodRune + 1
        end
        if GetRuneType(i) == 2 and select(1,GetRuneCooldown(i)) + select(2,GetRuneCooldown(i)) - GetTime() < 0 then 
           UnholyRune = UnholyRune + 1
        end
        if GetRuneType(i) == 3 and select(1,GetRuneCooldown(i)) + select(2,GetRuneCooldown(i)) - GetTime() < 0 then 
           FrostRune = FrostRune + 1
        end
        if GetRuneType(i) == 4 and select(1,GetRuneCooldown(i)) + select(2,GetRuneCooldown(i)) - GetTime() < 0 then 
           DeathRune = DeathRune + 1
        end
    end
    
    if Rune == nil
    then    
        return BloodRune, UnholyRune, FrostRune, DeathRune
    end 

Using your function, blood runes will ALWAYS be zero, because you are counting runes by type so that obliterate will never happen when you have 2 death runes active in your blood rune slots.

Here's my code for rune checking, it's pretty different from yours since I'm building my own framework, but you will get the idea:

function Hf_GetRunesBySlot()
    local runeSlots = { "b", "u", "f"}
    local runes = {
        ["b"] = { Up = 0, CdLeft = 10 },
        ["u"] = { Up = 0, CdLeft = 10 },
        ["f"] = { Up = 0, CdLeft = 10 },
    }
    local r = 1
    for slot=1, 6 do
        local start, cd, up = GetRuneCooldown(slot)
        local left = start + cd - GetTime()
        if not up then
            if runes[runeSlots[r]].CdLeft > left then
                runes[runeSlots[r]].CdLeft = left
            end
        else
            runes[runeSlots[r]].Up = runes[runeSlots[r]].Up + 1
        end
        if slot % 2 == 0 then
            r = r + 1
        end
    end
    return runes
end 

And my code for that same Obliterate:

local ob = Obliterate
local runes = Hf_GetRunesBySlot()
if
    Hf_ValidateSkill(ob, "target")
    and (runes["b"].Up == 2 or runes["f"].Up == 2 or runes["u"].Up == 2)
then
    return true
end 

If you count slots 1 and 2 as the actual blood runes, you can squeeze one more obliterate from time to time.

[mcwhat]

Is there a way to add a check to the following to see if I already have a pet?

	if PQR_SpellAvailable(RaiseDead)
	and BossCheck()
	then
		CastSpell(RaiseDead)
	end

Whenever I try to use control undead the bot just goes nut and stops working.

[Holobyte]

Is there a way to add a check to the following to see if I already have a pet?

    if PQR_SpellAvailable(RaiseDead)
    and BossCheck()
    then
        CastSpell(RaiseDead)
    end

Whenever I try to use control undead the bot just goes nut and stops working.

Weird, Raise Dead should be on cooldown if you already have a pet. Unless that's for Unholy... then i think this change should do the trick:

    if PQR_SpellAvailable(RaiseDead)
    and BossCheck()
    and not UnitExists("pet")
    then
        CastSpell(RaiseDead)
    end

[imdasandman]

Don't use control undead. Esp as unholy as the profile does control Timmy but if your are controlling a random undead NPC the profile will freak out.

Sent from my GT-N7105 using Tapatalk 4 Beta

[Rubim]

Hey, Rubim, have you fixed that blood tap problems? I felt the need to write my own Frost profile since I wanted to see the DPS difference when using Blood Tap and, man, it's worth it. It gives me a flat 10% DPS increase just by switching talents from Runic Empowerment to Blood Tap. Let me know if you want to see my code, i'll gladly share it with you.

Another thing. While I was making my profile (I still am, btw, it's far from ready) I often used yours as base for writing my abilities and I found that your logic for checking runes is wrong, at least for the FROST rotations.
You check runes by TYPE (blood/unholy/frost/death), while Simcraft is obviously checking runes by SLOT (blood/unholy/frost). I'll give you one example: simcraft's Frost 2H single target rotation:

- actions.single_target+=/obliterate,if=blood=2|frost=2|unholy=2

It won't make any sense to look for blood runes here because frost DK's simply do not have blood runes. So they are checking for the blood SLOTS, the ones that always contains 2 death runes.

Ok, so what?

Let's look at your translation to PQR of this part of the rotation:

if 
    TargetValidation("target",Obliterate)
    and (RuneCheck("Blood") == 2
    or RuneCheck("Frost") == 2
    or RuneCheck("Unholy") == 2)
then    
    CastSpell(Obliterate)
end 

You are correctly checking for blood runes = 2, but let's look at your RuneCheck() method:

function RuneCheck(Rune)
    FrostRune = 0
    UnholyRune = 0
    BloodRune = 0
    DeathRune = 0
    for i=1, 6 do
        if GetRuneType(i) == 1 and select(1,GetRuneCooldown(i)) + select(2,GetRuneCooldown(i)) - GetTime() < 0 then 
           BloodRune = BloodRune + 1
        end
        if GetRuneType(i) == 2 and select(1,GetRuneCooldown(i)) + select(2,GetRuneCooldown(i)) - GetTime() < 0 then 
           UnholyRune = UnholyRune + 1
        end
        if GetRuneType(i) == 3 and select(1,GetRuneCooldown(i)) + select(2,GetRuneCooldown(i)) - GetTime() < 0 then 
           FrostRune = FrostRune + 1
        end
        if GetRuneType(i) == 4 and select(1,GetRuneCooldown(i)) + select(2,GetRuneCooldown(i)) - GetTime() < 0 then 
           DeathRune = DeathRune + 1
        end
    end
    
    if Rune == nil
    then    
        return BloodRune, UnholyRune, FrostRune, DeathRune
    end 

Using your function, blood runes will ALWAYS be zero, because you are counting runes by type so that obliterate will never happen when you have 2 death runes active in your blood rune slots.

Here's my code for rune checking, it's pretty different from yours since I'm building my own framework, but you will get the idea:

function Hf_GetRunesBySlot()
    local runeSlots = { "b", "u", "f"}
    local runes = {
        ["b"] = { Up = 0, CdLeft = 10 },
        ["u"] = { Up = 0, CdLeft = 10 },
        ["f"] = { Up = 0, CdLeft = 10 },
    }
    local r = 1
    for slot=1, 6 do
        local start, cd, up = GetRuneCooldown(slot)
        local left = start + cd - GetTime()
        if not up then
            if runes[runeSlots[r]].CdLeft > left then
                runes[runeSlots[r]].CdLeft = left
            end
        else
            runes[runeSlots[r]].Up = runes[runeSlots[r]].Up + 1
        end
        if slot % 2 == 0 then
            r = r + 1
        end
    end
    return runes
end 

And my code for that same Obliterate:

local ob = Obliterate
local runes = Hf_GetRunesBySlot()
if
    Hf_ValidateSkill(ob, "target")
    and (runes["b"].Up == 2 or runes["f"].Up == 2 or runes["u"].Up == 2)
then
    return true
end 

If you count slots 1 and 2 as the actual blood runes, you can squeeze one more obliterate from time to time.

I did a new rune check thing to my new profiles, but anyway...

Maybe you are wrong?

Simcraft check runes by type:
https://code.google.com/p/simulation...vailable_runes

Example:
actions+=/death_and_decay,if=death>=2

This obliterate with 2 runes its just a filler, you should not spend your death runes on a filler obliterate, save that for a KM proc.

I have no ideia why we have a blood rune check.
====
Fun fact:

Tested on simcraft with:
Death 2, 147961.7
Blood 2, 148354.7
Blood 2 again, 147835.7
Without Blood or Death, 147964.

Yeah... Have no ideia.

[Weird0]

also to both of you(rubim & sandman) a question and also something i experienced.

wouldnt it be better to put a bit more emphasis on scourge strike ? i noticed during several fights now that other deathknigts are useing it more frequently while also maintaining the diseases on the boss and by doing so they dish out 10-15k more dps than me while only being 5-8 ilvl higher than me.


i did then some manual testing and noticed that while doing so too i could pull of much higher dps than with the profile. i tried it with disabled/enable cleave and festerblight option and any combination of those 2 results were always the same. then i tried to use the /rcast option to force more scourge strikes inbetween the rotation whenever i could and it was a little better.

like i noticed with the profile when my diseases stayed at the 2min mark it still kept trying to dish out festerings to increase the duration. would it be possible to make it like only use festering when diseases are below lets say uhm... 60 seconds on the current target ?

[imdasandman]

also to both of you(rubim & sandman) a question and also something i experienced.

wouldnt it be better to put a bit more emphasis on scourge strike ? i noticed during several fights now that other deathknigts are useing it more frequently while also maintaining the diseases on the boss and by doing so they dish out 10-15k more dps than me while only being 5-8 ilvl higher than me.


i did then some manual testing and noticed that while doing so too i could pull of much higher dps than with the profile. i tried it with disabled/enable cleave and festerblight option and any combination of those 2 results were always the same. then i tried to use the /rcast option to force more scourge strikes inbetween the rotation whenever i could and it was a little better.

like i noticed with the profile when my diseases stayed at the 2min mark it still kept trying to dish out festerings to increase the duration. would it be possible to make it like only use festering when diseases are below lets say uhm... 60 seconds on the current target ?

This is the reason why I made my manual unholy profile. You control the festering and disease application.

Sent from my GT-N7105 using Tapatalk 4 Beta

[Apocalypse59]

This is the reason why I made my manual unholy profile. You control the festering and disease application.

Sent from my GT-N7105 using Tapatalk 4 Beta

I've been using your manual profile for a while. Not exactly sure I'm using it correctly or effectively though.

[Holobyte]

Are you sure that example on the simcraft wiki was meant for Frost DKs? In the AoE rotation for Frost they check for unholy runes, not death runes (actions.aoe+=/death_and_decay,if=unholy=1) so it's confusing. I mean, if simcraft is really checking runes by type, then that blood=2 check really makes no sense.

I ran some tests myself with my profile on my DK (20m damage on boss dummy each run).
Counting blood runes (run 1): 127.5k
Counting blood runes (run 2): 126.9k
Counting blood slots (run 1): 127.8k
Counting blood slots (run 2): 127.1k

Anyway, I must keep a "BySlot" function around for when I check for depleted runes before casting blood tap so I think I'll stick with for now it since the DPS difference is inconclusive.

[JUANNY]

This is the reason why I made my manual unholy profile. You control the festering and disease application.

Sent from my GT-N7105 using Tapatalk 4 Beta

im curious-doesnt the manual thing make it counterproductive for the reason that most players use a bot is the efficciency of automation

[imdasandman]

im curious-doesnt the manual thing make it counterproductive for the reason that most players use a bot is the efficciency of automation

You are correct 90% but since festerblight is weird and no matter what I did the disease timer were going to 1+min which was leaving these super long diseases left on the bosses and was a DPS loss.

Think of pqr as a tool, yea it can be fully automated but your DPS will be OK. But if you use it as a tool or an aid to handle some or most functions but the user themselves control certain aspects well your DPS will be among the worlds best even when you are 10-20 ilvl below them.
I have not nor will I ever cater to the totally lazy player. My edits always have and will require user input. If you want fully automated than use some other profile. <<< not directed at you johnny

Sent from my GT-N7105 using Tapatalk 4 Beta