[PQR] MOP profiles

[Gabbz]

I found out why i couldnt get your script to work. And found this:

i updated my Event Functions abilitie but yours are based on my old.
Add the bold part

if MageFunctions == nil then
	MageFunctions = true
	print("Mage Functions Loadeds.")
	function xelperFrame_OnEvent(self,event,...)
		if event == "COMBAT_LOG_EVENT_UNFILTERED" then
			--print("Mage Functions Combatlog.")
			local subEvent = select(2, ...)
			local sourceName = select(5, ...)
			local destName = select(9, ...)
			local spellName = select(13, ...)
			local spellAmount = select(15, ...)
			local spellCrit = select(21, ...)
			IgniteLastDamage = 0 

Secondly it was the mage bomb part. If you use sheurons magebomb it would solve it else you need to check if the spellid is known:
For example everyone not have talented scorch cant use the script.
I solved it like this

if  IsSpellKnown(2948)
and PQR_IsMoving(0.2) then CastSpellByName(GetSpellInfo(2948),nil) return true end

Here is Sheurons mage bomb code

 local MageBomb = select(5,GetTalentInfo(13)) and 114923 or select(5,GetTalentInfo(14)) and 44457 or ( select(5,GetTalentInfo(15)) and not PQR_IsMoving(1) and select(2,GetSpellCooldown(112948)) < 2 ) and 112948

if MageBomb and not HaveDebuff("target",MageBomb,nil,"PLAYER") 
then CastSpellByName(GetSpellInfo(MageBomb),nil) return true end

i will check your code on dummie and be back with more feedback m8

[Sheepmoon]

I found out why i couldnt get your script to work. And found this:

i updated my Event Functions abilitie but yours are based on my old.
Add the bold part

if MageFunctions == nil then
	MageFunctions = true
	print("Mage Functions Loadeds.")
	function xelperFrame_OnEvent(self,event,...)
		if event == "COMBAT_LOG_EVENT_UNFILTERED" then
			--print("Mage Functions Combatlog.")
			local subEvent = select(2, ...)
			local sourceName = select(5, ...)
			local destName = select(9, ...)
			local spellName = select(13, ...)
			local spellAmount = select(15, ...)
			local spellCrit = select(21, ...)
			IgniteLastDamage = 0 

Secondly it was the mage bomb part. If you use sheurons magebomb it would solve it else you need to check if the spellid is known:
For example everyone not have talented scorch cant use the script.
I solved it like this

if  IsSpellKnown(2948)
and PQR_IsMoving(0.2) then CastSpellByName(GetSpellInfo(2948),nil) return true end

Here is Sheurons mage bomb code

 local MageBomb = select(5,GetTalentInfo(13)) and 114923 or select(5,GetTalentInfo(14)) and 44457 or ( select(5,GetTalentInfo(15)) and not PQR_IsMoving(1) and select(2,GetSpellCooldown(112948)) < 2 ) and 112948

if MageBomb and not HaveDebuff("target",MageBomb,nil,"PLAYER") 
then CastSpellByName(GetSpellInfo(MageBomb),nil) return true end

i will check your code on dummie and be back with more feedback m8

Ah yes I found that bug in the Combustion code last night. I already updated a fixed version but I did it a different way. I just put a nil check for the IgniteLastDamage at the start of the combustion code and it just skips the combustion routine if it is nil. Problem was trying to do calculations with a nil value. I never even thought to set it to zero in the event function. Funny thing how so many ways to get the same result with code.

Anyway next problem yes I have been perhaps lazy you could say with talents. I designed my profiles for a specific talent set that I personally used and just released it with that. In the specific release post for each class and spec it list what talents it will work with and that I will be adding support for more talents later. Other bad things I do like using castspellbyname with only english names so i know my profiles won't work on non english clients. All these things I plan to fix eventually, but it will take me some time.

Thanks again for your feedback and help it is very appreciated.

[Sheepmoon]

Hey Sheep, just tested your fire mage profile and very well done. On 85 target dummy I get about 46K dps after 20 mil damage. Ran 1st part of DS and was either #1 or #2 on dps. The combustion handling was good but I just felt it can be better. I'm not quite sure how to explain it but just don't think it's optimized. Well, it doesn't really matter as 85 and DS will be ancient history in 3 weeks. One thing I do notice is that it doesn't cast ice lance when I'm moving so that can be slight dps loss but no biggie. It also doesn't use POM so not sure if that's what you intended. In any case, great job and can't wait to see lvl90 mage profile. Thanks

Sent from my Galaxy Nexus using Tapatalk 2

Hey yeah I set it to use scorch talent for moving. Gabbz commented on this, I guess I will need to rewrite it to detect talents but I just thought scorch was the obvious choice most people would use for fire. With combustion I am happy to hear that it worked at least, I didn't really get to test it myself. If you do more testing and use combustion helper or an addon like mage nuggets or something and tell me if you think it is using combust at the right time for you. Maybe it should cast it more often or maybe it should be waiting for bigger combust. Just to help me tune the trigger point a bit better.

Thankyou for your feedback!

I'm not sure if this is intended or not but I figured i'd ask. I've been using your Resto Druid profile and it's been amazing - my issue is that when I use your holy paladin profile it won't target players automatically like your resto druid profile does, is this intended or is something wrong on my end?

Hey the only difference between the two is the druid automatically will lifebloom who it "thinks" is the tank. Most of the time this works ok.
For the Paladin you should set your tank to focus at the start. I just have a macro for it as soon as I enter any dungeon or raid I just target the tank and hit my focus macro. Then it will keep beacon of light and sacred shield on the focus target all the time.

I hope this answers your question. Unless there is another problem and the paladin is not automatically healing anybody at all unless you target them?

[PrimoPie]

Anybody else having trouble with the Moonkin profiles? I cant get them to do anything, my toon just sits and wants to auto melee attack a mob.

[Sheepmoon]

Anybody else having trouble with the Moonkin profiles? I cant get them to do anything, my toon just sits and wants to auto melee attack a mob.

Someone else had a problem with that profile and said they fixed it by running WoW as admin.

I will take a look at it though I only made it quickly and I haven't really tested it appart from on the training dummies so it could have some bugs i didn't notice.

[roli4]

rouge profile always bugging for me

[Exmortem]

Hey the only difference between the two is the druid automatically will lifebloom who it "thinks" is the tank. Most of the time this works ok.
For the Paladin you should set your tank to focus at the start. I just have a macro for it as soon as I enter any dungeon or raid I just target the tank and hit my focus macro. Then it will keep beacon of light and sacred shield on the focus target all the time.

I hope this answers your question. Unless there is another problem and the paladin is not automatically healing anybody at all unless you target them?

That's my problem, it's not healing anybody at all unless I target them .. I did notice that it did a flash of light on someone at some point, but that's all I saw.

EDIT: I did a complete reinstall for the second time and this time it's working, not sure what the issue was - Thanks though!

[kabman]

I was using your mage profile and i noticed that even if i have a pyro proc and it hits the Correct Ignite value it wont blast off the last pyro before it uses the combustion. not sure if thats a game lag or built into your profile.

[Sheepmoon]

I was using your mage profile and i noticed that even if i have a pyro proc and it hits the Correct Ignite value it wont blast off the last pyro before it uses the combustion. not sure if thats a game lag or built into your profile.

Yes I put combustion at a higher priority than pyro. I am actually trying to do some testing now on getting the best combustion and overall dps. I don't play mage as a main so it is taking me a bit of time to research it all and test.

There should be an improved fire mage pve and frost pvp up later today.

[Genocyber]

There is something wrong with the shadow pvp profile.
It's use the buffs, but then it simple stays there and dont attack the enemy player (or dummy).

I've to attack manually, but it make a few actions and stop again :\

What can it be? It's something in my config?

Already found the error, I was using shadow fiend, not mindbender and the config dont seens to skip it auto...

[Genocyber]

Hi, Sheepmoon
I've using your profiles and have few sugestions (and doubts) to improve the rotation,

The most important, restrict the usage of Psych Scream and Void tentrils, adding:


And them for all the CCs abilities, add new checks.
I tried to make some, but not certain that it will work:
as a example, what i made with silence:

local ams = UnitBuffID("target",48707)
local divineshield = UnitBuffID("target",642)
local devotionaura = UnitBuffID("target",31821)
local innerfocus = UnitBuffID("target",89485)

if ams == nil
and divineshield == nil
and devotionaura == nil
and innerfocus == nil
and UnitCastingInfo("target")
and IsSpellInRange("Silence", "target")
and not UnitBuffID("player",15487) --If the target already silenced
and not UnitBuffID("player",47585) --If the target using dispersion
and not UnitBuffID("player",5782) --If the target warlock fear
and not UnitBuffID("player",8122) --If the target pysch scream
then
return true
end

I added one abilit to use healthstones too (u can get they in any bg and it's a pitty dont make use)

if UsedHealth == nil and Health < 30 then
UseItemByName(5512, "player")
UsedHealth = 1
end
end

Finally, to increase the survivability i added the flash heal ability.

local Health = 100 * UnitHealth("player") / UnitHealthMax("player")

if Health < 60 and PQR_IsMoving(1) == false then
return true
end

[Taran32]

Sheep,

I've been using your Hunter BM PvP profile and it's amazing. I was wondering though if you had any plans to create an Arms Warrior PvP profile as well? I know Dom was working on something for Rets but given your Hunter profile seemed so great, I was hoping you had plans to take that to Warriors as well.

[Sheepmoon]

Hey thanks for all the feedback to everyone. I try to respond to everyone individually but just so you know I always read all feeback and if there are problems I will try to fix things when I can.

Just so everyone knows I had a bad problem yesterday I had been awake too long and was tired and accidentally deleted the current profiles I was working on including a really good frost mage pvp profile that took days of writing and testing. I tried everything using a program to recover deleted files and sure it found files from 5 months ago but couldn't find something i deleted 5 mins ago.

Anyway I am really stressed out and annoyed I lost days of work. I am going through now to start re-writing the lost profiles but I probably won't be releasing anything for a few days.

[daveyboyuk]

that sux :'(

[King Protos]

Hey Sheep, really great profiles. Using your Shadow Priest profile on my boosted-to-80 Priest, and despite only being 80 it's working fantastic. However the only problem I've had is when I equip a two-handed staff when I start any of the rotations it just doesn't start unless I force it to engage into combat by running up to the mob in melee range (and even then it seems to bug out sometimes). If I use a one-handed wand shootey weapon it works perfectly.

Haven't tried PvP yet but should be fun, thanks again.