[PQR] MOP profiles

[luburium]

Hey Sheepmoon, I know you're busy but give us mages some love too when you get a chance. Mainly fire mage with better combustion handling. Thanks bud

Sent from my Galaxy Nexus using Tapatalk 2

Yeah, I really would appreciate a Mage Frost PvP / Warrior Arms PvP

[Sheepmoon]

Hey Sheepmoon, I know you're busy but give us mages some love too when you get a chance. Mainly fire mage with better combustion handling. Thanks bud

Sent from my Galaxy Nexus using Tapatalk 2

Sure thing. I have been thinking of ways to handle it better but its more complicated than you first think to get it perfect.
Could you give me some more detail when you say "better combustion handling" does it actually combust for you now or not at all? Or is it you want it to combust only at a certain ignite damage? If that is how you like it then can you please tell me your ilvl and spellpower and what ignite damage you want it to wait for?

Problem is if i hard code a fixed ignite damage it will be too high for some players and too low for others depending on gear. Also fights that have a damage increase like say on zonozz or madness you want to wait for higher ignite than normal. Programming all of this and making it work for everyone might take some time.

[roli4]

you are my hero!

[Sheepmoon]

Ok updated Fire PVE with new combustion logic. It probably will need some adjusting at the moment it looks for an ignite value based on your spell power. So this should scale with gear and also any intel buffs or procs you have for example potions/flasks/trinkets.

Need some feedback on this so I can tune the scaling value, it is hard to find a balance between using combustion with too small ignite and not using it enough due to waiting for big ignite all the time. =/

[Hordeglider]

Woohoo! Will try this tonight and see how it goes. My mage is iL388 and I'm using Gabbz's mage test profile right now. However, I need to manually adjust ignite value as he sets it at 9000 which is high for my gear. Thanks Bud, you're da best!

Sent from my Galaxy Nexus using Tapatalk 2

[Sheepmoon]

Woohoo! Will try this tonight and see how it goes. My mage is iL388 and I'm using Gabbz's mage test profile right now. However, I need to manually adjust ignite value as he sets it at 9000 which is high for my gear. Thanks Bud, you're da best!

Sent from my Galaxy Nexus using Tapatalk 2

At the moment it is set to 2/3 of your spell power. So if you have 10k spell power it will wait for a 6.6k ignite tick.
Thats what i need to get lots of people to test and work out what the best ratio of spell power to ignite tick will be.

[Teresa4600]

Hey i just met you, and this is crazy, so heres my rep, arms warrior profile maybe?

+ rep for hard works hope you release them soon!

[Gabbz]

At the moment it is set to 2/3 of your spell power. So if you have 10k spell power it will wait for a 6.6k ignite tick.
Thats what i need to get lots of people to test and work out what the best ratio of spell power to ignite tick will be.

The problem as i can foresee is that it basically depends on the encounter. Your way of handling it is interesting but it doesnt work on weak phases ie Hagara etc. But on the other hand i dont handle it either in my script.

your code

spellDmg = GetSpellBonusDamage(3)

if IgniteLastDamage > spellDmg / 1.5
and UnitDebuffID("target", 132210,"PLAYER") 
and UnitDebuffID("target", 12654,"PLAYER") 
then
return true
end


if IgniteLastDamage > spellDmg * 2
then return true end

first you check for Pyromaniac - Spell - World of Warcraft ?
Why ? it has nothing todo with combustion as i see it ?

then you check for ignite but if there is no ignite on target then the IgniteLastDamage should be == 0. I think you using my event functions there so its checked in that.
So basically you dont need to check for that and since every spell we cast is basically making ignite tick we shouldnt have to check for it.

I cant test your script cause i cant get it to work. But 1 more suggestion is that you need to make it with a /stopcasting. Cause the window is sometimes very low to able to get a good combustion off so we cant wait for the fireball to end cast when we get a good ignite.

Keep up the good work !

[Sheepmoon]

The problem as i can foresee is that it basically depends on the encounter. Your way of handling it is interesting but it doesnt work on weak phases ie Hagara etc. But on the other hand i dont handle it either in my script.

your code

spellDmg = GetSpellBonusDamage(3)

if IgniteLastDamage > spellDmg / 1.5
and UnitDebuffID("target", 132210,"PLAYER") 
and UnitDebuffID("target", 12654,"PLAYER") 
then
return true
end


if IgniteLastDamage > spellDmg * 2
then return true end

first you check for Pyromaniac - Spell - World of Warcraft ?
Why ? it has nothing todo with combustion as i see it ?

then you check for ignite but if there is no ignite on target then the IgniteLastDamage should be == 0. I think you using my event functions there so its checked in that.
So basically you dont need to check for that and since every spell we cast is basically making ignite tick we shouldnt have to check for it.

I cant test your script cause i cant get it to work. But 1 more suggestion is that you need to make it with a /stopcasting. Cause the window is sometimes very low to able to get a good combustion off so we cant wait for the fireball to end cast when we get a good ignite.

Keep up the good work !

Good catch yeah I just quickly edited the existing code I had and I was checking for pyromaniac and ignite debuff for another reason. It was meant to check for pyroblast dot but i forgot to change it. I am not sure why it doesn't work for you though.

But yes as I also mentioned in my post above there are bosses with a damage buffing mechanic and for the ideal combustion you would need to start checking for specific boss buffs and really this close to the end of cataclysm I am not going to bother with dragon soul bosses. The spell power scaling was just a thought I had as one way to handle combustion better and this is just for testing purposes. Idealy you would want to check not only the spell power but the crit rating the player has but idk i am just trying to get some basic functions working for now.

These are some of the problems when trying to make certain things 100% automated and suit every fight and player and level and gear. Many of the profiles that I personally use I end up manually controlling cooldowns... honestly its just simpler to press a button when you know its the right time rather than write pages of code checking for every possible situation. But I also know people want things to be automated as much as possible.

Thanks for the help I will try to improve the profile when I get some more spare time. =)

[Whatsmyname]

Is anyone working on a Disc PvE Healing rotation?

Edit: Seems like Sheepmoon will start on 1 in the next days.

[Sheepmoon]

Fixed up the Fire Mage and updated it. The one I had up just recently the combustion code was throwing out a truck load of errors and locking up the routine, I should have tested it better before i released it. Was having a problem when ignite wasn't ticking it didn't like comparing a nil value.

Also made some improvements thanks to Gabbz feedback. Please try the latest one and let me know how it works.

[Waffle]

Hey Sheep, just tried out your Moonkin profile a second time and as soon as it loaded I went from 107 FPS to 4 FPS, so I turned on LUA errors to see if any where popping up, and about 200 of this error popped up in the space of 5 seconds. The first time I used it this error did not come up at all and had zero FPS issues. Any idea if this error is caused by something on my end?

Message: [string "if PQR_Addon_Loaded == nil then..."]:1451: GetSpellBookItemName(): Invalid spell slot
Time: 09/05/12 14:44:00
Count: 239
Stack: [C]: in function `GetSpellBookItemName'
[string "if PQR_Addon_Loaded == nil then..."]:1451: in function `PQR_GetSpellID'
[string "if PQR_Addon_Loaded == nil then..."]:1437: in function <[string "if PQR_Addon_Loaded == nil then..."]:1435>
[C]: in function `CastSpellByName'
[string "if IsUsableSpell(102560) ..."]:7: in function `?'
[string "if PQR_Addon_Loaded == nil then..."]:760: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:533: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>

Locals: (*temporary) = 307
(*temporary) = "spell" 

[bubblensqueak]

This is the clue: GetSpellBookItemName(): Invalid spell slot

That error means the profile is referencing a spell from a talent you don't have in your build, i saw it when i was comparing SoTF instead of taking incarnation, so check your talents and remove the spell that you haven't spec'd into from the rotation.

Hey Sheep, just tried out your Moonkin profile a second time and as soon as it loaded I went from 107 FPS to 4 FPS, so I turned on LUA errors to see if any where popping up, and about 200 of this error popped up in the space of 5 seconds. The first time I used it this error did not come up at all and had zero FPS issues. Any idea if this error is caused by something on my end?

Message: [string "if PQR_Addon_Loaded == nil then..."]:1451: GetSpellBookItemName(): Invalid spell slot
Time: 09/05/12 14:44:00
Count: 239
Stack: [C]: in function `GetSpellBookItemName'
[string "if PQR_Addon_Loaded == nil then..."]:1451: in function `PQR_GetSpellID'
[string "if PQR_Addon_Loaded == nil then..."]:1437: in function <[string "if PQR_Addon_Loaded == nil then..."]:1435>
[C]: in function `CastSpellByName'
[string "if IsUsableSpell(102560) ..."]:7: in function `?'
[string "if PQR_Addon_Loaded == nil then..."]:760: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:533: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>

Locals: (*temporary) = 307
(*temporary) = "spell" 

[Exmortem]

I'm not sure if this is intended or not but I figured i'd ask. I've been using your Resto Druid profile and it's been amazing - my issue is that when I use your holy paladin profile it won't target players automatically like your resto druid profile does, is this intended or is something wrong on my end?

[Hordeglider]

Hey Sheep, just tested your fire mage profile and very well done. On 85 target dummy I get about 46K dps after 20 mil damage. Ran 1st part of DS and was either #1 or #2 on dps. The combustion handling was good but I just felt it can be better. I'm not quite sure how to explain it but just don't think it's optimized. Well, it doesn't really matter as 85 and DS will be ancient history in 3 weeks. One thing I do notice is that it doesn't cast ice lance when I'm moving so that can be slight dps loss but no biggie. It also doesn't use POM so not sure if that's what you intended. In any case, great job and can't wait to see lvl90 mage profile. Thanks

Sent from my Galaxy Nexus using Tapatalk 2