PQR - Rotation Bot

[nilrem2004]

how i can create a code for Divine Star for shadow priest i want to use in PvE with modifer right ALT key?

if select(2,GetTalentRowSelectionInfo(6)) == 17 then
if IsRightAltKeyDown() and PQR_SpellAvailable(110774) then
CastSpellByName(GetSpellInfo(110774))
return true
end
end

Bare in mind that currently Right Alt key seems bugged and often triggers Left Control, so you might wanna use some other key.

[Kinky]

@nilrem2004: You kinda need some checks as well in there.. :P Also, like all the other Level 90 Priest talents, they are morphed into depending on your current spec, and we all know how well PQR handles morphed spells! *looks around*
Here you go @fluxflux: -- I also sent this to you as you requested in a PM, but I guess you never recieved it?

local PQ_DStar = 110744
local Nova_Spells = Nova_Spell
local PQ_DSStar = 122128

if Nova_Spells[PQ_DStar].known
	and UnitExists("target")
	and PQR_SpellAvailable(PQ_DSStar)
	and not UnitIsDeadOrGhost("target")
	and not PQR_IsOutOfSight("target", 1)
	and UnitCanAttack("player", "target") == 1
	and IsRightAltKeyDown()
	and not GetCurrentKeyBoardFocus()
then
	SpellStopCasting()
	CastSpellByName(GetSpellInfo(PQ_DSStar),"target")
end

Just like my code for Halo and Cascade, this will check if Divine Star is your selected talent, that you're not out of line of sight of your target, that it's off cooldown and you're using it on an attackable target that exists while Right Alt is down. It's already included in my next Shadow Priest update, also supporting Shadow Word: Insanity

[yourson]

@mentally thanks for fast help, it works well.

[nilrem2004]

@nilrem2004: You kinda need some checks as well in there.. :P Also, like all the other Level 90 Priest talents, they are morphed into depending on your current spec, and we all know how well PQR handles morphed spells! *looks around*
Here you go @fluxflux: -- I also sent this to you as you requested in a PM, but I guess you never recieved it?

local PQ_DStar = 110744
local Nova_Spells = Nova_Spell
local PQ_DSStar = 122128

if Nova_Spells[PQ_DStar].known
	and UnitExists("target")
	and PQR_SpellAvailable(PQ_DSStar)
	and not UnitIsDeadOrGhost("target")
	and not PQR_IsOutOfSight("target", 1)
	and UnitCanAttack("player", "target") == 1
	and IsRightAltKeyDown()
	and not GetCurrentKeyBoardFocus()
then
	SpellStopCasting()
	CastSpellByName(GetSpellInfo(PQ_DSStar),"target")
end

Just like my code for Halo and Cascade, this will check if Divine Star is your selected talent, that you're not out of line of sight of your target, that it's off cooldown and you're using it on an attackable target that exists while Right Alt is down. It's already included in my next Shadow Priest update, also supporting Shadow Word: Insanity

With all do respect but you are wrong. Yout target check is not needed here since there is no target required for Divine Star, so it's just complicates code and can result in an error.Spell is casted to where you are FACING regardless of who/what your target is.
If spell is morphed to shadow yes then ID is 122128. but then you can simply do it like this:

if select(2,GetTalentRowSelectionInfo(6)) == 17 then
if IsRightAltKeyDown() and PQR_SpellAvailable(110774) or PQR_SpellAvailable( 122128 ) then
CastSpellByName("Divine Star")
return true
end
end

or if you will use it only for shadow then:

if select(2,GetTalentRowSelectionInfo(6)) == 17 then
if IsRightAltKeyDown() and PQR_SpellAvailable( 122128 ) then
CastSpellByName(GetSpellInfo(122128 ))
return true
end
end

there are many possibilities to do this without complicating profile since it's always best to simplify code

[Dominium]

Would be great if someone could test my profile in 3v3 as I don't have an active team atm

[maleth]

Update!!

Hand of Sacrifice works **** YEAH!

Cleanses perfectly... ;DD

Yeah its good, I'm liking it alot.

Also you should do the HoS the inc Poly for a Paladins Repentance also, should be easy to do if you have the code for the Poly one. Would work wonders bro.

[NicodemusAtNIMH]

@travis2861: That's some pretty...strange behavior. I personally used the Mage profile while leveling in dungeons and it didn't seem to stop for me. Might be an error somewhere that I haven't picked up yet. Glad you're liking it though. Version 2 will feature a lot more than the current stripped down version. I'll try run a few dungeons with it and see if I can't replicate the problem. Other than that, you could always try and download the PQInterface addon from Team Nova's SVN @ Assembla and see which spell it starts hanging on. Would be useful for me.

To everyone -- I know I promised to have the updated yesterday, but they are coming today! I'm finishing writing up an extended Alter Time dynamic for when you don't use Presence of Mind. It's event driven so it'll react faster than your average elite gamer, haha. Other than that; All talents have been coded and are now supported, all though they don't simulate automatic usage, you're in charge of when things happen. I also switched some of the keybindings around a little bit and also added a complete Pause rotation ability

Shadow Priest have also been updated some to give more surviveability and better mana management depending on your talents, and Demonology got a little buff as well in the next version.

Hopefully it'll all roll out pretty nicely unless I forget something. =)

Curious do you have a Frost version, couple of your post states that you do?

[kickmydog]

Still getting a ton of crashes. Not sure why. Xelper is there anything I can do to help track down the cause? Turn on debug mode? Or send you the crash dump from WoW? Love this program, and I am working around the crashes but it happens multiple times a dungeon or raid run.

A number of people i know who aren't running PQR are getting crashes. I would read the blizzard forums.

[Dominium]

Yeah its good, I'm liking it alot.

Also you should do the HoS the inc Poly for a Paladins Repentance also, should be easy to do if you have the code for the Poly one. Would work wonders bro.

Mhm yeah gona code that soon + fix the Hand of Prot since I don't want it used on myself if I have bubble available ;/

[Kinky]

@nilrem2004: Oh, you're quite right -- it's not absolutely needed. Everyone has a different way of coding. An extra redundant check isn't gonna slow down or decrease performance on the ability though!
I still think it's a bad idea to make it cast without having an attackable target. If anyone is anything like me, I keep my profile running all the time, suddenly hitting the keybinding (for any reason) and fiering it off is just in my opinion a bad coding practice. But hey, that's just me. =D

@NicodemusAtNIMH: Unfortenally, I don't. I'm working on a Frost and Arcane profile at the moment though, so keep on checking bacl =)

[lostwalker]

Guess it's time to start looking for a new warrior profile, sense the last one I was using went pay-to-play. I think I will try the Nova fury profile. I haven't seen another prot profile for warriors.

[Dominium]

Hey all, could someone give me a code to check if party1 ISN'T me (player)? Would a simple and "party1" ~= "player" do the job?

[Kinky]

@Dominium: There's two ways of checking that easily. You can either base it on GUID, or, by name. But players can have the same name from different realms, so the GUID check is the most safe way to do it, unless you don't normally do Dungeons/LFR/Cross-Realm stuff. But again, the chance of someone having the same name as you is pretty slim.

Way 1: GUID

local playerGUID = tonumber(UnitGUID("player"):sub(6,10), 16)
local party1GUID = tonumber(UnitGUID("party1"):sub(6,10), 16)

if IsInGroup() then
	if playerGUID == party1GUID  then return false
	else
		-- Coding here
	end
end

Since GUID absolutely require a target (will return a comparing value to nil otherwise, iirc), I made an extra check to see if you're in a Party or Raid before comparing GUIDS.

Way 2:

if UnitName("player") == UnitName("party1") then return false
else
	-- Coding here
end

This is simply checking your character name against the character name of the first person in your party. Nothing more to say about it. Returns false if your name is the same name as the first person in party/raid.

The same goes for the GUID. Returns false if you're the same person.

[nilrem2004]

@nilrem2004: Oh, you're quite right -- it's not absolutely needed. Everyone has a different way of coding. An extra redundant check isn't gonna slow down or decrease performance on the ability though!
I still think it's a bad idea to make it cast without having an attackable target. If anyone is anything like me, I keep my profile running all the time, suddenly hitting the keybinding (for any reason) and fiering it off is just in my opinion a bad coding practice. But hey, that's just me. =D

@NicodemusAtNIMH: Unfortenally, I don't. I'm working on a Frost and Arcane profile at the moment though, so keep on checking bacl =)

Yeah well I have checks for viable targets and combat at beginning of profile, so basically if you're not in combat rotation is stopped and hitting alt by accident does nothing if ability is below checks :P
It would be nice if we could make char turn towards target before casting abilities like such. Now here's an idea....gonna go research

[maleth]

Dominium, profile working very very well atm. HoS he CC' of Poly is awesome cant wait for the Rep one to be implemented too. Heals very well indeed. Only tried i n 2's at the moment will do 3's tomorrow. Cant wait! So far it seems to be doing the job better than i was playing at 2100 with no PQR. This allows me alot more time to plan positions and have improved awareness. Loving it.