PQR - Rotation Bot

[bu_ba_911]

KMD I recommend using IsPlayerSpell(spellid) for checking if you know a morphed spell

Sent from my Thunderbolt using Tapatalk 2

[kickmydog]

KMD I recommend using IsPlayerSpell(spellid) for checking if you know a morphed spell

Sent from my Thunderbolt using Tapatalk 2

Why is that? I have been using IsSpellKnown() for a little while now. What is better about IsPlayerSpell? Iron Hawk is a talent spell.

[averykey]

For anyone wondering, I have figured out everything with the buffs and seal switching, many thanks to everyone that helped!

Code if anyone needs for reference or if they want to use it.

Buffs

  -- Apply seal if none up
local hasSeal = false
if GetShapeshiftForm("player") == 1 or GetShapeshiftForm("player") == 2
or GetShapeshiftForm("player") == 3 or GetShapeshiftForm("player") == 4 
then hasSeal = true end
if hasSeal == false then CastShapeshiftForm(1) end

--Ret
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Retribution" then
    if not UnitBuffID("player", 19740) then
        CastSpellByName(GetSpellInfo(19740), "player")
    end    
else
if UnitBuffID("player", 19740) and not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
    CastSpellByName(GetSpellInfo(20217), "player")
    end
end

--Prot
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Protection" then
    if not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
        CastSpellByName(GetSpellInfo(20217), "player")
    end
else
if UnitBuffID("player", 20217) or UnitBuffID("player", 1126) and not UnitBuffID("player", 19740) then
    CastSpellByName(GetSpellInfo(19740), "player")
    end
end 

Aoe Mode

  if modtime == nil then
    modtime = 0
end

--right ctrl switches aoe mode
if IsRightControlKeyDown() and GetTime() - modtime > 1  then
    modtime = GetTime()
    if AoeSwap then 
        AoeSwap = nil
        CastShapeshiftForm(1)
        PQR_WriteToChat("Aoe Mode: \124cFFE61515Disabled")
    else
        AoeSwap = 1
        CastShapeshiftForm(2)
        PQR_WriteToChat("Aoe Mode: \124cFF15E615Enabled")
    end
end 

[taker]

The 'Recast Delay' dont work after 'Cancel Channel'

For exemple, when i cast soothing mist a second cast of soothing mist cancel the previous one in loop, how i can add a delay to that ?

[Bgreen12]

Anyone know what I can do to get my interrupts working good on my warrior for pvp? Here's what I would like it to do:

Pummel if in melee range and pummel off cooldown.

If can't pummel and in range for disrupting shout (interact range 3) and ds is off cooldown then do a disrupting shout.

If can't do either and is in range for a heroic throw then heroic throw.

now I've written this all in LUA to interrupt as fast as possible any spell or channelling that I can. It works good however the problem is that since pummel and the other cooldowns are not on the same gcd, it will sometimes blow a pummel and a disrupting at the same time.

Now to fix this what I've done is basically make it try to pummel immediately, and if the cast goes on for more than .5 seconds (meaning I can't pummel) , then use ds or heroic throw. Its really not a huge issue I just like to interrupt immediately.


I think that there must be a better way but I am just not thinking of it. Can someone who is experienced with the coding please help? Thanks.

[bu_ba_911]

The 'Recast Delay' dont work after 'Cancel Channel'

For exemple, when i cast soothing mist a second cast of soothing mist cancel the previous one in loop, how i can add a delay to that ?

add a timer?

[averykey]

Anyone know what I can do to get my interrupts working good on my warrior for pvp? Here's what I would like it to do:

Pummel if in melee range and pummel off cooldown.

If can't pummel and in range for disrupting shout (interact range 3) and ds is off cooldown then do a disrupting shout.

If can't do either and is in range for a heroic throw then heroic throw.

now I've written this all in LUA to interrupt as fast as possible any spell or channelling that I can. It works good however the problem is that since pummel and the other cooldowns are not on the same gcd, it will sometimes blow a pummel and a disrupting at the same time.

Now to fix this what I've done is basically make it try to pummel immediately, and if the cast goes on for more than .5 seconds (meaning I can't pummel) , then use ds or heroic throw. Its really not a huge issue I just like to interrupt immediately.


I think that there must be a better way but I am just not thinking of it. Can someone who is experienced with the coding please help? Thanks.

Not sure how to check if you need to interrupt, Ids might be wrong, just did a quick google sea

local InRange = GetSpellInfo(123287) --0 == true / 1 == false / 0 melee range / 1 out of melee range

if PQR_SpellAvailable(123287) and IsSpellInRange(InRange, "target") == 0 then
    CastSpellByName(GetSpellInfo(123287), "target")
end
elseif PQR_SpellAvailable(102060)  and IsSpellInRange(InRange, "target") == 1 then
    CastSpellByName(GetSpellInfo(102060), "target")
elseif PQR_SpellAvailable(57755)  and IsSpellInRange(InRange, "target") == 1 then
    CastSpellByName(GetSpellInfo(57755), "target")
end 

PQR Reference 2.1.5+

*** Global Variables ***
These global variables can be used/changed to suit your needs. Note that most of these will change back to their default values when a new rotation is started to ensure that a profile is running the way it's creator intended.

PQR_InterruptStarted
-- true if a new interrupt profile has started. You can set this to false and use it as a flag to run code that should only be run once per rotation enable.

*** Interrupt Functions ***

PQR_IsOnInterruptList(spellName)
-- Returns true/false based on if a spell is on the interrupt list on the Settings form or has been added via PQR_AddInterrupt(spellName).

PQR_AddInterrupt(spellName)
-- Adds an interrupt to the interrupt list. The interrupt list is repopulated on interrupt rotation change. You should use PQR_InterruptStarted flag to repopulate the list with any profile-added spells. See PQR_AddToSpellDelayList for an example on how to use this flag. (Note: Change RotationStarted to InterruptStarted)

PQR_AddInterrupt(spellName)
-- Adds an interrupt to the interrupt list. The interrupt list is repopulated on interrupt rotation change. You should use PQR_InterruptStarted flag to repopulate the list with any profile-added spells. See PQR_AddToSpellDelayList for an example on how to use this flag. (Note: Change RotationStarted to InterruptStarted)

[lawlmoto]

Anyone know what I can do to get my interrupts working good on my warrior for pvp? Here's what I would like it to do:

Pummel if in melee range and pummel off cooldown.

If can't pummel and in range for disrupting shout (interact range 3) and ds is off cooldown then do a disrupting shout.

If can't do either and is in range for a heroic throw then heroic throw.

now I've written this all in LUA to interrupt as fast as possible any spell or channelling that I can. It works good however the problem is that since pummel and the other cooldowns are not on the same gcd, it will sometimes blow a pummel and a disrupting at the same time.

Now to fix this what I've done is basically make it try to pummel immediately, and if the cast goes on for more than .5 seconds (meaning I can't pummel) , then use ds or heroic throw. Its really not a huge issue I just like to interrupt immediately.


I think that there must be a better way but I am just not thinking of it. Can someone who is experienced with the coding please help? Thanks.

Make it so it only disrupts if pummel is on cd, or out of range.

[Bgreen12]

Make it so it only disrupts if pummel is on cd, or out of range.

Right let's say all 3 are off cooldown and someone casts what I can interrupt. What is happening is since pummel is off the gcd, it fires both disrupt and pummel at the same time. Maybe I didn't explain this good enough.

[Bgreen12]

Not sure how to check if you need to interrupt, Ids might be wrong, just did a quick google sea

local InRange = GetSpellInfo(123287) --0 == true / 1 == false / 0 melee range / 1 out of melee range

if PQR_SpellAvailable(123287) and IsSpellInRange(InRange, "target") == 0 then
    CastSpellByName(GetSpellInfo(123287), "target")
end
elseif PQR_SpellAvailable(102060)  and IsSpellInRange(InRange, "target") == 1 then
    CastSpellByName(GetSpellInfo(102060), "target")
elseif PQR_SpellAvailable(57755)  and IsSpellInRange(InRange, "target") == 1 then
    CastSpellByName(GetSpellInfo(57755), "target")
end 

6552 is pummel.

IsSpellInRange returns 0 if its not in range 1 if it is in range and nil if the unit is invalid...

There's so much wrong with this code I wouldn't even know where to begin. Thanks for trying though.

[Taran32]

Posted this in Sheep's thread but I was curious to hear a response here as well:

Is there a way one of the profile writers could possibly incorporate Knight's Simcraft Arms profile into an Arms PvP profile that includes Hamstring as needed, Shockwave usage off CD, Piercing Howl as needed, Disarm if applicable, and the Heroic Leap code Ninjaderp linked on the previous page? It'd be something very close to Bu-Ba's old Warrior profile, and that one sadly doesn't work in the current patch.

In essence, it'd basically take the best DPS code from Knight's and add the PvP utility/stun/rooting pressure. I'd do it myself, but I don't know how to combine those. Is that something someone could create for the level 85-90 grind? Other writers are waiting till 90 to make them and I'd really like to try it in current BGs if possible.

[lawlmoto]

Right let's say all 3 are off cooldown and someone casts what I can interrupt. What is happening is since pummel is off the gcd, it fires both disrupt and pummel at the same time. Maybe I didn't explain this good enough.

Yea what I'm saying is have it only disrupting if its out of range of pummel, OR if pummel is off cd.

To make it extra safe you can even make it so if you're in range it'll check if pummel has less than 14 sec, so it'll have an extra 1 sec buffer.

[expunge]

Where is the check for aspect switching? I looked at your code but I don't see a delay or anything, really having problems with seal switching because I think stances are off the gcd like aspects are.

function F_SwitchToHawk()
    if not UnitBuffID("player", 13165)
    and UnitExists("target") 
    then CastSpellByName(GetSpellInfo(13165),nil) end
    end
    
function F_SwitchToFox()
    if PQR_IsMoving(1) 
    and not UnitBuffID("player", 82661) 
    and UnitExists("target") 
    then CastSpellByName(GetSpellInfo(82661),nil) end
    end 

function F_SwitchToHawk()
    if UnitBuffID("player", 13165) == nil then CastSpellByID(13165, "player") end
    end
    
function F_SwitchToFox()
    local FoxBuff = UnitBuffID("player", 82661)
    if PQR_IsMoving(1) == true and FoxBuff == nil and UnitExists("target") then CastSpellByID(82661, "player") end
    end 

edit: lol, at the kids talking about penis size, we know who the kids are now




It has a check in his code so I am not sure why it would be switching

function F_SwitchToHawk()
    if UnitBuffID("player", 13165) == nil
-----------------------------------
function F_SwitchToFox()
local FoxBuff = UnitBuffID("player", 82661)
FoxBuff == nil 

You can call me a kid, I'm not. I was just pressing his buttons because he was obviously riled up.

Okay, so, in his script, if you stand still, start the script, and start firing shots it will flip in and out of Iron hawk. It usually happens on any spell with the F_SwitchToHawk function at the top of it. It just looks a little suspect to always be doing it. I tried to fix it but could never pin point exactly where it is. Oh well, KMD is awesome and it might just be something on my side. I'm more than happy to help with anything you guys need.

I'm starting to think that the data file that was included in the _5 pack wasn't needed? I didn't even think about taking it out. It might just be double calling that function. I'll check it out.

Avery, love your pally script, works great!

[kickmydog]

You can call me a kid, I'm not. I was just pressing his buttons because he was obviously riled up.

Okay, so, in his script, if you stand still, start the script, and start firing shots it will flip in and out of Iron hawk. It usually happens on any spell with the F_SwitchToHawk function at the top of it. It just looks a little suspect to always be doing it. I tried to fix it but could never pin point exactly where it is. Oh well, KMD is awesome and it might just be something on my side. I'm more than happy to help with anything you guys need.

I'm starting to think that the data file that was included in the _5 pack wasn't needed? I didn't even think about taking it out. It might just be double calling that function. I'll check it out.

Avery, love your pally script, works great!

Might want to try scrolling back a page or two and checking the solution for this that I posted.

[expunge]

Might want to try scrolling back a page or two and checking the solution for this that I posted.

Yep, just saw it, thanks