PQR - Rotation Bot

[Ninjaderp]

Well you should make a list of features you would have implemented in your "real beast pvp-subprofile" so they got something to work on? ^^

[bu_ba_911]

Lol the reason rogue profile seems to only be a leveling profile is because I stopped leveling my rogue XD

Sent from my phone using Tapatalk

[Ralphiuss]

I believe sheuron has a sub pvp profile in his pack as well.

[Ninjaderp]

Yeah I've seen that in my profile-list a Xrn Sub PVP-profile.

[firepong]

@ firepong

Currently under the rotation I'm using I need the ability to judge a focus target if I have one and judge my target if I don't have one. Right now I have to have 2 different rotations and swap between them depending if there is going to be a focus target or not. If I forget to focus a target judgement just doesn't go off. Here is the code for both judgements under with and without Zealotry.

local holyPower = UnitPower("player", 9)
local zealotry = PQR_UnitBuffID("player", 85696)


if holyPower <= 2 and zealotry == nil then
	return true
end

local holyPower = UnitPower("player", 9)
local zealotry = PQR_UnitBuffID("player", 85696)


if zealotry and holyPower < 3 then
	return true
end

Is there anyway I can clean this code up so it's under one ability and on top of that making it default to my target if I don't have a focus? Right now I just have 2 versions 1 for focus and 1 for target.

I don't see any code there for your judgement, so I'll try and do what I can. Since this is for Retribution DPS Spec, your mainly doing it off CD for the 4piece free HoPo and mana correct? If so, if should be something like this, hopefully:

Name: Judgement
SpellID: 0
Delay: 0
Target: Custom

local judgeCD = GetSpellCooldown(20271)
local HoPo = UnitPower("Player", 9)
local zeal = UnitBuffID("Player", 85696)
local Focus = UnitExists("Focus")
local Target = UnitExists("Target")

if judgeCD == 0 and HoPo <= 2 and Focus == 1 and not zeal then
	CastSpellByName(tostring(GetSpellInfo(20271)), "Focus")
elseif judgeCD == 0 and HoPo <= 2 and Target == 1 and Focus == nil and not zeal then
	CastSpellByName(tostring(GetSpellInfo(20271)), "Target")
elseif judgeCD == 0 and HoPo < 3 and Focus == 1 and zeal then
	CastSpellByName(tostring(GetSpellInfo(20271)), "Focus")
elseif judgeCD == 0 and HoPo < 3 and Target == 1 and Focus == nil and zeal then
	CastSpellByName(tostring(GetSpellInfo(20271)), "Focus")
end

Tested and Working. My pally doesn't have the 4piece DPS set, so I wasn't getting HoPo, but it was working as intended. Working good enough to get rid of every Judgement code in Ralphiuss' profile except the one at the very beginning. And even then, I could have coded that in as well, but I figured he put judgement lower down in the rotation for a reason.

[Ralphiuss]

@ firepong

Currently under the rotation I'm using I need the ability to judge a focus target if I have one and judge my target if I don't have one. Right now I have to have 2 different rotations and swap between them depending if there is going to be a focus target or not. If I forget to focus a target judgement just doesn't go off. Here is the code for both judgements under with and without Zealotry.

local holyPower = UnitPower("player", 9)
local zealotry = PQR_UnitBuffID("player", 85696)


if holyPower <= 2 and zealotry == nil then
	return true
end

local holyPower = UnitPower("player", 9)
local zealotry = PQR_UnitBuffID("player", 85696)


if zealotry and holyPower < 3 then
	return true
end

Is there anyway I can clean this code up so it's under one ability and on top of that making it default to my target if I don't have a focus? Right now I just have 2 versions 1 for focus and 1 for target.

Can I ask what is the need to be able to judge a focused target VS just judging a target?

[Ninjaderp]

IDK either, but I would pick my guess its for Arena

[imdasandman]

Yea I tried completely removing ElvUI and its actually still not working for me so apparently It's another issue. Currently looking into it.

Are you lauanching the 32 bit wow.exe? If you use the wow launcher it will sometimes select the 64 bit wow.exe

Sent from my SAMSUNG-SGH-I717 using Tapatalk 2

[Ralphiuss]

What does "tostring" mean?

[js1974]

Can I ask what is the need to be able to judge a focused target VS just judging a target?

Mainly it's about DPS, If you keep 5 stack of censure rolling on 2 targets you perform better then just keeping it rolling on your primary target. Unfortunately there aren't a ton of places you can use it in DS but there are a few places and it still adds up.

[firepong]

What does "tostring" mean?

It converts the code to a string of text. Normally, it takes the first iteration of the API pretty much. For example, tostring(GetSpellInfo(20271) reports Judgement. Another example ofthis if you want to test it in different occurrences is to just do print(tostring(GetSpellInfo(20271)) in a macro - /run print(tostring(GetSpellInfo(20271)) - or just put it in a empty rotation with it's own ability in it and make sure combat start is un-checked.

[Lexi777]

So I'm using Blinded's Sub profile and I also used the arena EDITED version of Blinded's profile, (I'm sorry I forgot who made this)

In the edited version it auto stealth's you when you're out of combat... even if you're mounted, I was wondering how to edit this so it still auto stealths me whenever im out of combat but just not when I'm on my mount.

if not UnitAffectingCombat("player")
and not UnitBuffID("player", 1784) then
return true
end

[bu_ba_911]

It converts the code to a string of text. Normally, it takes the first iteration of the API pretty much. For example, tostring(GetSpellInfo(20271) reports Judgement. Another example ofthis if you want to test it in different occurrences is to just do print(tostring(GetSpellInfo(20271)) in a macro - /run print(tostring(GetSpellInfo(20271)) - or just put it in a empty rotation with it's own ability in it and make sure combat start is un-checked.

lol everything firepong said is true, but you will need to add a ) to every single example he posted i guess some1 has a bad habit XD

[firepong]

lol everything firepong said is true, but you will need to add a ) to every single example he posted i guess some1 has a bad habit XD

Hey, I can't help it. I only catch it while coding because PQR and Notepad+ has a syntax engine in it and shows you when you have a open code error

When I type it out here on the forums, I just forget to put a double ) in there every now and then. Can't blame a man for being lax

I mean hell, sometimes, I just miss it all together. When I was coding the Judgement ability above, I kept getting friggin errors when I started the rotation, stopping on Judgement. I spent a hour looking it over, re-typing the if's and elseif's 3 different times . At the end, I was just about to give up and call it a loss, but guess what, I put 2 ='s in the bottom local. FFS, this was no end missing or a ) missing, it was a damn = in the wrong place. It tell's just how dedicated I am to getting something working. If someone asks nicely, I will see what I can do and that proved it

EDIT* At least some of my stuff does it's job. Can't say that to well about my Data file though /cough cough

[Ralphiuss]

I kinda wanna take up another class...any request?