[BETA] PQRotation - an automated ability priority queue.

[darkayo]

Yay, thanks ! You're the one.
I test it now

[Valma]

The reason SetRecastDelay is called so often is because of spells that have a cast time but also have a travel time. It is not very resource intensive at all, it just spams the hell out of the debug log on Advanced.

Say you have an ability that has a 2s cast time, that you cast to put up a buff as priority number one, and that you cast as a filler when everything else is on cooldown. The cast is longer than your GCD, and has a 1.5 second max flight time from 40 yards.

Here is the problem, with only using UNIT_SPELLCAST_SUCCEEDED (we cant use SENT because that can send and it wont cast because you are on GCD):
You cast the spell, it has a delay of 2 seconds. Prior to your spell fully casting, you are already off GCD and ready to start casting the next ability. The bot is thinking "Oh I need to put up this buff still" so it is queueing up that same ability even though you do not want it to cast. You then end up casting that same ability twice in a row.

If you have a better solution I would love to hear it. I do not want to try to use SPELLCAST_SENT to mark it as delayed, then SPELLCAST_FAILED to mark it as not delayed because that could cause the bot to skip over the ability for a cycle and try to cast something else. The bot is performing a dozen other checks per ability anyway, 1 more check for a complete ability check cycle isn't going to cause any major issues.

UNIT_SPELLCAST_START fires only when we start casting a spell with casttime and not instant cast.

	function events:UNIT_SPELLCAST_START(...)
		if (select(1, ...) == PQ_player or select(1, ...) == PQ_RaidIndex) then	
			if PQ_Skills[select(5, ...)] then
				PQ_Skills[select(5, ...)].nexttest = select(6, UnitCastingInfo(PQ_player)) / 1000 + PQ_Skills[select(5, ...)].delay
			end
		end
	end

This is what I got and it works fine.Fires only for your spells,then I'm setting RecastDelay= spellcasttime + abilitydelay
So for spells that needs to be chaincasted like Incinerate you can set abilitydelay to negative value and for spells that grants buffs like Soul Fire you can set this to travel time :/

Furthermore you need to use UNIT_SPELLCAST_SUCCEEDED to grab instantcasts also.

[hbkx1]

@ Valma when the fix is in for the felguard recast it should be perfect the dps is amazing

[stec2012]

Ye the rotations look super Slick Valma, just the Demo one constant casting Felguard sucks :P

[Xelper]

UNIT_SPELLCAST_START fires only when we start casting a spell with casttime and not instant cast.

    function events:UNIT_SPELLCAST_START(...)
        if (select(1, ...) == PQ_player or select(1, ...) == PQ_RaidIndex) then    
            if PQ_Skills[select(5, ...)] then
                PQ_Skills[select(5, ...)].nexttest = select(6, UnitCastingInfo(PQ_player)) / 1000 + PQ_Skills[select(5, ...)].delay
            end
        end
    end

This is what I got and it works fine.Fires only for your spells,then I'm setting RecastDelay= spellcasttime + abilitydelay
So for spells that needs to be chaincasted like Incinerate you can set abilitydelay to negative value and for spells that grants buffs like Soul Fire you can set this to travel time :/

Furthermore you need to use UNIT_SPELLCAST_SUCCEEDED to grab instantcasts also.

Fair enough, I already use UNIT_SPELLCAST_SUCCEEDED for instant casts. What I am going to do is this:
On UNIT_SPELLCAST_START:
If recastDelay > 0 set delay to: spell cast time + recastDelay
On UNIT_SPELLCAST_SUCCEEDED:
Set delay to: recastDelay
On UNIT_SPELLCAST_INTERRUPTED (if you move, stopcasting, etc, etc):
Set delay to: 0

[Valma]

I don't got what you all mean on constantly casting felguard :/ Downloaded profile from my googlecode(as you all do) and started it.When I start it - it doesn't try to cast felguard,then if I will take bossdummy in target it WILL cast felguard TWICE(yes I know about that,fix will be a bit later) then if I attack bossdummy it pops felstorm,soulburn and so on,waits till felstorm falls of from FG and then summons FH.From this point it starts to use soul fire under soulburn.This is bosslogic.

If I get out of fight and press right ctrl it notifies on screen and actually changes logic so if you got notify PETSWAP OFF you can summon FH and you will see that FG isn't summoned.

[Valma]

Fair enough, I already use UNIT_SPELLCAST_SUCCEEDED for instant casts. What I am going to do is this:
On UNIT_SPELLCAST_START:
If recastDelay > 0 set delay to: spell cast time + recastDelay
On UNIT_SPELLCAST_SUCCEEDED:
Set delay to: recastDelay
On UNIT_SPELLCAST_INTERRUPTED (if you move, stopcasting, etc, etc):
Set delay to: 0

This is a bit wrong,coz as I said for chaincasting spells you need recastDelay to be set to negative value.Plus this check is not needed at all,just go for delay=spell cast time + recastDelay

Or you are comparing "spellwillbeavailable" = GetTime()+recast to current GetTime()+PQR_SpellAvailableTime in PQ_IsSpellAvailable?

[stec2012]

For me Valma and i think for others it seems to be stuck in felguard loop and just recasts it over and over, il try again in a mo when i get out of LFR

EDIT: Trying now and once i enter combat it stops loop, il post again when boss fight finishes to see if it resumes summoning or not.

EDIT: Going through boss fight with STANDART posted in middle of screen, should it fade out? and right CTRl does nothing during fight for me at moment.

EDIT: Boss fight over and Felguard looping resumes, Right CTRL Does nothign out of combat either for me

[Mpzor]

Cant wait for an update from kickmydog Best profiles for a surv hunter by far, imo ofc

[slipciok]

There is any page witch PQR rotations? I'm looking good pve rotation for my arms warrior, and i can only find Buuba or Boss (but boss is only for boss in raids and bubba mosty pvp).

[Taran32]

@Xelper

Your new Ret profile is only spamming LUA errors + auto-attacking. Is is only supposed to be used with PQR2? It did the same for me on that one as well. I grabbed the version you uploaded just a few posts back, so it should have been the most recent.

[Valma]

For me Valma and i think for others it seems to be stuck in felguard loop and just recasts it over and over, il try again in a mo when i get out of LFR

EDIT: Trying now and once i enter combat it stops loop, il post again when boss fight finishes to see if it resumes summoning or not.

EDIT: Going through boss fight with STANDART posted in middle of screen, should it fade out? and right CTRl does nothing during fight for me at moment.

EDIT: Boss fight over and Felguard looping resumes, Right CTRL Does nothign out of combat either for me

Are you sure that you are using my LAST updated rotation from DOWNLOAD section?Coz SVN was not update for some fixes Updated SVN now.

[Xelper]

@Xelper

Your new Ret profile is only spamming LUA errors + auto-attacking. Is is only supposed to be used with PQR2? It did the same for me on that one as well. I grabbed the version you uploaded just a few posts back, so it should have been the most recent.

I am not 100% sure if it would load in PQR1.1. Best to be safe and use 2.0. The spell delay stuff certainly wouldn't work in 1.x.

Make sure you have the latest version.
http://dl.dropbox.com/u/39925787/PALADIN_Abilities.zip

[stec2012]

Are you sure that you are using my LAST updated rotation from DOWNLOAD section?Coz SVN was not update for some fixes Updated SVN now.

Haha that may be the issue on my DK now il try again later :P

[sheuron]

can this profiles still be used with 1.11 as i use Kickmydog's hunter profile mainy, and then yours on certain fights.

No. But you can use old profiles, the diferencie is new PQR functions used.