[BETA] PQRotation - an automated ability priority queue.

[PureLife]

Does it say anything else with the error.

Strange tho as i tested it in our raid last night, and the only change before uploading it was done today by spacing out the coding to make it neater/easyer to read/edit.

While changing the formating i probably made a typo somewhere. Ill try and find it now

I've found out that the problem in the code lies within the first ability casting Heroic Will, I've removed the whole bunch and it works perfectly. I'm still not sure what is wrong with it... trying to find out more.

I'll stress test the rest of the codes to see how it fares.

[Lofty]

I've found out that the problem in the code lies within the first ability casting Heroic Will, I've removed the whole bunch and it works perfectly. I'm still not sure what is wrong with it... trying to find out more.

I'll stress test the rest of the codes to see how it fares.

Humm strange. That code was a copy/paste. Ill take a look

[Tyron1989]

Hi Ash thanks for getting back to me, maybe your right it is a bad idea but i hate manually focusing in 5mans when i tried a raid last night it didn't auto focus or tank switch

would a simple lifebloom on person with the most HP work better?

[sheuron]

@Xelper, when is PQR reset PQR_CustomTarget varialble? found a strange behaviour.

I define two variables at start

PQR_CustomTarget
PQR_CustomTargetHP

Noticed sometimes the rotation it not healing who should, so i dumped variables to chat

print(PQR_CustomTarget.." - "..PQR_CustomTargetHP)

Then saw sometimes the PQR_CustomTarget is empty.

[travis2861]

Hey sheuron first of id like to say that you profiles are out of this world, your support for that many classes is insane. But with i be leave the last 4 versions of you profiles, starting with your addition of the disc pvp in the pack combat rogues are experiencing a HUGE DPS loss of roughly 7 to 10k on the raiders dummy dependent upon gear, i wish i could do more then just bring the issue to you attention ive sent you a PM aswell as posted in here once before about this issue there is also one other person that ive seen who has had this isse thank you for you time in reading this and never stop your amazing work! cheers.


Edit 1. The detail of the issue are in the PM

[sheuron]

Hey there Sheuron, good work. Survival seems to be pulling the top DPS these days, any chance you're working on that or a BM spec? I use one already but would love to see your take.

Siimulationcraft show survival as lowest pve hunter class

[Gabbz]

Hey sheuron first of id like to say that you profiles are out of this world, your support for that many classes is insane. But with i be leave the last 4 versions of you profiles, starting with your addition of the disc pvp in the pack combat rogues are experiencing a HUGE DPS loss of roughly 7 to 10k on the raiders dummy dependent upon gear, i wish i could do more then just bring the issue to you attention ive sent you a PM aswell as posted in here once before about this issue there is also one other person that ive seen who has had this isse thank you for you time in reading this and never stop your amazing work! cheers.


Edit 1. The detail of the issue are in the PM

Just remove Ambush, Recuperate, Rupture and Shiv from the rotation and you will gain alot of DPS. I dont think they are something a PvE Combat Rogue should do, at least according to the guide i read on manaflask.

---------- Post added at 06:52 AM ---------- Previous post was at 06:50 AM ----------

Hi Ash thanks for getting back to me, maybe your right it is a bad idea but i hate manually focusing in 5mans when i tried a raid last night it didn't auto focus or tank switch

would a simple lifebloom on person with the most HP work better?

I would say that defining a MainTank and a OffTank should be done per configuration. You should always have Lifebloom and Rejuv on the tank regardless. Almost all healing profiles are more or less doing a FFA healing strategy. I will extend the excellent work from Ash and getting a more Tank oriented profile.

[Eff]

Hi Ash thanks for getting back to me, maybe your right it is a bad idea but i hate manually focusing in 5mans when i tried a raid last night it didn't auto focus or tank switch

would a simple lifebloom on person with the most HP work better?

That's strange it should auto-focus the highest threat tank on your current enemy target, that's one part of the rotation I've never had any issues with - unless you disabled it in the functions config?
As for the highest HP target, I just tried that in a 5man and it failed, hard. We had a badly geared tank and a PvP geared Paladin who had more HP than him, wouldn't focus the tank and because of his gear he just died.
If you really want to go ahead with the idea, then inside of the ability "Set Focus" change the following:

for i  = 1, GetNumRaidMembers(), 1 do to for i  = 1, GroupMembers, 1 do

local Member = "raid"..tostring(i) to local Member = GroupType..tostring(i)

Those were put in place to stop tank switching in 5mans because you only have one tank, but if you remove the raid checks it'll allow you to auto-focus one if you target a mob he's tanking - the code is untested, but should be enough to do what you need.

I would say that defining a MainTank and a OffTank should be done per configuration. You should always have Lifebloom and Rejuv on the tank regardless. Almost all healing profiles are more or less doing a FFA healing strategy. I will extend the excellent work from Ash and getting a more Tank oriented profile.

You might want to take a look at most of the autotargeting functions in the healing profiles, the tanks are already given a higher priority and certainly in mine HoTs are always present on the current tank but I'd like to hear your thoughts on how it could be improved rather than forking a new build of the rotation.

[Gorthok]

I"M BacK!

Attachment 5598

So I finally got around to remaking my Death Knight profiles after my computer fried, I am done they are updated for 4.3

Enjoy

Download links:

Attachment 5596
Attachment 5597


Abilities:

<?xml version="1.0" encoding="utf-8" ?><DEATHKNIGHT><Ability><Name>Rune Strike</Name><Default>false</Default><SpellID>56815</SpellID><Actions>/startattack</Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Obliterate</Name><Default>false</Default><SpellID>49020</SpellID><Actions>/startattack|/use 10</Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Howling Blast</Name><Default>false</Default><SpellID>49184</SpellID><Actions>/startattack</Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Blood Strike</Name><Default>false</Default><SpellID>45902</SpellID><Actions></Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost Strike</Name><Default>false</Default><SpellID>49143</SpellID><Actions></Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: RaiseDead(US)</Name><Default>false</Default><SpellID>46584</SpellID><Actions></Actions><Lua>local bUS =  UnitBuffID(&amp;quot;player&amp;quot;, 53365)
local bPoF =  UnitBuffID(&amp;quot;player&amp;quot;,51271)

if UnitLevel(&amp;quot;target&amp;quot;) &amp;gt;= 87 or UnitLevel(&amp;quot;target&amp;quot;) == -1 then 
	if UnitHealth(&amp;quot;target&amp;quot;) &amp;gt; 300000  then
		if bUS ~= nil then
			return true
		end
	end
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Death Strike</Name><Default>false</Default><SpellID>49998</SpellID><Actions></Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Horn of Winter</Name><Default>false</Default><SpellID>57330</SpellID><Actions></Actions><Lua>local Horn, _, _, _, _, _, hwexpire = UnitBuffID(&amp;quot;player&amp;quot;, 57330)

if Horn ~= nill then
	hwexpire =(hwexpire - GetTime())
	if hwexpire &amp;lt; 5 then
		return true
	end
else
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>All: Mind Freeze</Name><Default>false</Default><SpellID>53550</SpellID><Actions></Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Festering Strike</Name><Default>false</Default><SpellID>85948</SpellID><Actions></Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Pestilence</Name><Default>false</Default><SpellID>50842</SpellID><Actions></Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Blood Tap</Name><Default>false</Default><SpellID>45529</SpellID><Actions>/startattack</Actions><Lua>return true</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: FrostStrike(rp-cap)</Name><Default>false</Default><SpellID>49143</SpellID><Actions></Actions><Lua>-- change rp vaule if you want to allow for rime to 40
local rp = 40

if (UnitPowerMax(&amp;quot;player&amp;quot;) - UnitPower(&amp;quot;player&amp;quot;)) &amp;lt; rp then
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: PlagueStrike(bpexpire)</Name><Default>false</Default><SpellID>45462</SpellID><Actions>/startattack</Actions><Lua>local dbBloodPlague, _, _, _, _, _, BloodPlagueExpire = UnitDebuffID(&amp;quot;target&amp;quot;,59879, &amp;quot;player&amp;quot;)

if dbBloodPlague ~= nil then	
	BloodPlagueExpire =(BloodPlagueExpire - GetTime())
	if BloodPlagueExpire &amp;lt; 4 then
		return true
	end
else
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: PillarOfFrost(400k)</Name><Default>false</Default><SpellID>51271</SpellID><Actions>/startattack</Actions><Lua>if UnitHealth(&amp;quot;target&amp;quot;) &amp;gt;= 400000  then 
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: RaiseDead(US+PoF)</Name><Default>false</Default><SpellID>46584</SpellID><Actions></Actions><Lua>local bUS =  UnitBuffID(&amp;quot;player&amp;quot;, 53365)
local bPoF =  UnitBuffID(&amp;quot;player&amp;quot;,51271)

if UnitLevel(&amp;quot;target&amp;quot;) &amp;gt;= 87 or UnitLevel(&amp;quot;target&amp;quot;) == -1 then 
	if UnitHealth(&amp;quot;target&amp;quot;) &amp;gt; 300000  then
		if bUS ~= nil and bPoF ~= nil then
			return true
		end
	end
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>All: Outbreak(400k)</Name><Default>false</Default><SpellID>77575</SpellID><Actions></Actions><Lua>
        local dbBloodPlague, _, _, _, _, _,BloodPlagueExpire = UnitDebuffID(&amp;quot;target&amp;quot;,59879, &amp;quot;player&amp;quot;)
		
        if UnitHealth(&amp;quot;target&amp;quot;) &amp;gt;= 400000  then 	
            if  dbBloodPlague ~= nil then		
                BloodPlagueExpire =(BloodPlagueExpire - GetTime())
                if BloodPlagueExpire &amp;gt;= 3 then
                    return true
                end
            else
                return true
            end
        end
        </Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: Obliterate(2eR+KM)</Name><Default>false</Default><SpellID>49020</SpellID><Actions>/startattack</Actions><Lua>local _,_,d1 =GetRuneCooldown(1)

local _,_,d2 =GetRuneCooldown(2)


local _,_,u3 =GetRuneCooldown(3)

local _,_,u4 =GetRuneCooldown(4)

local _,_,f5 = GetRuneCooldown(5)

local _,_,f6 = GetRuneCooldown(6)
local KM = UnitBuffID(&amp;quot;player&amp;quot;,51128)

if u3 == true and u4 == true and f5 == true and f6 == true then	
	return true
elseif d1 == true and d2 == true then	
	return true
elseif KM ~= nil then
	return true	
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>All: BloodTap(time5)</Name><Default>false</Default><SpellID>45529</SpellID><Actions></Actions><Lua>local time1,dur1,d1=GetRuneCooldown(1)
local time2,dur2,d2=GetRuneCooldown(2)

if  d1 == false or d2 == false then

   time1 = time1 + dur1 - GetTime()

   time2 = time2 + dur2 - GetTime()

   if time1 &amp;gt; 5 or time2 &amp;gt; 5 then

      return true

   end

end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: FrostStrike(Brez50)</Name><Default>false</Default><SpellID>49143</SpellID><Actions></Actions><Lua>if  UnitPower(&amp;quot;player&amp;quot;) &amp;gt; 82 then
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Horn of Winter(on)</Name><Default>false</Default><SpellID>57330</SpellID><Actions></Actions><Lua>local bHoW =  UnitBuffID(&amp;quot;player&amp;quot;, 57330)

if bHoW == nill then
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: HowlingBlast (FF4)</Name><Default>false</Default><SpellID>49184</SpellID><Actions>/startattack</Actions><Lua>local dbFrostFever, _, _, _, _, _, dbexpire = UnitDebuffID(&amp;quot;target&amp;quot;,55095, &amp;quot;player&amp;quot;)

if dbFrostFever ~= nil then		
	dbexpire =(dbexpire - GetTime())
	if dbexpire &amp;lt; 4 then
		return true
	end
else
	return true
end</Lua><RecastDelay>1000</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>All: DeathStrke(20%hp)</Name><Default>false</Default><SpellID>49998</SpellID><Actions></Actions><Lua>local HP = UnitHealth(&amp;quot;player&amp;quot;) / UnitHealthMax(&amp;quot;player&amp;quot;) * 100

if HP &amp;lt; 21 then
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>All: DeathStrke(30%hp)</Name><Default>false</Default><SpellID>49998</SpellID><Actions></Actions><Lua>local HP = UnitHealth(&amp;quot;player&amp;quot;) / UnitHealthMax(&amp;quot;player&amp;quot;) * 100
local DS = UnitBuffID(&amp;quot;player&amp;quot;, 96281)

if DS ~= nil and  HP &amp;lt; 30 then
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>All: DeathStrke(70%hp)</Name><Default>false</Default><SpellID>49998</SpellID><Actions></Actions><Lua>local HP = UnitHealth(&amp;quot;player&amp;quot;) / UnitHealthMax(&amp;quot;player&amp;quot;) * 100
local DS = UnitBuffID(&amp;quot;player&amp;quot;, 96281)

if DS ~= nil and  HP &amp;lt; 70 then
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Frost: HowlingBlast(r+Hero+p)</Name><Default>false</Default><SpellID>49184</SpellID><Actions>/startattack</Actions><Lua>local _,_,d1=GetRuneCooldown(1)

local _,_,d2=GetRuneCooldown(2)

local _,_,u3 =GetRuneCooldown(3)

local _,_,u4 =GetRuneCooldown(4)
local heroism = UnitBuffID(&amp;quot;player&amp;quot;, 32182)
local lust = UnitBuffID(&amp;quot;player&amp;quot;, 2825)
local warp = UnitBuffID(&amp;quot;player&amp;quot;, 80353)
local hysteria = UnitBuffID(&amp;quot;player&amp;quot;, 90355)
local FreezingFog = UnitBuffID(&amp;quot;player&amp;quot;, 59052)

if heroism ~= nil or lust ~= nil or warp ~= nil or hysteria ~= nil then
	if d1 == false and d2 == false and u3 == false and u4 == false then 
		return true
	end
elseif FreezingFog ~= nil then
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>F+U:Trinket1</Name><Default>false</Default><SpellID>0</SpellID><Actions>/use 13</Actions><Lua>if  GetInventoryItemCooldown(&amp;quot;player&amp;quot;,14) == 0 then UseInventoryItem(14) end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>F+U:Trinket2</Name><Default>false</Default><SpellID>0</SpellID><Actions>/use 14</Actions><Lua>if  GetInventoryItemCooldown(&amp;quot;player&amp;quot;,14) == 0 then UseInventoryItem(14) end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>All: SynapseSprings</Name><Default>false</Default><SpellID>0</SpellID><Actions>/use 10</Actions><Lua>local bPoF =  UnitBuffID(&amp;quot;player&amp;quot;,51271)
local PoFStart, PoFDuration = GetSpellCooldown(51271)
local PoFCD = (PoFStart + PoFDuration - GetTime())

-- PoFCD &amp;lt;= 25

if bPoF ~= nil  then
	return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>Use: MouseOver</Name><Default>false</Default><SpellID>0</SpellID><Actions></Actions><Lua>if IsMouseButtonDown() then if UnitAffectingCombat(&amp;quot;player&amp;quot;) then RunMacroText(&amp;quot;/click &amp;quot;..GetMouseFocus():GetName()) end end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability><Ability><Name>All: DnD</Name><Default>false</Default><SpellID>0</SpellID><Actions></Actions><Lua>local _,lcd =  GetSpellCooldown(43265)

if lcd == 0 and IsControlKeyDown()  and GetCurrentKeyBoardFocus() == nil then
  CastSpellByID(43265)
  if SpellIsTargeting() then CameraOrSelectOrMoveStart() CameraOrSelectOrMoveStop() end  
  return true
end</Lua><RecastDelay>0</RecastDelay><Target>Target</Target><CancelChannel>False</CancelChannel><LuaBefore></LuaBefore><LuaAfter></LuaAfter></Ability></DEATHKNIGHT>

Rotations:

<?xml version="1.0" encoding="utf-8" ?><DEATHKNIGHT><Rotation><RotationName>Frost</RotationName><RotationDefault>false</RotationDefault><RotationList>All: DnD|All: DeathStrke(30%hp)|All: BloodTap(time5)|Frost: PillarOfFrost(400k)|Frost: RaiseDead(US+PoF)|All: Outbreak(400k)|Frost: PlagueStrike(bpexpire)|Frost: HowlingBlast (FF4)|Frost: Obliterate(2eR+KM)|Frost: FrostStrike(rp-cap)|Frost: HowlingBlast(r+Hero)|Obliterate|Frost Strike|Howling Blast|Horn of Winter|Frost: RaiseDead(US)</RotationList><RequireCombat>true</RequireCombat><RotationNotes>Press and HOLD ctrl to cast Death and Decay at mouseover

Don&amp;apos;t forget to +rep if you like a profile!</RotationNotes></Rotation><Rotation><RotationName>Frost Brez</RotationName><RotationDefault>false</RotationDefault><RotationList>All: DnD|All: DeathStrke(30%hp)|All: BloodTap(time5)|Frost: PillarOfFrost(400k)|Frost: RaiseDead(US+PoF)|All: Outbreak(400k)|Frost: PlagueStrike(bpexpire)|Frost: HowlingBlast (FF4)|Frost: Obliterate(2eR+KM)|Frost: FrostStrike(rp-cap)|Frost: HowlingBlast(r+Hero+p)|Obliterate|Frost: FrostStrike(Brez50)|Howling Blast|Horn of Winter|Frost: RaiseDead(US)</RotationList><RequireCombat>true</RequireCombat><RotationNotes>Press and HOLD ctrl to cast Death and Decay at mouseover

Don&amp;apos;t forget to +rep if you like a profile!</RotationNotes></Rotation><Rotation><RotationName>Frost Trash</RotationName><RotationDefault>false</RotationDefault><RotationList>All: DnD|All: DeathStrke(30%hp)|All: BloodTap(time5)|Frost: PillarOfFrost(400k)|Frost: HowlingBlast (FF4)|Frost: Obliterate(2eR+KM)|Frost: FrostStrike(rp-cap)|Frost: HowlingBlast(r+Hero+p)|Obliterate|Frost Strike|Howling Blast|Horn of Winter|All - Death and Decay</RotationList><RequireCombat>true</RequireCombat><RotationNotes>Press and HOLD ctrl to cast Death and Decay at mouseover

Don&amp;apos;t forget to +rep if you like a profile!</RotationNotes></Rotation></DEATHKNIGHT>

[Tyron1989]

That's strange it should auto-focus the highest threat tank on your current enemy target, that's one part of the rotation I've never had any issues with - unless you disabled it in the functions config?
As for the highest HP target, I just tried that in a 5man and it failed, hard. We had a badly geared tank and a PvP geared Paladin who had more HP than him, wouldn't focus the tank and because of his gear he just died.
If you really want to go ahead with the idea, then inside of the ability "Set Focus" change the following:

for i  = 1, GetNumRaidMembers(), 1 do to for i  = 1, GroupMembers, 1 do

local Member = "raid"..tostring(i) to local Member = GroupType..tostring(i)

Those were put in place to stop tank switching in 5mans because you only have one tank, but if you remove the raid checks it'll allow you to auto-focus one if you target a mob he's tanking - the code is untested, but should be enough to do what you need.



You might want to take a look at most of the autotargeting functions in the healing profiles, the tanks are already given a higher priority and certainly in mine HoTs are always present on the current tank but I'd like to hear your thoughts on how it could be improved rather than forking a new build of the rotation.

Hi Ash,

thanks for replying but when in a raid when i make the auto focus target change will it only search in my group?

[cokx]

Hey ive got a big problem, i want to set my customtargettarget

but i tried so many different ways and it doesnt worked:

if GetNumRaidMembers() > 0 then
  group = "raid"
  targettest = "target"
  members = GetNumRaidMembers()
end

for i = 1, members, 1 do
  local member = group..tostring(i)
  local memberstarget = group..tostring(i)..targettest

he locals member as raid1,raid2,raid3 aso...
but for targettarget i need
raid1target
raid2target
....
but it always replies a nil value

[Eff]

Hi Ash,

thanks for replying but when in a raid when i make the auto focus target change will it only search in my group?

If you make the change it'll work as normal in raids and will just find the tank in the party from the current mob/boss you're targeting. It's untested, but that's how it should work...no gurantees though.

[sheuron]

Hey sheuron first of id like to say that you profiles are out of this world, your support for that many classes is insane. But with i be leave the last 4 versions of you profiles, starting with your addition of the disc pvp in the pack combat rogues are experiencing a HUGE DPS loss of roughly 7 to 10k on the raiders dummy dependent upon gear, i wish i could do more then just bring the issue to you attention ive sent you a PM aswell as posted in here once before about this issue there is also one other person that ive seen who has had this isse thank you for you time in reading this and never stop your amazing work! cheers.


Edit 1. The detail of the issue are in the PM

Try this:

xeroncombat301211bPQRProfiles.zip

Just tested on Ultraxion, 30k dps with 381 item level

[Xelper]

@Xelper, when is PQR reset PQR_CustomTarget varialble? found a strange behaviour.

I define two variables at start

PQR_CustomTarget
PQR_CustomTargetHP

Noticed sometimes the rotation it not healing who should, so i dumped variables to chat

print(PQR_CustomTarget.." - "..PQR_CustomTargetHP)

Then saw sometimes the PQR_CustomTarget is empty.

PQR_CustomTarget is reset to an empty string when the custom cast is sent:

                        elseif PQR[rotation].priorityTable.targetCast[nextAbility] == "custom" then
                            PQR_Debug("Casting Spell "..castingName.." ("..castingID..") on CUSTOM TARGET "..PQR_CustomTarget)
                            if UnitExists(PQR_CustomTarget) then
                                PQR_LastTarget = UnitName(PQR_CustomTarget)
                                CastSpellByID(castingID, PQR_CustomTarget)
                            else
                                PQR_Debug("Custom Target does not exist!")
                            end
                            PQR_CustomTarget = ""

PQR_CustomTarget should be set to whatever you want the target to be in the same ability that casts a custom target spell.

PQR_CustomTarget = "raid3"
return true

---- or if you have a targetting 'ability'
MyCustomTarget = "raid3"

then in the actual ability:
PQR_CustomTarget = MyCustomTarget
return true

After it sends a CastSpellByID it starts again at the top of your rotation, and searches for the next spell that returns true. It shouldn't ever be effected by the PQR_CustomTarget of another ability because it is executed on a single thread (meaning code is never running concurrently to other code) in the following manner:

1) Cycle through rotation from top to bottom, find first ability that returns true then stop.
2) Cast that ability.
3) Go back to step #1

[Tyron1989]

If you make the change it'll work as normal in raids and will just find the tank in the party from the current mob/boss you're targeting. It's untested, but that's how it should work...no gurantees though.

Thats ok im interested to learn to how set all this up so i don't mind being a test rat