[BETA] PQRotation - an automated ability priority queue.

[fmagretto]

Yes having another nightmare of xml files is not the way to go, I think the xml format that we have now is bad enough since you can't edit them nicely in a lua editor. It would be easier to be able to import a lua file that contains functions like Ash said and i mention in other posts. Then if you want add that common ability to your rotation you can by just calling the functions and then if those functions need to be updated you just update the lua file. Any lua code that is run within PQR inherits the lack of protection so just literally reading the lua file in and running it in a one time ability will declare everything. Then we can have a lua file for DS or other raids and either make DS only rotations (because why would you want to check for DS debuffs in other fights) or create generic boss abilities like Boss1 boss2 and have the common functions handle what boss it is and the info about the raid.

Until we get someone way to declare and import these functions in a one time ability or import I gave up writing public rotations. I'm now using a generic lua protection breaker and having PQR call other addon's code; so for fading light i have a PQR ability that actually looks a DBM's fading light timer and see's how much time's left and it can ask DBM what boss i'm on and if i'm in combat. I also can just modify dbm to set a gobal variable when certain events come up. I could copy and paste the dbm code into pqr but with the current functionality it would be a mess. Just a note you can call other addons and libraries from PQR abilities but they will become tainted if you don't have a lua protection breaker. I also found a way to see how many other players are near another player for aoe healing but that needs libmapdata and once again copying that all into pqr abilities would be ugly at best. Lua file imports would allow us to use one of the most important rule of programming...reusable code.

I will release a copy of my ret pally profile in a day or so that uses event handlers to set the procs/debuffs because i find that gives a much faster response time then polling for the buff/proc every time an ability is checked. POLLING is BAD/Expensive, remember that.

[kickmydog]

fmegretto

I have been trying out your retribution paladin rotation. A couple of problems that I have found. If you are not in melee range of the target it will rarely cast Exc when AoW has proc'd, the same goes with judgement if judgement is available but you are not in melee range, along with Hammer of Wrath.

I should note that all other abilities were available to cast at the time, but it didn't

[fmagretto]

fmegretto

I have been trying out your retribution paladin rotation. A couple of problems that I have found. If you are not in melee range of the target it will rarely cast Exc when AoW has proc'd, the same goes with judgement if judgement is available but you are not in melee range, along with Hammer of Wrath.

I should note that all other abilities were available to cast at the time, but it didn't

Where did you pull the copy from? Look in the abilities and see if there's lines for each one that says 'IsSpellInRange' or something similar. The range checks were added in the most recent version of my profile. Also judgement has a fairly long cooldown so you'll only get one cast every few seconds. Also you should be using the Ret Raid rotation from the link that was on my forum [PvE] Retribution Paladin Rotation I just redownloaded it and checked it to what I have and the range checks are in.

Do you have pqrInterface addon up? If so during those times you think it should be casting take a look at what spell it's trying to cast (the one on top) and tell me what it is. But from what it sounds like you have a old version that didn't do range checks because I have no problem with it judgment'ing out of melee range but as I said the cooldown makes it pretty slow and Exc won't cast unless you have AoW which needs melee hits and HoW won't cast unless they are <20% or AW is active

EDIT: The one thing that the released version of my profile is missing is Holy wrath again somehow, when i redownloaded it I just saw it has the spellinrange but not holy wrath in the abilities even though its listed in the rotation. I was going to release a new event driven version today anyway so I won't fix that right now but the Range issues you stated shouldn't exist so make sure you have Dragonfire_PALADIN_Abilities.xml that last modified 12/3/2011 with the rotation file on 12/9/2011

[pepe2c]

Updated some profiles:

Mage (Frost PvP, Fire PvE, Arcane PvE)
Priest (Holy PvE)
Hunter (MM PvE)
Warrior (Protection PvE, Fury PvE)
Rogue (Combat PvE, Subtlely PvP)
Death Knight (Frost PvP)

- Minor fixes

xeron191211PQRProfiles.zip

---------- Post added at 09:56 PM ---------- Previous post was at 09:34 PM ----------

@Xelper: what about add to profile y rotation editor a class called COMMON, the profiles add to common could be run prior to any rotation. Could be usefull to add special code, like the Ultraxion button.

The dk profile works fine with the dummy but it wont attack players. Any tip?

[xtcdragon]

The dk profile works fine with the dummy but it wont attack players. Any tip?

are you level 81 or above? ... i had the same problem till i reached lvl 81 and learned Outbreak, then it all was fine

[averykey]

Yes having another nightmare of xml files is not the way to go, I think the xml format that we have now is bad enough since you can't edit them nicely in a lua editor. It would be easier to be able to import a lua file that contains functions like Ash said and i mention in other posts. Then if you want add that common ability to your rotation you can by just calling the functions and then if those functions need to be updated you just update the lua file. Any lua code that is run within PQR inherits the lack of protection so just literally reading the lua file in and running it in a one time ability will declare everything. Then we can have a lua file for DS or other raids and either make DS only rotations (because why would you want to check for DS debuffs in other fights) or create generic boss abilities like Boss1 boss2 and have the common functions handle what boss it is and the info about the raid.

Until we get someone way to declare and import these functions in a one time ability or import I gave up writing public rotations. I'm now using a generic lua protection breaker and having PQR call other addon's code; so for fading light i have a PQR ability that actually looks a DBM's fading light timer and see's how much time's left and it can ask DBM what boss i'm on and if i'm in combat. I also can just modify dbm to set a gobal variable when certain events come up. I could copy and paste the dbm code into pqr but with the current functionality it would be a mess. Just a note you can call other addons and libraries from PQR abilities but they will become tainted if you don't have a lua protection breaker. I also found a way to see how many other players are near another player for aoe healing but that needs libmapdata and once again copying that all into pqr abilities would be ugly at best. Lua file imports would allow us to use one of the most important rule of programming...reusable code.

I will release a copy of my ret pally profile in a day or so that uses event handlers to set the procs/debuffs because i find that gives a much faster response time then polling for the buff/proc every time an ability is checked. POLLING is BAD/Expensive, remember that.

Thank you for putting all this work in, its really awesome.

Looking forward to the next update.

Edit:

Trinkets and gloves

Gloves

if GetInventoryItemCooldown("player",10) == 0 then UseInventoryItem(10) end

Trinket 1

if GetInventoryItemCooldown("player",13) == 0 then UseInventoryItem(13) end

Trinket 2

if GetInventoryItemCooldown("player",14) == 0 then UseInventoryItem(14) end

Every man for Himself 59752

local debuff = { 45524, 1715, 3408, 59638, 20164, 25809, 31589, 51585, 50040, 50041, 31126, 31124, 122, 44614, 1604, 45524, 50040, 339, 45334, 58179, 61391, 19306, 19185, 35101, 5116, 61394, 2974, 54644, 50245, 50271, 54706, 4167, 33395, 83302, 55080, 11113, 6136, 120, 116, 44614, 31589, 63529, 20170, 87194, 31125, 3409, 26679, 64695, 63685, 8056, 8034, 18118, 18223, 63311, 23694, 1715, 12323, 39965, 55536, 13099, 29703 }


for i,v in ipairs(debuff) do
if UnitDebuffID("player",v) then return true end
end

I just copied your hand of freedom, not sure if it works right but if you want to add it their is the spell id.

Edit 2:
I read on elitist jerks that hammer of wrath is lower on the rotation behind exorcism because of the crit nerf, Could be useful.

Edit 3:
I saw on my priest profile it let me press left control and switch from aoe to single target at any time can this be added to this profile? I was using mentally's priest profile if you just want to copy paste.

Thanks again for making an awesome profile.

[paveley]

i also have issues with your dk profile sheuron, but mine wont attack anything...not dummys/players or mobs =I

[smol]

Where did you pull the copy from? Look in the abilities and see if there's lines for each one that says 'IsSpellInRange' or something similar. The range checks were added in the most recent version of my profile. Also judgement has a fairly long cooldown so you'll only get one cast every few seconds. Also you should be using the Ret Raid rotation from the link that was on my forum [PvE] Retribution Paladin Rotation I just redownloaded it and checked it to what I have and the range checks are in.

Do you have pqrInterface addon up? If so during those times you think it should be casting take a look at what spell it's trying to cast (the one on top) and tell me what it is. But from what it sounds like you have a old version that didn't do range checks because I have no problem with it judgment'ing out of melee range but as I said the cooldown makes it pretty slow and Exc won't cast unless you have AoW which needs melee hits and HoW won't cast unless they are <20% or AW is active

EDIT: The one thing that the released version of my profile is missing is Holy wrath again somehow, when i redownloaded it I just saw it has the spellinrange but not holy wrath in the abilities even though its listed in the rotation. I was going to release a new event driven version today anyway so I won't fix that right now but the Range issues you stated shouldn't exist so make sure you have Dragonfire_PALADIN_Abilities.xml that last modified 12/3/2011 with the rotation file on 12/9/2011

Hi, I've clicked the link you have provided to download your Ret Pally profile and there is no download link on the page? Or am I missing something obvious?

Thanks

[imdasandman]

So with EJ stating that masterfrost spec for frost dk is now the best build is there anyone who can alter a profile or make a new one prioritizing howling blast , frost strike over obliterate to maximize procs from 4 set t13 and the added mastery from reforging thanks in advance if this possible

Page 197, post 2944.

yea the masterprofile I made that has Bubba's framework also works very well as an AoE rotation to on like lets say the bloods on madness of deathwing even if you do not have the 4pcT13....
But in all honesty I have 2pcT13/2pcT12 and I am Diesels Frost DK profile and all I did with his is move HB higher in the priority list above Frost strike etc. I am doing 69k dps in LFR madness juggling between both profiles the Diesel for single target and my masterfrost(AoE) rotation.
I will try my new setup out in 10 mans this coming up lock out but with strictly using my masterfrost in 10 man and a different platform kill order on madness it did 47k dps on WoL parse and ranked me 55th

[sheuron]

i also have issues with your dk profile sheuron, but mine wont attack anything...not dummys/players or mobs =I

Try to remove spell "Will of the Forsaken" from rotation if you arent undead

---------- Post added at 07:17 PM ---------- Previous post was at 06:48 PM ----------

Working on a Discipline Priest PvP profile, but not experienced on pvp healing. Which magic/diseases are worth to dispell, or which not?

[Ralphiuss]

@imdasandman

Can you send me those profiles? I can host them on my SVN.

---------- Post added at 06:36 PM ---------- Previous post was at 06:29 PM ----------

Updated my SVN with Silvera's enhance profile and updated sheuron's classes with his updates.

[fmagretto]

Hi, I've clicked the link you have provided to download your Ret Pally profile and there is no download link on the page? Or am I missing something obvious?

Thanks

It's the latter....Its at the bottom of the OP where it says "Download Here (Updated 12/9/2011)" click the words "Download Here" They are in green type. I'll make it easier and just copy and past the address here MEGAUPLOAD - The leading online storage and file delivery service

[imdasandman]

@imdasandman

Can you send me those profiles? I can host them on my SVN.

---------- Post added at 06:36 PM ---------- Previous post was at 06:29 PM ----------

Updated my SVN with Silvera's enhance profile and updated sheuron's classes with his updates.

done check your pms... I also cleared my inbox out sorry it was full

[Meatglue]

It's the latter....Its at the bottom of the OP where it says "Download Here (Updated 12/9/2011)" click the words "Download Here" They are in green type. I'll make it easier and just copy and past the address here MEGAUPLOAD - The leading online storage and file delivery service

The problem is you have to register an account on the site to see the link. I figured that out last night myself. lol

[fmagretto]

Thank you for putting all this work in, its really awesome.

Edit 3:
I saw on my priest profile it let me press left control and switch from aoe to single target at any time can this be added to this profile? I was using mentally's priest profile if you just want to copy paste.

Thanks again for making an awesome profile.

If you are using Ret Raid rotation from that link there is an AOE switch and it is left control....I would advise rereading my original post [PvE] Retribution Paladin Rotation

Modifiers:

Press Left Ctrl: Switches between AOE (Divine Storm) and Single Target (Crusader Strike). No need to switch rotations. When changed it will display a message in chat window.
Hold Left Shift: Will Pause rotation and stop auto-attack. Useful when raid leader calls out stop dps and you don't want to switch targets.
Press Left Alt: Will cast Hammer of Justice (Stun) on Mouse Over. Useful for quick stuns (ie Sons of Flame during Rag fight)

I did not include every man for himself since it's a racial and i didn't want to screw everyone up. I have more complete code for it since HoF only does movement impairing and Every-Man can do that and anything that makes you lose control of your toon. Don't worry I have every man for him included in my next version with PQ_HasEveryManSpell = IsSpellKnown(59752) so that it won't bother non-human players. I'll consider moving HoW below exorcism if EJ says it's moved down, i doubt it'll have much impact since neither spell is cast much so the probability of them both being active is a little slim but i'll move it.

Just to give everyone a look at how i'm handling buffs/debuffs in my event version i'll paste some of it here. The goal was to make it as reusable as possible and the debuffs categories can be extended and the 'check' variable tell the code if that buff/debuff/list should be checked against when a new buff/debuff is added so if you read carefully you'll notice that if the player does not have Every-Man-For-Himself then PQ_HasEveryManSpell (everyone has to remember these are global and other addons can see it so use unique names) becomes false and then all the debuff categories except MovementImpairing is turned off since we have no spell to break it. Also remember this is a work in progress....

--Buffs/Procs--
PQ_DivinePurpose = 90174
PQ_AvengingWrath = 31884
PQ_ArtOfWar 	 = 59578
PQ_SealOfTruth	 = 31801
PQ_SealOfRight	 = 20154
PQ_Inquisition	 = 90174

PQ_Buffs = { 
			[PQ_DivinePurpose] = {check = true, hasBuff = false, endTime = nil},
			[PQ_AvengingWrath] = {check = true, hasBuff = false, endTime = nil},
			[PQ_ArtOfWar] 	   = {check = true, hasBuff = false, endTime = nil},
			[PQ_SealOfTruth]   = {check = true, hasBuff = false, endTime = nil},
			[PQ_SealOfRight]   = {check = true, hasBuff = false, endTime = nil},
			[PQ_Inquisition]   = {check = true, hasBuff = false, endTime = nil}
		   }

	function PallyBuffHandler(spellID, hasBuffNow)
--	{
		if (PQ_Buffs[spellID].check) then
			PQ_Buffs[spellID] = hasBuffNow
			
			if (hasBuffNow) then
				PQ_Buffs[spellID].endTime = select(7, UnitBuffID("player", spellID))
			end
				
		end
		
	end
--	}

-- To check if I have divine purpose you would write If (PQ_Buffs[PQ_DivinePurpose].hasBuff) return true end
-- Which just involves checking a local boolean instead of a wow api call to check a list of buffs....

--Debuffs--
	--booleans
	PQ_HasMovementImpair = false
	--59752--[[Every Man for Himself]]
	PQ_HasEveryManSpell	 = IsSpellKnown(59752)
	
	PQ_DebuffList.BreakOnDamage = {
		19503--[[Scatter Shot]],
		1499--[[Freezing Trap]],
		6358--[[Seduction]],
		9484--[[Shackle Undead]],
		6770--[[Sap]],
		118--[[Polymorph]],
		51514--[[Hex]],
		2094--[[Blind]],
		2637--[[Hibernate]],
		76780--[[Bind Elemental]]
	}
	PQ_DebuffList.Fear = {
		5782--[[Fear]],
		5484--[[Howl of Terror]],
		8122--[[Psychic Scream]],
		1513--[[Scare Beast]],
		10326--[[Turn Evil]],
		5246--[[Intimidating Shout]]
	}
	PQ_DebuffList.Root = {
		339--[[Entangling Roots]],
		122--[[Frost Nova]],
		45524--[[Chains of Ice]],
		16979--[[Feral Charge - Bear]]
	}
	PQ_DebuffList.Raid = {}
	PQ_DebuffList.MovementImpairing = {
		5116--[[Concussive Shot]],
		2974--[[Wing Clip]],
		13809--[[Ice Trap]],
		116--[[Frostbolt]],
		120--[[Cone of Cold]],
		11113--[[Blast Wave]],
		31589--[[Slow]],
		15407--[[Mind Flay]],
		3408--[[Crippling Poison]],
		26679--[[Deadly Throw]],
		8056--[[Frost Shock]],
		2484--[[Earthbind Totem]],
		18223--[[Curse of Exhaustion]],
		1715--[[Hamstring]],
		12323--[[Piercing Howl]]
	}
		--Only check for Fear/Root/BreakOnDamage only if player has Every Mand for Himself since Hand of Freedom only breaks Movement Impairing effects--
	PQ_Debuffs = {
					['Fear'] 			  = {check = PQ_HasEveryManSpell, debuffList = PQ_DebuffList.Fear , spellid = nil, hasDebuff = false, endTime = nil},
					['Root']			  = {check = PQ_HasEveryManSpell, debuffList = PQ_DebuffList.Root , spellid = nil, hasDebuff = false, endTime = nil},
					['BreakOnDamage']	  = {check = PQ_HasEveryManSpell, debuffList = PQ_DebuffList.BreakOnDamage , spellid = nil, hasDebuff = false, endTime = nil},
					['MovementImpairing'] = {check = true, debuffList = PQ_DebuffList.MovementImpairing , spellid = nil, hasDebuff = false, endTime = nil},
					['Raid']			  = {check = false, debuffList = PQ_DebuffList.Raid , spellid = nil, hasDebuff = false, endTime = nil}
				 }

	--So in Hand of Freedom ability just check `if (PQ_Debuffs['MovementImpairing'].hasDebuff == true) then return true end`

	function PallyDebuffHandler(spellID, hasDebuffNow)
--	{
		for type, debuffInfo in pairs(PQ_Debuffs) do
--		{	
			if (debuffInfo.check) then
--			{				
				for k, debuff in pairs(debuffInfo.debuffList) do
--				{					
					if (debuff == spellID) then
						PQ_Debuffs[type].hasDebuff = hasDebuffNow
						
						if (hasDebuffNow) then --Has debuff spellID of type
							PQ_Debuffs[type].spellid = spellID
							PQ_Debuffs[type].endTime = select(7, UnitDebuffID("player", spellID))
						else --Debuff being removed
							PQ_Debuffs[type].spellid = nil
							PQ_Debuffs[type].endTime = nil
						end --end If debuff is being applied(true) or removed(false)
						
						return --return so we only match once and don't search lists we don't need to
					end --end check if spellid matched in list
						
				end--End for loop that looped through the spellid list of a certain type
--				}			
			end--End If that checked to make sure we want to catch debuffs of this type
--			}			
		end--End For Loop that looped through debuff types
--		}	
	end--End function PallyDebuffHandler
--  }

So with that code in place then I can write:

For Every Man for Himself check

 if (PQ_Debuffs['Fear'].hasDebuff or PQ_Debuffs['Root'].hasDebuff or PQ_Debuffs['BreakOnDamage'].hasDebuff or PQ_Debuffs['MovementImpairing'].hasDebuff) then
 return true 
end