[BETA] PQRotation - an automated ability priority queue.

[sheuron]

PQR (v2.0.7) Released
Run PQRUpdater.exe from your current PQR directory to download. If you do not have PQRUpdater.exe download it here.

-Added a "Skip Unknown" option for individual abilities. This value will default to true. If the spell is unknown it will be skipped. Requires a spell ID. This should allow more profiles to also be used as leveling profiles.
-Fixed (or should have) icon transparency issue on Windows XP.

Just download 2.0.7 andi dont see the "Skip Unknown" option anywhere.

Btw, got another idea to make ability editor more frienly to new profile writers

Imagine you write a MAGE profile, when you start to write ability name "Frost" then editor show you possible spells (Frost Armor, Frost Nova, Frostbolt, etc...), when you choose one the spellid field is autofilled.

To make this easier the database with spellnames and spellid could be on a textfile, so comunity can fill it.

[derfred]

Originally Posted by crystal_tech ([BETA] PQRotation - an automated ability priority queue.)Code:

local bUS = UnitBuffID("player", 53365)local bPoF = UnitBuffID("player",51271)local _,_,_,count = UnitBuffID("player",107966)if (count and count == 10) and bUS and bPoF then -- I believe count returns nil when there is no buff currently right? so to avoid nil errors we should make sure that it exists first CastSpellByID(13165, "player") -- i make it a habit of ALWAYS having a target, sometimes not having one just errors out (dunno why, it seems random right now)end

try that count was missing a '= ' and your castspellid was missing ')'. also in your case using castspellbyid you shouldn't need to return true so you can drop that and you can set the spellid to 0.

Nope still doesnt work, same problem that he casts raise dead before waiting for 10 stacks

This is what ive tried now

local bUS = UnitBuffID("player", 53365)
local bPoF = UnitBuffID("player",51271)
local _,_,_,count = UnitBuffID("player",107966)
if count and count == 10 and bUS ~= nil and bPoF ~= nil then
return true
end
end
end

but still doesnt work

[cahonez89]

Is there a Shadow Priest PvP roation around?

[bu_ba_911]

Nope still doesnt work, same problem that he casts raise dead before waiting for 10 stacks

This is what ive tried now

local bUS = UnitBuffID("player", 53365)
local bPoF = UnitBuffID("player",51271)
local _,_,_,count = UnitBuffID("player",107966)
if count and count == 10 and bUS ~= nil and bPoF ~= nil then
return true
end
end
end

but still doesnt work

which version of the trinket do u have?

local EoU = { 109748, 107966, 109750 } -- LFR, Normal, Heroic
local bUS = UnitBuffID("player", 53365)
local bPoF = UnitBuffID("player",51271)
local TrinketType = nil
local hasTrinket = false
for i=13, 14 do
  -- We're checking both possible Trinket Slots for the trinket
  local ItemSlotID = GetInventoryItemID("player", i)
  -- We're going to find out which trinket you have (LFR, Normal, Heroic) and save that number to run our checks on)
  for y=1, 3 do
    if ItemSlotID == EoU[y] then
      hasTrinket = true
      TrinketType = y
    end
  end
end

--We're checking that hasTrinket is no longer false, and TrinketType is not nil
if hasTrinket and TrinketType then
  -- We're checking if we currently have Titanic Strength buff on us
  if UnitBuffID("player", EoU[TrinketType]) then
    -- If we have the Buff, now we're checking if the count number is 10 or higher (I always do greater than or equal to for bugs sakes)
    if select(4, UnitBuffID("player", EoU[TrinketType])) >= 10 then
      -- Now we're checking if Unholy Strength and Pillar of Frost are both up
      if bUS and bPoF then
        -- If everything works out, it should cast properly
        return true
      end
    end
  end
end

Not even remotely tested...... but maybe that would work?

*edit* as you can see i'm home now, so willing to write out some more experimental code for u to try XD

If this doesn't cause an error, but still casts before u reach your 10 count and buffs on...... somewhere in your profile there is something else casting it.....

[Xelper]

Just download 2.0.7 andi dont see the "Skip Unknown" option anywhere.

Btw, got another idea to make ability editor more frienly to new profile writers

Imagine you write a MAGE profile, when you start to write ability name "Frost" then editor show you possible spells (Frost Armor, Frost Nova, Frostbolt, etc...), when you choose one the spellid field is autofilled.

To make this easier the database with spellnames and spellid could be on a textfile, so comunity can fill it.

Thats weird... Think it has something to do with the program I use to merge the DLL files into a single EXE. I'll reupload shortly once I have it fixed.

EDIT: Okay fixed, rerun PQRUpdater.exe for the fixed version.

[farnumdizzle]

Programming in Lua - this reference really helped me understand a lot. I read through it in less than a day, so it's not very lengthy, and the sections at the end related to the C language are not applicable. The tables and objects chapters are the most interesting and relevant, IMO, but I'd still suggest reading it through.

Edit: @Xelper, please see my previous post regarding the PQR updating over-writing hotkeys and profiles.

Hey, thanks a lot. I'll take a look at it tomorrow after class. If anyone else has anything it would be much appreciated.

[deadpanstiffy]

Nope still doesnt work, same problem that he casts raise dead before waiting for 10 stacks

This is what ive tried now

local bUS = UnitBuffID("player", 53365)
local bPoF = UnitBuffID("player",51271)
local _,_,_,count = UnitBuffID("player",107966)
if count and count == 10 and bUS ~= nil and bPoF ~= nil then
return true
end
end
end

but still doesnt work

You only have 1 if statement, you only need 1 end.

[bu_ba_911]

You only have 1 if statement, you only need 1 end.

lol yea i honestly didn't even notice that..... i just decided to rewrite a smarter version of what he wants and stop dealing with the old

[Sharge]

Hi Bubba , I am getting an error With your new profile:

Message: [string " -- Only takes effect when we're 85 ..."]:97: attempt to index global 'PQ_Spell' (a nil value)
Time: 03/22/12 22:11:38
Count: 809
Stack: [C]: ?
[string " -- Only takes effect when we're 85 ..."]:97: in function `?'
[string "..."]:566: in function `PQR_NextAbility'
[string "..."]:365: in function `PQR_ExecuteRotation'
[string "..."]:137: in function <[string "..."]:72>

Hope you can help!

[bu_ba_911]

Hi Bubba , I am getting an error With your new profile:

Message: [string " -- Only takes effect when we're 85 ..."]:97: attempt to index global 'PQ_Spell' (a nil value)
Time: 03/22/12 22:11:38
Count: 809
Stack: [C]: ?
[string " -- Only takes effect when we're 85 ..."]:97: in function `?'
[string "..."]:566: in function `PQR_NextAbility'
[string "..."]:365: in function `PQR_ExecuteRotation'
[string "..."]:137: in function <[string "..."]:72>

Hope you can help!

do you have the data file in the folder?

[Sharge]

Thanks you bubba! solved , +rep again^^

[sheuron]

I think last week saw a post asking about resto druid rotation with working Swiftmend. Found the same problem today working on my rotation. This is the code:

Ability: Swiftmend
Spell ID: 0

if ( UnitBuffID(PQR_CustomTarget,774) or UnitBuffID(PQR_CustomTarget,8936) ) 
and IsSpellKnown(18562) 
and select(2,GetSpellCooldown(18562)) < 5
then CastSpellByID(18562,PQR_CustomTarget) end

Why PQR dont work with Swiftmend just using the spell id?
PQR used api IsUsableSpell() to check if can launch the spell, but Swiftmend only show usable when we have target a player with Rejuvenation or Regrowth spells, thats the reason we need to use this code.

[Xelper]

incase anyone is wondering exactly how I determine if a spell is considered available:

    function PQR_SpellAvailable(spellID)
        local gcdSpell = PQR_GCDSpellID()
        local gcdStartTime, gcdDuration = GetSpellCooldown(gcdSpell)
        local spellStartTime, spellDuration = GetSpellCooldown(spellID)
        local spellUsable = IsUsableSpell(spellID)
        local spellAvailable = false


        if spellUsable then
            if spellStartTime ~= nil and gcdStartTime ~= nil then
                local spellTimeLeft = spellStartTime + spellDuration - GetTime()
                local gcdTimeLeft = gcdStartTime + gcdDuration - GetTime()
                if gcdTimeLeft <= 0 then
                    --Our GCD spell is not on CD.
                    if spellTimeLeft <= PQR_SpellAvailableTime then
                        --spell will be off CD within 50ms.
                        spellAvailable = true 
                    end
                else
                    --Out GCD spell is on CD.
                    if spellTimeLeft <= gcdTimeLeft + PQR_SpellAvailableTime then
                        --spell time left is less than GCD time left + 50ms.
                        spellAvailable = true
                    end
                end
            end
        end


        return spellAvailable
    end

If anyone has any thoughts on improving it I wouldn't mind hearing them, just keep in mind it has to keep current functionality intact.

[bu_ba_911]

incase anyone is wondering exactly how I determine if a spell is considered available:

    function PQR_SpellAvailable(spellID)
        local gcdSpell = PQR_GCDSpellID()
        local gcdStartTime, gcdDuration = GetSpellCooldown(gcdSpell)
        local spellStartTime, spellDuration = GetSpellCooldown(spellID)
        local spellUsable = IsUsableSpell(spellID)
        local spellAvailable = false


        if spellUsable then
            if spellStartTime ~= nil and gcdStartTime ~= nil then
                local spellTimeLeft = spellStartTime + spellDuration - GetTime()
                local gcdTimeLeft = gcdStartTime + gcdDuration - GetTime()
                if gcdTimeLeft <= 0 then
                    --Our GCD spell is not on CD.
                    if spellTimeLeft <= PQR_SpellAvailableTime then
                        --spell will be off CD within 50ms.
                        spellAvailable = true 
                    end
                else
                    --Out GCD spell is on CD.
                    if spellTimeLeft <= gcdTimeLeft + PQR_SpellAvailableTime then
                        --spell time left is less than GCD time left + 50ms.
                        spellAvailable = true
                    end
                end
            end
        end


        return spellAvailable
    end

If anyone has any thoughts on improving it I wouldn't mind hearing them, just keep in mind it has to keep current functionality intact.

tossed u a fun lil PM mate i personally got all googly eyed at it when i saw that for the first time haha.... I was impressed to say the least

[sheuron]

I was wondering on a way to improve de UnitBuffID/UnitDebuffID function.

This is what we doing now

      local buff = { 1126, 20217, 90363 } 
      for i=1, #buff do if UnitBuffID("target",buff[i]) then return true end end

This example launch UnitBuffID api 3 times to check buff we need.

      if UnitBuffID("target",1126|20217|90363) then return true end

This syntax or something similar could be used to check all our buff with only 1 call.