[BETA] PQRotation - an automated ability priority queue.

[bu_ba_911]

you had it as CastSpellByName(Steady Shot, "target") instead of CastSpellByName("Steady Shot", "target")

*side note*
i recommend everyone using my Beta 4.0 to do a quick update.... forgot a couple things from between last not and right now.... even a few of the updates last hour were missing things haha

[kickmydog]

you had it as CastSpellByName(Steady Shot, "target") instead of CastSpellByName("Steady Shot", "target")

*side note*
i recommend everyone using my Beta 4.0 to do a quick update.... forgot a couple things from between last not and right now.... even a few of the updates last hour were missing things haha

Yep, that was it, thanks.

Ok that has fixed the PVP rotations for the moment.

http://www.mediafire.com/?73jvi1heimma734

[Cahonez]

Message: [string " -- Code provided by Crystal_Tech ..."]:51: attempt to compare number with nil
Time: 03/20/12 16:12:07
Count: 231
Stack: [string " -- Code provided by Crystal_Tech ..."]:51: in function `?'
[string "..."]:583: in function `PQR_NextAbility'
[string "..."]:400: in function `PQR_ExecuteRotation'
[string "..."]:122: in function <[string "..."]:60>

Locals: (*temporary) = nil
(*temporary) = 936153
(*temporary) = "target"
(*temporary) = "attempt to compare number with nil"

having this spam me whilst using kicks hunter profiles.

help

[Cahonez]

Message: [string " if TTD_loaded == nil and UnitAffectingComb..."]:49: attempt to compare number with nil
Time: 03/20/12 16:30:41
Count: 722
Stack: [string " if TTD_loaded == nil and UnitAffectingComb..."]:49: in function `?'
[string "..."]:583: in function `PQR_NextAbility'
[string "..."]:400: in function `PQR_ExecuteRotation'
[string "..."]:122: in function <[string "..."]:60>

Locals: (*temporary) = nil
(*temporary) = 0
(*temporary) = "target"
(*temporary) = "attempt to compare number with nil"

this 1 also.

[Kaolla]

Anyone good with Frost DK PvP profile editing?

I've run an edited Master Frost profile at 2300, but it's not wonderful. What do you need help with?

Also, bow to our new purple god!

[js1974]

I've been working on this issue for a while and hit the forums a few times even pm'd people all to no resolution. I have what I feel like should be a fairly easy issue to resolve but no one can seem to answer it so I'll try again.


Is there a way to have an ability hit a focus if you have one and if you do not have one have it hit your current target? I can't imagine that this can't be done but so far the only thing I have figured out is if I want the focus attack I have to have 2 different rotations 1 with focus attack and one with target which is a bit of a pain but doable.


Anyone have any ideas at all?

[Kaolla]

I'm not sure what you're trying to do, but if I understand you correctly, couldn't you do something simple, like:

If UnitExists("focus") == 1 then
CastSpellByID(11111, "focus")
return true
end

If UnitExists("focus") == nil then
CastSpellByID(11111, "target")
return true
end

Or something like that. Without knowing what conditions you're looking for, I can't write the actual ability, but UnitExists should work

[Gabbz]

@Googlebee
Tested your feral cat and its decent but it is not optimal. Have a look at The Fluid Druid - View topic - Leafkiller's 4.3 Feral Ovale Script to get some of the finer logic into your rotation.

Some quick things are that i noted differes from mine is
* Rake should be aligned to TF
* Energy Pooling could be implemented although i don't know how much it will give you
* You are to generous using FB

The difference between your and mine feral, for my gear and reforging mind you, is about 1500-2000 dps.
Have not tested the bear one yet, will do that later and give feedback.

[Deva]

I have a question regarding how to properly handle an event-driven... umm, event. :P

Specifically, what I want to do is (of course after checking if constants are set), initially set a constant for the player's spec using GetPrimaryTalentTree(). Then, I would like to check PLAYER_TALENT_UPDATE (I assume this is the correct event) to see if talent specs have been changed, and if so, update the spec constant with GetPrimaryTalentTree().

Using Avery's event loader as a base, here's what I've come up with initially (theoretically you should be able to set up an empty profile/rotation with the ability and it should work if you switch talent specs back and forth):

---------------------------START--------------------------

if not Set_Talents then
	if FirstSpec == nil then
		FirstSpec = GetPrimaryTalentTree()
	end
	Set_Talents = true
end

if not PQ_EventHandlerLoaded then

local frame, events = CreateFrame("Frame"), {};

function events:PLAYER_TALENT_UPDATE(...)

	PQ_TalentsChanged = true

end

frame:SetScript("OnEvent", function(self, event, ...) events[event](self, ...); end);

for k, v in pairs(events) do
 frame:RegisterEvent(k); -- Register all events for which handlers have been defined
end

PQ_EventHandlerLoaded = true

end

if PQ_TalentsChanged then
	local CurrentSpec = GetPrimaryTalentTree()
	if FirstSpec ~= CurrentSpec then
	PQR_DebugP("FirstSpec is not equal to CurrentSpec: ("..tostring(FirstSpec)..", "..tostring(CurrentSpec)..")")
	end
end

...and... it works, basically*. Obviously debug messages, as well as the First/Current compare, were just put there for testing. All I'd like to know is if there's a more efficient way to handle this, and more importantly, if I'm doing it correctly (preferably it should only update when you change specs?), and what optimizations/changes need to be made if I want to make this "talent checker" its own .lua file? Should/could it be broken down into further functions, or it is best as-is?

* Note: This actually may NOT work for you, I trimmed some stuff out before I posted here, so feedback is appreciated.

[MastaRage]

Message: [string " -- Code provided by Crystal_Tech ..."]:51: attempt to compare number with nil
Time: 03/20/12 16:12:07
Count: 231
Stack: [string " -- Code provided by Crystal_Tech ..."]:51: in function `?'
[string "..."]:583: in function `PQR_NextAbility'
[string "..."]:400: in function `PQR_ExecuteRotation'
[string "..."]:122: in function <[string "..."]:60>

Locals: (*temporary) = nil
(*temporary) = 936153
(*temporary) = "target"
(*temporary) = "attempt to compare number with nil"

having this spam me whilst using kicks hunter profiles.

help

I get the same error at the start of the rotation when you initially start PQR and attack something, but you can exit it and it will still do the rotation smoothly. Tested in Survival same awesome dps on a dummy. I PM'd Kickmydog about it too.

[googlebee]

@Googlebee
Tested your feral cat and its decent but it is not optimal. Have a look at The Fluid Druid - View topic - Leafkiller's 4.3 Feral Ovale Script to get some of the finer logic into your rotation.

Some quick things are that i noted differes from mine is
* Rake should be aligned to TF
* Energy Pooling could be implemented although i don't know how much it will give you
* You are to generous using FB

The difference between your and mine feral, for my gear and reforging mind you, is about 1500-2000 dps.
Have not tested the bear one yet, will do that later and give feedback.

Ok - Which one is *Yours*? The only other 2 Ive seen are Firepong's and AdamZZ's...Id like to test yours as well....the way we are reforged (Haste or mastery priority) will have a big difference in how the profiles perform too.

I tinkered with mine based on my forge and gear. I'll play around with your ideas tho and see if it helps. Thanks!

[Gabbz]

I have not uploaded mine due to multiple reasons, mainly is that its not "clean" and alot of stuff that are based on my play style

My TF code

local sRake, _, _, _, _, _, rakeEndTime = UnitDebuffID("target", 1822, "PLAYER")
local mTigersFury, _, _, _, _, _, mTigersFuryEndTime = UnitBuffID("player",5217)
local mTigersFurystart, mTigersFuryDuration = GetSpellCooldown(5217)
local mTigersFurycooldown = (mTigersFurystart + mTigersFuryDuration - GetTime())

if mTigersFurycooldown < 3 and mTigersFurycooldown > 0 then 
	return false
end

if sRake then
	local finishTime = rakeEndTime - GetTime()
	if mTigersFury then
		if finishTime < 9 then
			return true
		end
	end
		
	if finishTime < 2.5 then
		return true
	end
else
	return true
end

And here is logic to cancel the Primal Buff

l

local sPrimalMadness = UnitBuffID("player", 80317)

if sPrimalMadness then
	if playerEnergy < 15 then
		RunMacroText("/cancelaura "..sPrimalMadness)
	end
end

[deadpanstiffy]

And here is logic to cancel the Primal Buff

l

local sPrimalMadness = UnitBuffID("player", 80317)

if sPrimalMadness then
	if playerEnergy < 15 then
		RunMacroText("/cancelaura "..sPrimalMadness)
	end
end

Is there a purpose of running macro text to cancel the buff instead of CancelUnitBuff ?

[cukiemunster]

And here is logic to cancel the Primal Buff

l

local sPrimalMadness = UnitBuffID("player", 80317)

if sPrimalMadness then
	if playerEnergy < 15 then
		RunMacroText("/cancelaura "..sPrimalMadness)
	end
end

Am I missing something? Why would you want to cancel Primal Madness?

[Xelper]

Am I missing something? Why would you want to cancel Primal Madness?

The Primal Madness talent causes your energy to increase by 20. If you are at 100/100 energy it will bring you to 120/120. When the buff fades you lose 20.

Now, if you have 20/120 energy as it fades, it will bring you down to 0/100. If you cancel the buff before it fades, and under 20 energy (or in this case 15) the most energy you can possibly lose is 15. Preferrably you would want to cancel it under 5-10 energy so the max energy lost is 5-10 instead of 20.

Is there a purpose of running macro text to cancel the buff instead of CancelUnitBuff ?

No, you should be able to just do CancelUnitBuff("player", sPrimalMadness). The code looks like my feral code I wrote a long ways back, and at the time I used RunMacroText because I didn't know about the CancelUnitBuff function.