[BETA] PQRotation - an automated ability priority queue.

[noah11213]

Hi. I'm looking for a Feral Cal PvE profile. I've searched till I'm blue in the face...any help?
PS Great work guys love this program.

[couky]

@Mentally
I tried the profile that Bubba host for you and the bug of the shadow pve lvling profile is still there.

[Valma]

2Valma
Not work. Only spam Bane of Havoc. On dummy and raid.
Rotation in one ability - bad idea, IMHO

Last one doesn't works?

And its NOT in ability,its in function so I can call this function when I want to,plus in this case we will ALWAYS got top priority casted(huehue to return).

About functions - this made so I could call PQ_Destro if we are in destro spec,PQ_Demo if in demo spec etc.

EDIT: Ye,I found a problem,uploading fix now.OK,uploaded,redownload it.Forgot to set new checks after swaping priority of target and focus.THX for feedback.

[andryshka]

Last one doesn't works?

And its NOT in ability,its in function so I can call this function when I want to,plus in this case we will ALWAYS got top priority casted(huehue to return).

About functions - this made so I could call PQ_Destro if we are in destro spec,PQ_Demo if in demo spec etc.

Found error. It's in PQ_PriorityList.

PQ_PriorityList[1] = PQ_mouseover
PQ_PriorityList[2] = PQ_focus
PQ_PriorityList[3] = PQ_target

But PQ_UnitSkillList.second is for PQ_target. And PQ_UnitSkillList.third is for PQ_focus.
Replace

PQ_PriorityList[1] = PQ_mouseover
PQ_PriorityList[2] = PQ_target
PQ_PriorityList[3] = PQ_focus

And it's work


And for example. If I want remove Doomguard from rotation, I need edit ability "Rotations" and reload ui with PQR.

[romb0t]

@valma & andryshka
Well, I have seen that you have applied the fix proposed by Andryshka but still nothing is cast on the raid dummy... In the debug window, I can see messages when I mouseover unit but that's it...

Will try to add some debug messages in the --Skill Handler -- to see where I am blocked at.

[andryshka]

@valma & andryshka
Well, I have seen that you have applied the fix proposed by Andryshka but still nothing is cast on the raid dummy... In the debug window, I can see messages when I mouseover unit but that's it...

Will try to add some debug messages in the --Skill Handler -- to see where I am blocked at.

Replaces at 346 and 781 lines

[andryshka]

2Valma
and you forgot add Soulburn to PQ_UnitSkillList

[romb0t]

@valma & andryshka
It is already like:

	--List of priorities
	PQ_PriorityList = {}
	
	PQ_PriorityList[1] = PQ_mouseover
	PQ_PriorityList[2] = PQ_target
	PQ_PriorityList[3] = PQ_focus
	PQ_PriorityList[4] = nil
	PQ_PriorityList[5] = nil
	PQ_PriorityList[6] = nil

and

	function PQ_RotationSwitch(rotationmode)
		PQ_RotationMode = rotationmode
		if rotationmode == PQ_RotationList[1] then
			PQ_PriorityList[1] = PQ_mouseover
			PQ_PriorityList[2] = PQ_target
			PQ_PriorityList[3] = PQ_focus
			PQ_PriorityList[4] = nil
			PQ_PriorityList[5] = nil
			PQ_PriorityList[6] = nil

[romb0t]

@valma & andryshka
I don't think that SoulBurn should be in the UnitSkillList as it is handled differently, from the code -- Skill Handler -- as soon as it is available, we will use it.

[andryshka]

@valma & andryshka
I don't think that SoulBurn should be in the UnitSkillList as it is handled differently, from the code -- Skill Handler -- as soon as it is available, we will use it.

Wrong version
Download from ValmaWarlock 02-16-2012.rar - valma-pqr-profiles - NEED TESTERS|Reworking rotation to include all 3 specs - Advanced PQR profiles - Google Project Hosting. Not from svn

[romb0t]

@andryshka
Ah yes much better... I am so used to get the latest version from svn... Thanks.

[Valma]

Ye forgot to check in svn And NO,the right rotation in regards of in every iteration of FOR we do the full check for all abilities is:

PQ_PriorityList[1] = PQ_mouseover
PQ_PriorityList[2] = PQ_focus
PQ_PriorityList[3] = PQ_target

So we will fullcheck mouseover,then fullcheck focus and then fullcheck target while we will not get return.

So actually bug was not there but in skilllists for second and third targets.Fixed this already as I stated.Need some feedback for the version I uploaded about a hour ago.Does it works?

[Valma]

2Valma
and you forgot add Soulburn to PQ_UnitSkillList

SoulBurn,DemonSoul and BloodFury don't have targetlogic,so no need to include them.

[ziggar]

Yeah can you please upload your rogue profile please [Blinded] ?

Cheers

[romb0t]

@Valma, andryshka
There is a bug after sometime (in fact if you move at the time you try to launch incinerate (so the spell is not successfull), the incinerate is no more launched.

I think that the issue is in:

	function events:UNIT_SPELLCAST_START(...)
		if PQ_Debug then
			DebugFrame.messageFrame:AddMessage('CASTING spell' .. GetSpellLink(select(5, ...)))
		end
		if (select(1, ...) == PQ_player) then
			if select(5, ...) == PQ_Incinerate then 
				PQ_Skills[select(5, ...)].nexttest = select(6, UnitCastingInfo(PQ_player)) * 1000 + PQ_Skills[select(5, ...)].delay - 0.2
			end
		end
	end

I think that we should divide by 1000 instead of multiplying as:
endTime - Time at which the cast will finish (in milliseconds; can be compared to GetTime() * 1000) (number)