[BETA] PQRotation - an automated ability priority queue.

[kickmydog]

By summoning me he means annoying the hell out of me ingame while I am busy doing other things!

Add an ability with a modifier.

If Scatter Shot is off CD -> Cast Scatter Shot.
If Trap Launcher Buff is not up and trap is off CD -> Cast Trap Launcher
If Trap Launch Buff is up and Trap is Off CD -> Cast Freezing Trap

Unfortunately scatter shot is on the GCD.

[Xelper]

Name: Scatter Trap
Spell ID: 0
Actions: /stopattack
Code:

local targetTrapped = UnitDebuffID("target", 1499)
local _, FreezingTrapCD = GetSpellCooldown(1499)
if targetTrapped then
	return true
end


if FreezingTrapTimeout ~= nil and FreezingTrapTimeout > GetTime() then
	local targetName = UnitName("target")
	if targetName == FreezingTrapTarget and FreezingTrapTarget ~= nil then
		if FreezingTrapCD > 3 then
			return true
		end
	end
else
	FreezingTrapTimeout = nil
	FreezingTrapTarget = nil
end


if IsLeftControlKeyDown() and GetCurrentKeyBoardFocus() == nil then
	local ScatterShot = GetSpellInfo(19503)
	local TrapLauncher = GetSpellInfo(77769)
	local FreezingTrap = GetSpellInfo(1499)
	local ScatterShotCD, ScatterDuration = GetSpellCooldown(19503)
	ScatterShotCD = ScatterShotCD - GetTime() + ScatterDuration
	local TrapLauncherBuff = UnitBuffID("player", 77769)
	local _, FreezingTrapCD = GetSpellCooldown(1499)
	
	if ScatterShotCD < 3 and FreezingTrapCD < 3 then
		if TrapLauncherBuff == nil then
			CastSpellByName(TrapLauncher)
		end
		CastSpellByName(ScatterShot, "target")
		return true
	end


	if ScatterShotCD > 20 and FreezingTrapCD < 3 and TrapLauncherBuff == nil then
		CastSpellByName(TrapLauncher)
		return true
	end


	if ScatterShotCD > 20 and FreezingTrapCD < 3 and TrapLauncherBuff then
		RunMacroText("/cast "..FreezingTrap)
		if FreezingTrapTimeout == nil or FreezingTrapTarget == nil then
			FreezingTrapTarget = UnitName("target")
		end
		FreezingTrapTimeout = GetTime() + 3
		CameraOrSelectOrMoveStart()
		CameraOrSelectOrMoveStop()
		return true
	end
end

[Meatglue]

EDIT: hold on, improving it.

TY, it's the least you can do for the original beta tester for pqr. :P

[Xelper]

TY, it's the least you can do for the original beta tester for pqr. :P

That code does about everything you would ever need to do for any ability, now never ask me again! :)

[kickmydog]

Name: Scatter Trap
Spell ID: 0
Actions: /stopattack
Code:

local targetTrapped = UnitDebuffID("target", 1499)
local _, FreezingTrapCD = GetSpellCooldown(1499)
if targetTrapped then
	return true
end


if FreezingTrapTimeout ~= nil and FreezingTrapTimeout > GetTime() then
	local targetName = UnitName("target")
	if targetName == FreezingTrapTarget and FreezingTrapTarget ~= nil then
		if FreezingTrapCD > 3 then
			return true
		end
	end
else
	FreezingTrapTimeout = nil
	FreezingTrapTarget = nil
end


if IsLeftControlKeyDown() and GetCurrentKeyBoardFocus() == nil then
	local ScatterShot = GetSpellInfo(19503)
	local TrapLauncher = GetSpellInfo(77769)
	local FreezingTrap = GetSpellInfo(1499)
	local ScatterShotCD, ScatterDuration = GetSpellCooldown(19503)
	ScatterShotCD = ScatterShotCD - GetTime() + ScatterDuration
	local TrapLauncherBuff = UnitBuffID("player", 77769)
	local _, FreezingTrapCD = GetSpellCooldown(1499)
	
	if ScatterShotCD < 3 and FreezingTrapCD < 3 then
		if TrapLauncherBuff == nil then
			CastSpellByName(TrapLauncher)
		end
		CastSpellByName(ScatterShot, "target")
		return true
	end


	if ScatterShotCD > 20 and FreezingTrapCD < 3 and TrapLauncherBuff == nil then
		CastSpellByName(TrapLauncher)
		return true
	end


	if ScatterShotCD > 20 and FreezingTrapCD < 3 and TrapLauncherBuff then
		RunMacroText("/cast "..FreezingTrap)
		if FreezingTrapTimeout == nil or FreezingTrapTarget == nil then
			FreezingTrapTarget = UnitName("target")
		end
		FreezingTrapTimeout = GetTime() + 3
		CameraOrSelectOrMoveStart()
		CameraOrSelectOrMoveStop()
		return true
	end
end

Wow thanks very much. This works, pretty amazing piece of code there Xelper.

a quick question. Does this work on a mouse over target or just the target you are currently on?

Edit: Looks like it works on the target you are currently on. I have tried changing the "target" part for the scatter shot to "mouseover" but that does not work. Any suggestions on what to change to get that to happen?

---------- Post added at 02:16 PM ---------- Previous post was at 01:52 PM ----------

Hey there Kick, your newest rotations aren't working. I turn them on and all that happens is Auto-shot. Any ideas?

That's odd, I did several BGs last night and this morning with no trouble. What rotation, what spec, what were you doing? Just it doesn't work really doesn't tell me anything.

[DKVance73]

That's odd, I did several BGs last night and this morning with no trouble. What rotation, what spec, what were you doing? Just it doesn't work really doesn't tell me anything.

I used crystaltech's and Sheron's just fine with no issues. I tried the BM and SV rotations (non PVP as I don't PVP) and none work. They just auto attack on trash mobs, bosses, target dummies. Even holding the Left Control Key doesn't even activate the trap launcher. What did you change between the latest release and the prior one? Maybe post the prior one that didn't have all the PVP centric changes and I can tell you if that works.

[averykey]

Hey grb when inq is about to fall off it refreshes with 2hp or 1 hp, it should always refresh with 3 hp, according to elitist jerks it is a dps loss to do it the other way.

Maybe a check with templar/inq if at 5 secs and crusader and judge is up do templar otherwise refresh, it should never fall off then.


Divine plea should be at 10-15% mana, When i use consecration and how in order sometimes i get at 25% 20% mana and it will cast divine plea instead of a dps ability.

You should take the delays off all the abilitys, unless you have a specific reason for them being there.

I notice it doing the dp proc often when 2 hp and crusader is up, it would be a dps gain if it had dp proc and 2hp crusader then 2 templars.

If you have 2 hp and crusader is down and it judges it takes 1 gcd for the hp to show up. But before you get the 3hp it will still cast crusader wasting 1hp, can you make it do another filler ? After a judgement at 2hp.
edit: Still do crusader if no other fillers up.

[Meatglue]

[QUOTE=kickmydog;2178724]Wow thanks very much. This works, pretty amazing piece of code there Xelper.

a quick question. Does this work on a mouse over target or just the target you are currently on?

Edit: Looks like it works on the target you are currently on. I have tried changing the "target" part for the scatter shot to "mouseover" but that does not work. Any suggestions on what to change to get that to happen?[COLOR="Silver"]

Yeah I might have explained it wrong to him as the intentions I wanted it for. Mouseover is needed for this to work the best. With this code as mouseover arena should be cake.

[Xelper]

Name: Scatter Trap Mouseover
Spell ID: 0
Code:

local targetTrapped = UnitDebuffID("target", 1499)
local _, FreezingTrapCD = GetSpellCooldown(1499)
if targetTrapped then
	return true
end


if FreezingTrapTimeout ~= nil and FreezingTrapTimeout > GetTime() then
	local targetName = UnitName("target")
	if targetName == FreezingTrapTarget and FreezingTrapTarget ~= nil then
		if FreezingTrapCD > 3 then
			return true
		end
	end
else
	FreezingTrapTimeout = nil
	FreezingTrapTarget = nil
end


if IsLeftControlKeyDown() and GetCurrentKeyBoardFocus() == nil then
	local ScatterShot = GetSpellInfo(19503)
	local TrapLauncher = GetSpellInfo(77769)
	local FreezingTrap = GetSpellInfo(1499)
	local ScatterShotCD, ScatterDuration = GetSpellCooldown(19503)
	ScatterShotCD = ScatterShotCD - GetTime() + ScatterDuration
	local TrapLauncherBuff = UnitBuffID("player", 77769)
	
	if ScatterShotCD < 3 and FreezingTrapCD < 3 then
		CastSpellByName(ScatterShot, "mouseover")
		return true
	end


	if ScatterShotCD > 20 and FreezingTrapCD < 3 and TrapLauncherBuff == nil then
		CastSpellByName(TrapLauncher)
		return true
	end


	if ScatterShotCD > 20 and FreezingTrapCD < 3 and TrapLauncherBuff then
		RunMacroText("/cast "..FreezingTrap)
		if FreezingTrapTimeout == nil or FreezingTrapTarget == nil then
			FreezingTrapTarget = UnitName("mouseover")
		end
		FreezingTrapTimeout = GetTime() + 3
		local PQR_TargetName = UnitName("target")
		local friendPlates = GetCVar("nameplateShowFriends")
		local enemyPlates = GetCVar("nameplateShowEnemies")
		SetCVar("nameplateShowFriends", 0)
		SetCVar("nameplateShowEnemies", 0)
		CameraOrSelectOrMoveStart()
		CameraOrSelectOrMoveStop()
		SetCVar("nameplateShowFriends", friendPlates)
		SetCVar("nameplateShowEnemies", enemyPlates)
		local PQR_TargetNameNew = UnitName("target")
		if PQR_TargetName ~= nil then
			if PQR_TargetName ~= PQR_TargetNameNew then
				TargetLastTarget()
			end
		else
			ClearTarget()
		end
		return true
	end
end

[kickmydog]

I used crystaltech's and Sheron's just fine with no issues. I tried the BM and SV rotations (non PVP as I don't PVP) and none work. They just auto attack on trash mobs, bosses, target dummies. Even holding the Left Control Key doesn't even activate the trap launcher. What did you change between the latest release and the prior one? Maybe post the prior one that didn't have all the PVP centric changes and I can tell you if that works.

It's the All:Kill Command, that is being buggy for some reason, take it out of the rotation and it should work again. I'm going to have to fix it. I'll put a new updated rotation and stuff up after I've messed around with Xelper's new scatter trap code. Exciting stuff.

Ok the problem with All:Kill Command is the double if at the start of it. Stupid error. So change "if if" to just "if"

[taker]

yeah read like 10 posts back i left some debug code in just remove the print statement from the purge ability. why would you want to cancel ghw like that? if it's to cast a NS GHW instead then you should also be checking that NS is off CD before cancelling. you'd also want to check how long GHW has left in its cast time since it could have been just about to finish casting. which um, hey i might steal that idea!

I dont know if my modifier code will work, help welcome.

16188=Nature's Swiftness
77472=Greater Healing Wave

local _,lcd =  GetSpellCooldown(16188)

if lcd == 0 and (member[lowest].health < 18) then
  if PQR_IsCastingSpell(77472) == true or PQR_IsCastingSpell(331) == true or PQR_IsCastingSpell(1064) == true 
  and (timer == nill or timer - GetTime() >= 1.3) 
   then
     RunMacroText("/stopcasting")
     return true
end
end

tested and it works

[TommyT]

Any update for the combat rogue profile so it uses feint when morchok or kohcrom uses stomp?
Will rep if someone can help out with this

[kickmydog]

Name: Scatter Trap Mouseover
Spell ID: 0
Code:

local targetTrapped = UnitDebuffID("target", 1499)
local _, FreezingTrapCD = GetSpellCooldown(1499)
if targetTrapped then
	return true
end


if FreezingTrapTimeout ~= nil and FreezingTrapTimeout > GetTime() then
	local targetName = UnitName("target")
	if targetName == FreezingTrapTarget and FreezingTrapTarget ~= nil then
		if FreezingTrapCD > 3 then
			return true
		end
	end
else
	FreezingTrapTimeout = nil
	FreezingTrapTarget = nil
end


if IsLeftControlKeyDown() and GetCurrentKeyBoardFocus() == nil then
	local ScatterShot = GetSpellInfo(19503)
	local TrapLauncher = GetSpellInfo(77769)
	local FreezingTrap = GetSpellInfo(1499)
	local ScatterShotCD, ScatterDuration = GetSpellCooldown(19503)
	ScatterShotCD = ScatterShotCD - GetTime() + ScatterDuration
	local TrapLauncherBuff = UnitBuffID("player", 77769)
	
	if ScatterShotCD < 3 and FreezingTrapCD < 3 then
		CastSpellByName(ScatterShot, "mouseover")
		return true
	end


	if ScatterShotCD > 20 and FreezingTrapCD < 3 and TrapLauncherBuff == nil then
		CastSpellByName(TrapLauncher)
		return true
	end


	if ScatterShotCD > 20 and FreezingTrapCD < 3 and TrapLauncherBuff then
		RunMacroText("/cast "..FreezingTrap)
		if FreezingTrapTimeout == nil or FreezingTrapTarget == nil then
			FreezingTrapTarget = UnitName("mouseover")
		end
		FreezingTrapTimeout = GetTime() + 3
		local PQR_TargetName = UnitName("target")
		local friendPlates = GetCVar("nameplateShowFriends")
		local enemyPlates = GetCVar("nameplateShowEnemies")
		SetCVar("nameplateShowFriends", 0)
		SetCVar("nameplateShowEnemies", 0)
		CameraOrSelectOrMoveStart()
		CameraOrSelectOrMoveStop()
		SetCVar("nameplateShowFriends", friendPlates)
		SetCVar("nameplateShowEnemies", enemyPlates)
		local PQR_TargetNameNew = UnitName("target")
		if PQR_TargetName ~= nil then
			if PQR_TargetName ~= PQR_TargetNameNew then
				TargetLastTarget()
			end
		else
			ClearTarget()
		end
		return true
	end
end

The speed that this scatter shots and traps is pretty amazing. One problem with it, it changes your current target to the newly trapped target. Is there anyway to make it stay on your current target and not the trapped target?

[Xelper]

One problem with it, it changes your current target to the newly trapped target. Is there anyway to make it stay on your current target and not the trapped target?

I updated the code after my initial post, try it now... all this code here:

        local friendPlates = GetCVar("nameplateShowFriends")
        local enemyPlates = GetCVar("nameplateShowEnemies")
        SetCVar("nameplateShowFriends", 0)
        SetCVar("nameplateShowEnemies", 0)
        CameraOrSelectOrMoveStart()
        CameraOrSelectOrMoveStop()
        SetCVar("nameplateShowFriends", friendPlates)
        SetCVar("nameplateShowEnemies", enemyPlates)
        local PQR_TargetNameNew = UnitName("target")
        if PQR_TargetName ~= nil then
            if PQR_TargetName ~= PQR_TargetNameNew then
                TargetLastTarget()
            end
        else
            ClearTarget()
        end

Is dedicated to restoring your target to your previous target if it changes. If you are testing on target dummies with the same name it wont work.

[kickmydog]

I updated the code after my initial post, try it now... all this code here:

        local friendPlates = GetCVar("nameplateShowFriends")
        local enemyPlates = GetCVar("nameplateShowEnemies")
        SetCVar("nameplateShowFriends", 0)
        SetCVar("nameplateShowEnemies", 0)
        CameraOrSelectOrMoveStart()
        CameraOrSelectOrMoveStop()
        SetCVar("nameplateShowFriends", friendPlates)
        SetCVar("nameplateShowEnemies", enemyPlates)
        local PQR_TargetNameNew = UnitName("target")
        if PQR_TargetName ~= nil then
            if PQR_TargetName ~= PQR_TargetNameNew then
                TargetLastTarget()
            end
        else
            ClearTarget()
        end

Is dedicated to restoring your target to your previous target if it changes. If you are testing on target dummies with the same name it wont work.

Doh, yes changing to different dummy names certainly made it work excellently.