[BETA] PQRotation - an automated ability priority queue.

[fmagretto]

Hey guys, it's been quite a while since I have checked in on this forum. I have been on a hiatus from WoW for a while now. I'm getting back into it again but I am so far behind on the new features of this program and the changes to the game that I am probably not gonna get back into profile making any time soon. If you guys want, I will upload what I do have coded and what I was working on just to use as a resource and see what ideas I had. They are all PVP or arena based.

Yes please, any pvp profiles will be well appreciated. I think for most of us, myself included, we can put together a pve profile easy since its based on strict class rotation and situation rules that we can turn into code but PVP is much harder and requires extensive playing that class in PVP to be effective. I know i would love to turn my Ret Pally profile into a PVP version but i'm having issues to say the least.

Also I created a spreadsheet of all PVP(player spells) Stun/CC/Snare/Disarm/Root with name type and spell ID based off an addon which had the info (i think powerauras).
PVP debuff Spreadsheet by fmagretto
This should help people making PVP trinket code and every man for himself or Hand of freedom. On that note I ask if anyone creates such an ability to please share.

I would also advise anyone writing one to 'break early/fast'(yes i know they use the same term for error handling) and make order matter in your for loop to look for debuffs. For example

local debuff = { 45524, 1715, 3408, 59638, 20164, 25809, 31589, 51585, 50040, 50041, 31126, 31124, 122, 44614, 1604, 45524, 50040, 339, 45334, 58179, 61391, 19306, 19185, 35101, 5116, 61394, 2974, 54644, 50245, 50271, 54706, 4167, 33395, 83302, 55080, 11113, 6136, 120, 116, 44614, 31589, 63529, 20170, 87194, 31125, 3409, 26679, 64695, 63685, 8056, 8034, 18118, 18223, 63311, 23694, 1715, 12323, 39965, 55536, 13099, 29703 }

for i,v in ipairs(debuff) do
 if UnitDebuffID("player",v) then return true end
end

See how the if statement immediately returns? I've notice some peoples debuff check will look like this:

local buff = { 45524, 1715, 3408, 59638, 20164, 25809, 31589, 51585, 50040, 50041, 31126, 31124, 122, 44614, 1604, 45524, 50040, 339, 45334, 58179, 61391, 19306, 19185, 35101, 5116, 61394, 2974, 54644, 50245, 50271, 54706, 4167, 33395, 83302, 55080, 11113, 6136, 120, 116, 44614, 31589, 63529, 20170, 87194, 31125, 3409, 26679, 64695, 63685, 8056, 8034, 18118, 18223, 63311, 23694, 1715, 12323, 39965, 55536, 13099, 29703 }
local havebuff = nil

for i,v in ipairs(buff) do
 if UnitDebuffID(PQR_CustomTarget,v) then havebuff = 1 end
end

if havebuff then return true  end

Notice the use of the boolean to check for the buff even thought you have the info you need at the time the 'havebuff' is set. That means even if it recognized you have the first debuff in the list it will continue to loop the the rest of the very long list and mind you this is happening everytime PQR ability checks this spell which may be a few times a second. I know we don't focus on efficiency much but it's something to consider if you want a responsive profile. So instead of setting a boolean in the IF just 'return true'.

Also especially with the situation above ORDER matters. If you know you are most likely to be feared then put fear in the front of the list and the least likely in the back so that it finds the most likely first and returns quick if found.

I don't mean to call anyone out, i'm just looking to help improve your own profiles. Remember that even though it seems simple every check and every bit of info you pull to make your profile takes processing time and memory just like an addon does and variables will stay there when declared so try to use locals when you don't want a global variable and if theres info u can save in a variable instead of re-requesting it then do it.

Sorry for the long post. it's ok if it's TL;DR

[expunge]

yes it does. to do this I've just delayed the shot from being casted by 1300ms I tried a 2000ms or 2sec delay but lost dps. with 1300 its just right for me.

yeah, never mind, i'm a retard

[fmagretto]

Xelper,

I know you're probably busy but would it be possible to add some new features soon? Main things that I know would help would be

1. Allow a once loaded 'library' ability. So we can define lua functions once and use them through out the profiles and then we could make a PVP library that could have a function HaveTrinketDebuff() that would return true if we had a CC that could be removed with the trinket. Things like that would be simple since its the same as you're doing now with the abilities but just run once when the profile is loaded and would be extremly helpful.
2. Have abilities that will be used out of combat like buffs and aura etc. I love pqr's ability to know when i'm in combat but its either let it control the if in combat or do it in the profile and be able to do stuff out of combat. So if we could either have a second list or a checkbox that says 'Ignore combat status' for a spell it would be easier.
3. The ability to copy a spell from one profile to another would be helpful too.
4. The option to have pqr check if the spell is in range would cut down on some of the repeat code as well.

a
They are in order of helpfulness so if there can only be one implemented soon number 1 would be the one i think would benefit everyone the most. We can then create a 'standard library' for PQR which could be tuned and updated outside the realm of a single profile. I would offer to implement these functions myself (I have a BS in comp sci and do c++/java programming for a living) but I don't think you want to part with the source code just yet (not make it open but i know allowing someone else to touch your code is something not taken lightly).

Thanks for reading

[Ralphiuss]

Alright folks I just created a SVN respiratory of all the profiles I can found on all the 200+ pages I went trough.


Things to remember,

A lot of these profiles are not tested. Use at your own risk.

Most of these profiles work to some extent. Only really effy one is the Balance druid profile. I might even delete this as it's really not that good.

I listed it by class then spec. A lot of the specs are built into one profile. So if it ask to over write, just hit ok or skip. Up to you.

http://pqr-svn-profiles.googlecode.com/svn/

I check this forum a lot during my work day. I'll update the profiles on a whim so I'd update your checkout as much as possible.

You'll need TortoiseSVN to use this

[Meatglue]

Hey guys, it's been quite a while since I have checked in on this forum. I have been on a hiatus from WoW for a while now. I'm getting back into it again but I am so far behind on the new features of this program and the changes to the game that I am probably not gonna get back into profile making any time soon. If you guys want, I will upload what I do have coded and what I was working on just to use as a resource and see what ideas I had. They are all PVP or arena based.

Welcome back, can't wait to see what new class to play based on your pvp profiles.

[Lofty]

Anyone else getting an error when trying to load the Holy Paladin profile?

---------- Post added at 02:36 PM ---------- Previous post was at 01:58 PM ----------

NVM sorted it. HOLY MANA DRAIN :O

[Zemnexx]

Alright folks I just created a SVN respiratory of all the profiles I can found on all the 200+ pages I went trough.


Things to remember,

A lot of these profiles are not tested. Use at your own risk.

Most of these profiles work to some extent. Only really effy one is the Balance druid profile. I might even delete this as it's really not that good.

I listed it by class then spec. A lot of the specs are built into one profile. So if it ask to over write, just hit ok or skip. Up to you.

pqr-svn-profiles - Revision 16: /

I check this forum a lot during my work day. I'll update the profiles on a whim so I'd update your checkout as much as possible.

You'll need TortoiseSVN to use this

Very nice, +rep. If you can keep it updated with everyone's profiles, that would surely be appreciated.

Yes please, any pvp profiles will be well appreciated. I think for most of us, myself included, we can put together a pve profile easy since its based on strict class rotation and situation rules that we can turn into code but PVP is much harder and requires extensive playing that class in PVP to be effective. I know i would love to turn my Ret Pally profile into a PVP version but i'm having issues to say the least.

Also I created a spreadsheet of all PVP(player spells) Stun/CC/Snare/Disarm/Root with name type and spell ID based off an addon which had the info (i think powerauras).
PVP debuff Spreadsheet by fmagretto

Very nice job on the spreadsheet. That is extremely helpful.

[Eff]

Allow a once loaded 'library' ability. So we can define lua functions once and use them through out the profiles and then we could make a PVP library that could have a function HaveTrinketDebuff() that would return true if we had a CC that could be removed with the trinket. Things like that would be simple since its the same as you're doing now with the abilities but just run once when the profile is loaded and would be extremly helpful.
The option to have pqr check if the spell is in range would cut down on some of the repeat code as well.

You could take a look at my Resto Druid profile, I started working on doing exactly that. I created functions to combine all checks and other features into easily reusable code and it cut down a lot on repeated code, it's not perfect but it's getting there.

[paveley]

Hey guys, first i want to say thanks to all the great ppl making this work, and second i'm shit with LUA coding. Now for my question. I have been trying to get Holy Radiance in Bubbas profile to work like Onyas Chain Heal but with little success. I simply copy/pasted Chain Heal into Holy Radiance and changed the spell id's etc......getting tons of errors in Wow. I need help from a professional =D. This is what i get


42x <string>:" function pqrFunc0() local Aura = GetShapes...":168: 'for' limit must be a number
<string>:" function pqrFunc0() local Aura = GetShapes...":190: in function `?'
<string>:"...":254: in function `PQR_NextAbility'
<string>:"...":161: in function `PQR_CastNext'
<string>:"...":150: in function `PQR_ExecuteBot'
<string>:"...":40: in function <[string "..."]:23>

[Ralphiuss]

Hey guys, first i want to say thanks to all the great ppl making this work, and second i'm shit with LUA coding. Now for my question. I have been trying to get Holy Radiance in Bubbas profile to work like Onyas Chain Heal but with little success. I simply copy/pasted Chain Heal into Holy Radiance and changed the spell id's etc......getting tons of errors in Wow. I need help from a professional =D. Thanks in advance.

He has updated is profile on his SVN to reflect the changes to Holy Radiance. I suggest getting the new profile.

As well I have it posted on my SVN.

[paveley]

Thats great, thanks

[retoxed]

Have anyone made a rogue profile for the daggers with combat? i get better numbers with wielding my 378 axe and Vengeance than if i use both daggers. Anyone have a clue why?

[fmagretto]

You could take a look at my Resto Druid profile, I started working on doing exactly that. I created functions to combine all checks and other features into easily reusable code and it cut down a lot on repeated code, it's not perfect but it's getting there.

I hadn't looked at your resto druid profile since you first released it and now that i just did...I Like It! I was wondering if surrounding the function declarations with an IF statement would work and keep it from re-declaring the functions every time. Since your profile seems to be working i assume its possible. I guess i'm just used to compiled languages and most scripting languages which make it illegal to do so. Your functions are a prime example of how the function would work and it would be even better if they were in a separate file. Profile developers should make note of this because it is a very useful practice and one that should be used more often.

---------- Post added at 06:12 PM ---------- Previous post was at 06:11 PM ----------

Have anyone made a rogue profile for the daggers with combat? i get better numbers with wielding my 378 axe and Vengeance than if i use both daggers. Anyone have a clue why?

Maybe your daggers suck? just a thought


-----------------------------------------------------------------

Also, for the last time people we need to move this topic to somewhere else. I had set up this forum for it http://pqrotation.forumotion.com/ and i understand the updater/svn might change things a bit regarding profiles and i don't care if we don't use it and use another. But we seriously need some organization with even just questions and profile writing help/suggestions. By the time someone writes a question there is 2 more pages between it and the answer and there's no concept of topics. I can add any category to the forum that we need and will base it around whatever people want or someone can create a new one but if we want the community around this amazing tool to flourish we need to get out of this thread. We could have separate posts with useful code (targeting functions, AOE switches, encounter specific spells etc) but right now it would be almost useless to post these things because in a day they will be lost in 5+ pages of posts. The shift to a different posting ground will need to happen all at once with the major posters (you know who you are) joining in. I know its comfortable to keep coming back to this disaster we call a forum post but it's only hurting us not helping.

[retoxed]

Maybe your daggers suck? just a thought

Ment to say its the first daggers in the legendary chain..

[fmagretto]

You could take a look at my Resto Druid profile, I started working on doing exactly that. I created functions to combine all checks and other features into easily reusable code and it cut down a lot on repeated code, it's not perfect but it's getting there.

From looking at your functions and the slash commands you added (which again i wasn't sure was possible using pqr and i'm happy to say i was wrong) I'm really thinking we should make more use out of this. We could register callbacks for events like when combat starts or the combat log events and create reactive abilities that would give more bite then DBM. For example in DS on the 5th boss Ultraxion we could catch when he starts casting hour of twilight or when we get fading light and be able to cast/click the extra action button. Looking at API COMBAT LOG EVENT - WoWWiki - Your guide to the World of Warcraft 's example:

function Foo_OnLoad()
  this:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");
end

function Foo_OnEvent(self, event, ...)

  local timestamp, type, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags = select(1, ...)
  -- Note, for this example, you could just use 'local type = select(2, ...)'.  The others are included so that it's clear what's available.

  if (event=="COMBAT_LOG_EVENT_UNFILTERED") then
    if (type=="SPELL_DAMAGE") then

      local spellId, spellName, spellSchool = select(9, ...)
      -- Use the following line in game version 3.0 or higher, for previous versions use the line after
      local amount, overkill, school, resisted, blocked, absorbed, critical, glancing, crushing = select(12, ...)

      if (spellName=="Mind Blast" and critical==true) then -- ==true for clarity only.  Not needed.
        DEFAULT_CHAT_FRAME:AddMessage("Mind Blast Just Critted!");
      end
    end
  end
end

you can see how we could catch certain spells or buffs/auras/world events and instantly react with our own function (which could also give a chat message warning in case it fails). This kind of code would be more efficient then using the debuff checking for loops that we've been doing since we could craft functions to match any combat event the client can see. There are events for combat

0x98	PLAYER_ENTER_COMBAT
0x99	PLAYER_LEAVE_COMBAT

and everything else imaginable. Now i havn't tried it yet but if we can register functions for slash commands then there is no logical reasoning why we can't create our own EnteredCombat() function that is bound to PLAYER_ENTER_COMBAT and sets a boolean and in our rotation have a ability that checks that global variable. The possibilities are basically endless and if we look at some of the raid warning logic from DBM they have already did alot of the work for us by identifying the events and combat log info we need to react to. Now this might be overkill but I for one like to raid perfectly so I'm going to see how I can perfect even more then my DPS by using this info.


EDIT: Also using the method that Ash used to declare his functions we could also create GUI frames to display info that only the rotation knows like the healing ignore list or current healing target or create a frame with options and buttons that can set those options while the rotation is running. The possibles are endless, we can complete merge the combat system of PQR with addons that are not bound by lua protection with complete and instant communication between the two