[C++ Help] Simple problem, can't figure it out.

[Namor]

Mmk so I was told to make a program that calculates the average of the user input, so I said "Hey, I'll be an overachiever and use for loops."

#include <iostream>
using namespace std;

int main()
{
	int counter2 = 0;
	int dynamicinput = 0;
	int scores[1];
	int average;
	int sum;
	for (int x = 0; dynamicinput == 999; x++)
	{
		cout << "Input one score." << endl;
		counter2 + 1;
		cin >> scores[x - 1];
		dynamicinput = scores[x - 1];
	}
	if(dynamicinput == 999)
{
	for (int i = 0; i < counter2; ++i)
	{
	        sum+=scores[i];
	    average = sum/counter2;
	}
}
	return 0;
}

is what I have.

Though it doesn't quite work.

Visual Studio 2010 output:

verages.exe': Loaded 'C:\Users\Namor\Documents\Visual Studio 2008\Projects\averages\Debug\averages.exe', Symbols loaded.
'averages.exe': Loaded 'C:\Windows\System32\ntdll.dll'
'averages.exe': Loaded 'C:\Windows\System32\mscoree.dll'
'averages.exe': Loaded 'C:\Windows\System32\kernel32.dll'
'averages.exe': Loaded 'C:\Windows\System32\KernelBase.dll'
'averages.exe': Loaded 'C:\Windows\winsxs\x86_microsoft.vc90.debugcrt_1fc8b3b9a1e18e3b_9.0.30729.1_none_bb1f6aa1308c35eb\msvcp90d.dll'
'averages.exe': Loaded 'C:\Windows\winsxs\x86_microsoft.vc90.debugcrt_1fc8b3b9a1e18e3b_9.0.30729.1_none_bb1f6aa1308c35eb\msvcr90d.dll'
'averages.exe': Loaded 'C:\Windows\winsxs\x86_microsoft.vc90.debugcrt_1fc8b3b9a1e18e3b_9.0.30729.1_none_bb1f6aa1308c35eb\msvcm90d.dll'
'averages.exe': Loaded 'C:\Windows\System32\ole32.dll'
'averages.exe': Loaded 'C:\Windows\System32\msvcrt.dll'
'averages.exe': Loaded 'C:\Windows\System32\gdi32.dll'
'averages.exe': Loaded 'C:\Windows\System32\user32.dll'
'averages.exe': Loaded 'C:\Windows\System32\lpk.dll'
'averages.exe': Loaded 'C:\Windows\System32\usp10.dll'
'averages.exe': Loaded 'C:\Windows\System32\rpcrt4.dll'
'averages.exe': Loaded 'C:\Windows\System32\imm32.dll'
'averages.exe': Loaded 'C:\Windows\System32\msctf.dll'
'averages.exe': Loaded 'C:\Windows\System32\advapi32.dll'
'averages.exe': Loaded 'C:\Windows\System32\sechost.dll'
'averages.exe': Loaded 'C:\Windows\Microsoft.NET\Framework\v4.0.30319\mscoreei.dll'
'averages.exe': Loaded 'C:\Windows\System32\shlwapi.dll'
'averages.exe': Loaded 'C:\Windows\Microsoft.NET\Framework\v2.0.50727\mscorwks.dll'
'averages.exe': Loaded 'C:\Windows\winsxs\x86_microsoft.vc80.crt_1fc8b3b9a1e18e3b_8.0.50727.4927_none_d08a205e442db5b5\msvcr80.dll'
'averages.exe': Loaded 'C:\Windows\System32\shell32.dll'
'averages.exe': Loaded 'C:\Windows\System32\profapi.dll'
'averages.exe': Loaded 'C:\Windows\Microsoft.NET\Framework\v2.0.50727\Culture.dll'
'averages.exe': Unloaded 'C:\Windows\Microsoft.NET\Framework\v2.0.50727\Culture.dll'
'averages.exe': Loaded 'C:\Windows\assembly\NativeImages_v2.0.50727_32\mscorlib\f58ab951b57c8526430486dcf7ee38fd\mscorlib.ni.dll'
'averages.exe' (Managed): Loaded 'C:\Windows\assembly\GAC_32\mscorlib\2.0.0.0__b77a5c561934e089\mscorlib.dll'
'averages.exe': Loaded 'C:\Windows\System32\cryptbase.dll'
'averages.exe' (Managed): Loaded 'c:\Users\Namor\Documents\Visual Studio 2008\Projects\averages\Debug\averages.exe', Symbols loaded.
'averages.exe': Loaded 'C:\Windows\Microsoft.NET\Framework\v2.0.50727\mscorjit.dll'
'averages.exe': Loaded 'C:\Windows\Microsoft.NET\Framework\v2.0.50727\diasymreader.dll'
'averages.exe': Loaded 'C:\Windows\System32\cryptsp.dll'
'averages.exe': Loaded 'C:\Windows\System32\rsaenh.dll'
'averages.exe' (Managed): Loaded 'C:\Windows\WinSxS\x86_microsoft.vc90.debugcrt_1fc8b3b9a1e18e3b_9.0.30729.1_none_bb1f6aa1308c35eb\msvcm90d.dll'
'averages.exe': Loaded 'C:\Windows\assembly\NativeImages_v2.0.50727_32\System\500ddd904b1099f95552a81b54223b7f\System.ni.dll'
'averages.exe' (Managed): Loaded 'C:\Windows\assembly\GAC_MSIL\System\2.0.0.0__b77a5c561934e089\System.dll'
The thread 'Win32 Thread' (0x1168) has exited with code 0 (0x0).
The thread 'Win32 Thread' (0x1434) has exited with code 0 (0x0).
The thread 'Win32 Thread' (0x175c) has exited with code 0 (0x0).
The program '[3104] averages.exe: Managed' has exited with code 0 (0x0).
The program '[3104] averages.exe: Native' has exited with code 0 (0x0).

When I debug.

So I need some help with the code. Any takers?

[Nikentic]

Your code should not return anything at all.
for (int x = 0; dynamicinput == 999; x++)

So, when dynamicinput is 999 it does etc etc. But dynamicinput is never changed from 0 to 999. So does nothing.

for (int i = 0; i < counter2; ++i)
couter2 is 0. So if 0 < 0, do that. But 0 is not greater than 0. So does nothing.

[Namor]

Oh. I was thinking that for loops were like do whiles. My bad.

---------- Post added at 05:30 PM ---------- Previous post was at 05:25 PM ----------

Now it's working quite well. Thank you for your help, although I have one problem.
I have it set to where when you type "999" it ends. Though it also adds a new value to the array. I want it to not add in the 999. How might I do that?

---------- Post added at 07:08 PM ---------- Previous post was at 05:30 PM ----------

After several frustrating hours, I finally remade the program.

/*
Kevin Minehart
Display average of user input.
*/



//Uses the Input Output stream header file from the standard library, or "std"
#include <iostream>
using namespace std;

int main()
{
	int scores[100];
	int amountofplayers = 0;
	int sum = 0;
	int average = 0;
	cout << "How many players do you have?" << endl;
	cin >> amountofplayers;
	for(int x = 0; x < amountofplayers; x++)
	{
		if(x == 0)
		{
			cout << "What was the 1st person's score?" << endl;
		}
		if(x == 1)
		{
			cout << "What was the 2nd person's score?" << endl;
		}
		if(x == 2)
		{
			cout << "What was the 3rd person's score?" << endl;
		}
		if(x != 0 && x != 1 && x !=2)
		{
			cout << "What was the " << x + 1  << "th person's score?" << endl;
		}
		cin >> scores[x - 1];
	}
	for(int y = 0; y < amountofplayers; y++)
	{
		sum = sum + scores[y - 1];
	}
	cout << "The average of your scores is about:  " << sum / amountofplayers << endl;
}

You're limited to 100 values, but OH WELL. Who's gonna need 100 values anyways?

[LaoArchAngel]

You got it pretty close, but there's an easy way you can bypass your 100# limit. Also, if you're going to limit the count of players to 100, you need to let the user know that. If your user had typed in 101 (a valid option in your code), the app would've thrown an exception later on while assigning values to your array.

NOTE: I did not change this in an IDE or compile it, so there might be a minor bug or two, but the concept is the same. BTW, coding in a reply box blows balls.

#include <iostream>
using namespace std;

int main()
{
	int amountofplayers = 0;
	int newVal = 0;
	int sum = 0;
	int average = 0;
	cout << "How many players do you have?" << endl;
	cin >> amountofplayers;

	for(int x = 0; x < amountofplayers; x++)
	{
		// You probably haven't learned switch statements yet, but you'll noticed how it easily resolves multiple IF cases into one.
		// They generally make your code look cleaner and more professional (read: more maintainable).  Also, only one IF case need to be tested here.
		// 4 If-statements won't eat almost any CPU cycles, but get "optimization" into your head now and you'll be a happy camper in the future.
		switch ( x )
		{
			case 0:
				cout << "What was the 1st person's score?" << endl;
				break;  // Break tells the code to not process the next case as well.  Removing these can be used in a cascading effect which may or may not be desirable.
			case 1:
				cout << "What was the 2nd person's score?" << endl;
				break;
			case 2:
				cout << "What was the 3rd person's score?" << endl;
				break;
			default:
				cout << "What was the " << x + 1  << "th person's score?" << endl;
				break;
		}

		cin >> newVal;   // I'm sure there's a way to combine this line and the next into one, but for the sake of simplicity...
		sum += newVal;  // += is a binary operator that means add the following value (newVal) to the preceding (sum).
		// This will get rid of your limited array, as well as the need for a for-loop later on.
	}

	// Getting rid of the loop you had here is important.  Not in this case, per say, but in more complex apps, additional loops just eat CPU cycles and memory.
	cout << "The average of your scores is about:  " << sum / amountofplayers << endl;

	return 0;
}