Custom Graveyard for Trinity.

[4BOLTMAIN]

What do I use to detect when a player clicks the release button?

Right now I have OnPVPKill and OnPlayerKilledByCreature. But these 2 commands send the player to the graveyard immediately when they die.

Here is the script I have so far. I got this from someone else, I only made minor changes.

#include "ScriptPCH.h"


class hyjal_grave : public PlayerScript
{
public:
    hyjal_grave() : PlayerScript("hyjal_grave") {}

    void OnPVPKill(Player* killer, Player* killed) 
    {
        if (killed->GetMapId() == 1 && killed->GetZoneId() == 616)
        {
            killed->TeleportTo(1, 4981.97f, -2857.31f, 1452.67f, 5.36318f);
        }
    }

    void OnPlayerKilledByCreature(Creature* killer, Player* killed)
    {
        if (killed->GetMapId() == 1 && killed->GetZoneId() == 616)
        {
            killed->TeleportTo(1, 4981.97f, -2857.31f, 1452.67f, 5.36318f);
        }
    }
};

void AddSC_hyjal_grave()
{
    new hyjal_grave();
}

[92eatos]

why not just add graveyard in db :S without script

[4BOLTMAIN]

why not just add graveyard in db :S without script

I tried doing that but it didnt work so I did some more research and discovered that this isnt possible without editing the dbc files on both the server and the client. This is definitely something I want to avoid for obvious reasons.

I ran a Neverwinter Nights server for over 5 years and in the script editor there was a search option that would let you search through all the commands (not sure if that is what it is called but I mean commands in NWN like GetLastUsedBy() ) then it would give an explanation of what the commands did. I know this isnt NWN but the coding is very similar. It would be great if there was a list of commands like this somewhere for the trinity core. I have looked at the example scripts and have figured out how to make teleporter scripts on my own but I am lost when it comes to finding something like what I am looking for.

[The-Eradicator]

I ran a Neverwinter Nights server for over 5 years and in the script editor there was a search option that would let you search through all the commands (not sure if that is what it is called but I mean commands in NWN like GetLastUsedBy() ) then it would give an explanation of what the commands did. I know this isnt NWN but the coding is very similar. It would be great if there was a list of commands like this somewhere for the trinity core. I have looked at the example scripts and have figured out how to make teleporter scripts on my own but I am lost when it comes to finding something like what I am looking for.

Doesn't exist. I suggest you read up on Object Oriented Programming.

You only have access to methods where you have access to an instance of the object that the method is in, or when the method is static.

However, using Visual Studio, try searching the entire project (Control+Shift+F) to see if a method exists for what you'd like to do. Then figure out whether you have an instance of that class. If you don't, figure out how to get one.

[4BOLTMAIN]

Well, Ive been digging through the source, using the find in VS and I dont see anything where a player would click the release button. Im just beginning to learn this stuff so I may have overlooked it. I also read some of the Wiki on Object Oriented Programming and thats a little over my head yet. I am hoping someone has done this before and has an example for me.

[4BOLTMAIN]

Ok, Heres where I am at now... in the player.cpp file there is this section...(was gonna post the whole thing but thats not gonna work...lol)

void Player::RepopAtGraveyard()
{
        // note: this can be called also when the player is alive
    // for example from WorldSession::HandleMovementOpcodes

    AreaTableEntry const *zone = GetAreaEntryByAreaID(GetAreaId());

    // Such zones are considered unreachable as a ghost and the player must be automatically revived    
        if ((!isAlive() && zone && zone->flags & AREA_FLAG_NEED_FLY) || GetTransport() || GetPositionZ() < -500.0f)
        {
        ResurrectPlayer(0.5f);
        SpawnCorpseBones();
    }

    WorldSafeLocsEntry const *ClosestGrave = NULL;

    // Special handle for battleground maps
    if (Battleground *bg = GetBattleground())
        ClosestGrave = bg->GetClosestGraveYard(this);
    else
        ClosestGrave = sObjectMgr->GetClosestGraveYard(GetPositionX(), GetPositionY(), GetPositionZ(), GetMapId(), GetTeam());

    // stop countdown until repop
    m_deathTimer = 0;

    // if no grave found, stay at the current location
    // and don't show spirit healer location
        if (ClosestGrave)
        {
        TeleportTo(ClosestGrave->map_id, ClosestGrave->x, ClosestGrave->y, ClosestGrave->z, GetOrientation());
        if (isDead())                                        // not send if alive, because it used in TeleportTo()
        {
            WorldPacket data(SMSG_DEATH_RELEASE_LOC, 4*4);  // show spirit healer position on minimap
            data << ClosestGrave->map_id;
            data << ClosestGrave->x;
            data << ClosestGrave->y;
            data << ClosestGrave->z;
            GetSession()->SendPacket(&data);
        }
    }
        else if (GetPositionZ() < -500.0f)
        TeleportTo(m_homebindMapId, m_homebindX, m_homebindY, m_homebindZ, GetOrientation());
}

Now if I add this line to that section of code

// 4boltmain Hyjal Grave added line
        if (GetZoneId() == 616) TeleportTo(1, 4981.97f, -2857.31f, 1452.67f, 5.36318f);
        // 4boltmain Hyjal Grave added line

I am ported to the grave position when I click the release button but when I die my corpse is up in the air off the ground.
I cant figure out why my corpse is up in the air when I die. Ive tried changing both GetPositionZ() < -500.0f to simply 0.5f but that has no effect...but anyway, I know shouldnt even be editing this file at all I was experimenting for testing purposes.

How would I make a custom script to reference this section to have the player ported to the graveyard coordinates?

[4BOLTMAIN]

Heres what I changed in the player.cpp file... I probably shouldnt have edited this file but I cant figure out how to make a stand alone script to do this. The added line is near the bottom.

void Player::RepopAtGraveyard()
{
        // note: this can be called also when the player is alive
    // for example from WorldSession::HandleMovementOpcodes

    AreaTableEntry const *zone = GetAreaEntryByAreaID(GetAreaId());

    // Such zones are considered unreachable as a ghost and the player must be automatically revived    
        if ((!isAlive() && zone && zone->flags & AREA_FLAG_NEED_FLY) || GetTransport() || GetPositionZ() < -500.0f)
        {
        ResurrectPlayer(0.5f);
        SpawnCorpseBones();
    }

    WorldSafeLocsEntry const *ClosestGrave = NULL;

    // Special handle for battleground maps
    if (Battleground *bg = GetBattleground())
        ClosestGrave = bg->GetClosestGraveYard(this);
    else
        ClosestGrave = sObjectMgr->GetClosestGraveYard(GetPositionX(), GetPositionY(), GetPositionZ(), GetMapId(), GetTeam());

    // stop countdown until repop
    m_deathTimer = 0;

    // if no grave found, stay at the current location
    // and don't show spirit healer location
        if (ClosestGrave)
        {
        TeleportTo(ClosestGrave->map_id, ClosestGrave->x, ClosestGrave->y, ClosestGrave->z, GetOrientation());
        if (isDead())                                        // not send if alive, because it used in TeleportTo()
        {
            WorldPacket data(SMSG_DEATH_RELEASE_LOC, 4*4);  // show spirit healer position on minimap
            data << ClosestGrave->map_id;
            data << ClosestGrave->x;
            data << ClosestGrave->y;
            data << ClosestGrave->z;
            GetSession()->SendPacket(&data);
        }
    }
        // I only had to add this one line here... zone 616 is the Hyjal area. 
        // It didnt work right on a previous core but it does on Rev. 11439.
        
        else if (GetZoneId() == 616) TeleportTo(1, 4981.97f, -2857.31f, 1452.67f, 5.36318f); 
        
        // original code
        else if (GetPositionZ() < -500.0f)
        TeleportTo(m_homebindMapId, m_homebindX, m_homebindY, m_homebindZ, GetOrientation());
}