[Lua] Mobs always cast spells on themselves. Not the target

[Wheeze201]

function general_OnCombat(pUnit, event)
    pUnit:CastSpellOnTarget(100, pUnit:GetMainTank())
    pUnit:RegisterEvent("cleave", 3000, 2)
    pUnit:RegisterEvent("bleed", 1800, 1)
end

function cleave(pUnit, event)
pUnit:CastSpellOnTarget(30619, pUnit:GetMainTank())
end

function bleed(pUnit, event)
pUnit:CastSpellOnTarget(59343, pUnit:GetMainTank())
end

RegisterUnitEvent(990914, 1, "general_OnCombat")

I've looked at other code i've done and it's exactly the same and it doesn't have this problem.
I've tried using locals.
like: "local target = pUnit:GetMainTank()"

[Ascelyn]

You could try this.

function General_Cleave(pUnit, Event)
local plr = pUnit:GetMainTank()
if (plr ~= nil) then
pUnit:FullCastSpellOnTarget(SPELLID, plr)
end
end

I hope its usefull

[Vision1000]

Ascelyn's example should work.

But for future reference, CastSpellOnTarget() is bugged for a lot of Lua Engines and will always have the NPC cast it on themselves.

[SirRFI]

This post has been a bit modified since first "version"
I had similar problem and some questions but I already found answers by myself

Well, I made some tests to answer for my questions and your's questions.

I made a NPC scripts and added following lines:

function FireBall(Unit, Event)
Unit:CastSpellOnTarget(133, Unit:GetMainTank())
end

function FrostBolt(Unit, Event)
Unit:FullCastSpellOnTarget(116, Unit:GetMainTank())
end

function Wrath(pUnit, Event)
local plr = pUnit:GetMainTank()
if (plr ~= nil) then
pUnit:FullCastSpellOnTarget(5176, plr)
end
end

All of these spells are player's spells with 1.5 sec casting time. Difference between them (expect spell ID etc) is just the code.

RESULTS:

FireBall <- Used "CastSpellOnTarget" code. Result: Mob instantly casted this spell on ITSELF.

FrostBolt <- Used "FullCastSpellOnTarget" code. Result: Mob casted the spell on the TANK with CASTING TIME.

Wrath <- Used Ascelyn's method (with "FullCastSpellOnTarget" code). Result: Mob casted the spell on the TANK with CASTING TIME.

You could try this.

function General_Cleave(pUnit, Event)
local plr = pUnit:GetMainTank()
if (plr ~= nil) then
pUnit:FullCastSpellOnTarget(SPELLID, plr)
end
end

I hope its usefull

Yes, this works but there are needless lines since simpler version works same (look at FrostBolt code)

But for future reference, CastSpellOnTarget() is bugged for a lot of Lua Engines and will always have the NPC cast it on themselves.

My test confirmed your's opinion.

Also some information that I just discovered about this:

	Unit:RegisterEvent("Spell1", 30000, 5)
	Unit:RegisterEvent("Spell2", 30000, 8)

30000 is time in miliseconds (1000 miliseconds = 1 second) after which the NPC casts the spell. The number after this value (in Spell1 it is 5, in Spell2 it is 8 in our example) is how many times NPC repeat this action. In our example this will be like: NPC will cast Spell1 5 times with delay 30 seconds between them. After 5 times he won't cast this spell anymore.

Thanks for help, also I hope my test-results helped You somehow guys too.

=======
+Rep me if I helped

[SirRFI]

Sorry, double post by mistake. Please delete this post. Thanks in advice.

[tea91]

SirRFI // thx

[Ascelyn]

Sirfi, How do you fix the fact mobs cast the spell even when they went out of mana? :S I was able to add so when he gets underneath 25% of mana he uses evocation but I want to do it without..

[SirRFI]

Sirfi, How do you fix the fact mobs cast the spell even when they went out of mana? :S I was able to add so when he gets underneath 25% of mana he uses evocation but I want to do it without..

While testing I didnt make my mobs castings spells more than 1 time so they had no time to spent all mana. I don't even know if they will continue casting spells when they are without mana and those spells require mana. As I wrote in old version of my post, I made an DK copy that uses DK spellsand they works without runicpower since mobs cannot have runicpower. Most of blizzlike mobs using spells not avaiable for players that don't require mana, so there is no problem for them.
Anyway, if you still want your's mob to cast player's spells that require mana, you can at least do one more spell line that will restore the mana. The spell is Mana Potion (spell id: 32453)

I begun my advanture with lua npc scripting few days ago, so I'm not expriencied on it a bit yet. My first post in this thread was question-post at the beginning, mean while waiting for an answer I tested few things and found answers for my questions and shered them with you.

-- EDIT:
I can see that when mob cast spell with mp requiment, he gets the mana back in a second.

[Ascelyn]

Well I did this.

local Didthat = 0

function Mage_OnCombat (Unit, Event)
Unit:RegisterEvent("Mage_Frostnova",35000, 0)
Unit:RegisterEvent("Mage_Barrier", 40000, 2)
Unit:RegisterEvent("Mage_Evocation",10000,0)
end

function Mage_Evocation(pUnit, Event)
if pUnit:GetManaPct() < 25 then
pUnit:FullCastSpell(52869) -- Evocation
else
local plr = pUnit:GetRandomPlayer(0)
if plr == nil then
else
pUnit:FullCastSpellOnTarget(42842, plr)
end
end
end

Just a part of my script, And that works. But I want him to just cast and when he gets under 25% he just uses melee instead of bugging up >_>

[Wheeze201]

Alright so..
FullCastSpellOnTarget only works for targets ?

Kind of weird.. and a disappointment. Since there are alot of spells which have casting time you don't want.

[SirRFI]

Ascelyn - I did something like:

function MyNPC_OnCombat(Unit, Event)
	Unit:RegisterEvent("HpTest", 1000, 0)
	Unit:RegisterEvent("MpTest", 1000, 0)
end

function HpTest(Unit, Event)
	if unit:GetHealthPct() < 75 then
		unit:SendChatMessage(12, 7, "Auu!")
		Unit:FullCastSpellOnTarget(5176, Unit:GetMainTank())
	else
	end
end

function MpTest(Unit, Event)
	if unit:GetManaPct() < 75 then
		unit:SendChatMessage(12, 7, "Ahh... losing ... mana...")
		Unit:FullCastSpellOnTarget(8921, Unit:GetMainTank())
	else
	end
end

And does NOT work also.



But found this:

function kt_OnCombat(Unit, Event)
	local phase3 = 0
	(...)
	Unit:RegisterEvent("Phase3",1000,0)
end

function Phase3(Unit, Event)
		if Unit:GetHealthPct() < 41 then
			if phase3==0 then
				Unit:SendChatMessage(14,0, "Something happens...")
				phase3 = 1
			else
			end
		end
end

This is cutted part from BOSS-Naxxramas-KelThuzad.lua by ArcEmu (game version 2.4.3). Check it out, may work... I will test it later. But I think it's like that:
" local phase3 = 0 " = PHASE3 is marked as 0 (not happen yet) because the NPC just entered combat
" if phase3==0 then " = if function named PHASE3 is TRUE then something happens (lines below it)
" phase3 = 1 " = PHASE3 has been marked as 1 (already happen)


===========

Wheezee201 - seems to. You can try some other methods by yourself or use different spell ID or so.

=======
+Rep me if I helped