[HELP] C++ OnPlayerKill crash

[gotiefan]

Hello,

I've modified some scripts and merged them together since I suck at C++

#include "StdAfx.h"
#include "Setup.h"


void AddGold(uint32 gold, Player * Plr)
{
    uint32 gamm = Plr->GetUInt32Value(PLAYER_FIELD_COINAGE);
    uint32 goldammount = gamm + gold;
    Plr->SetUInt32Value(PLAYER_FIELD_COINAGE, goldammount);
}

void TakeGold(uint32 gold, Player * Plr)
{
    uint32 gamm = Plr->GetUInt32Value(PLAYER_FIELD_COINAGE);
    uint32 goldammount = gamm - gold;
    Plr->SetUInt32Value(PLAYER_FIELD_COINAGE, goldammount);
}

void OnPlayerKill(Player* attacker, Player* victim)
{
	
    AddGold(10000, attacker);
	if( attacker->GetSession() )
		attacker->GetSession()->SendNotification("%sYou gain %u Gold.", "|cff00ff00", 1);

    TakeGold(5000, victim);
	if( victim->GetSession() )
		victim->GetSession()->SendNotification("%sYou lost %u Silver.", "|cff00ff00", 50);

}


void SetupArenaPvP(ScriptMgr * mgr)
{
   mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, &OnPlayerKill);

}

Everything works fine, except the 'TakeGold'.

It crashes the server if I kill another player.

Does anyone know what the problem is?

[Jotox]

Mm this seems familiar. XD

Here, I'll give you a working version of the script you're trying to make:

void OnPlayerKill(Player* attacker, Player* victim)
{
	if( !attacker || !victim || victim==attacker )
		return;

	attacker->ModUnsigned32Value( PLAYER_FIELD_COINAGE , 10000 );
	victim->ModUnsigned32Value( PLAYER_FIELD_COINAGE, -5000 );

	if( attacker->GetSession() )
		attacker->GetSession()->SendNotification("%sYou gain %u Gold.", "|cff00ff00", 1);

	if( victim->GetSession() )
		victim->GetSession()->SendNotification("%sYou lost %u Silver.", "|cff00ff00", 50);

}


void SetupArenaPvP(ScriptMgr * mgr)
{
   mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, &OnPlayerKill);

}

[gotiefan]

Hehe, I'll try. Moment.

Edit:
Mmm, Server crashes again.

The crash is because of this line:

victim->ModUnsigned32Value( PLAYER_FIELD_COINAGE, -5000 );

Can it be that the server crashes because the victim doesn't have 50 silver? -- Has nothing to do with this, I tested it with 1 G.

When I removed the line, it worked fine.. except the victim doesn't lose 50 S ofcourse.

[gotiefan]

Does anyone know a fix for this?

[Gastricpenguin]

Simple answer, check to see if they have 50 silver...

uint32 coin = victim->GetUInt32Value(PLAYER_FIELD_COINAGE);
if(coin > 5000)
     victim->ModUnsigned32Value( PLAYER_FIELD_COINAGE, -5000 );
else
     victim->SetUInt32Value(PLAYER_FIELD_COINAGE, 0);

If they have more than 50 silver, it removes silver. If they have exactly 50 silver or less, it sets their money to 0.

[gotiefan]

Simple answer, check to see if they have 50 silver...

uint32 coin = victim->GetUInt32Value(PLAYER_FIELD_COINAGE);
if(coin > 5000)
     victim->ModUnsigned32Value( PLAYER_FIELD_COINAGE, -5000 );
else
     victim->SetUInt32Value(PLAYER_FIELD_COINAGE, 0);

If they have more than 50 silver, it removes silver. If they have exactly 50 silver or less, it sets their money to 0.

Like I said, it has nothing to do with that.

It just crashes on kill...

the Victim is the problem, something wrong with the code or something.

He can't recognize the Victim?

[Gastricpenguin]

Test the script again and generate a crashdump (since it will crash).
Open the crashdump and post the CallStack, piece of code that crashed, and locals.

[gotiefan]

Microsoft (R) Windows Debugger Version 6.11.0001.404 X86
Copyright (c) Microsoft Corporation. All rights reserved.


Loading Dump File [**]
User Mini Dump File: Only registers, stack and portions of memory are available

Symbol search path is: *** Invalid ***
****************************************************************************
* Symbol loading may be unreliable without a symbol search path.           *
* Use .symfix to have the debugger choose a symbol path.                   *
* After setting your symbol path, use .reload to refresh symbol locations. *
****************************************************************************
Executable search path is: 
Windows Vista Version 6000 MP (4 procs) Free x86 compatible
Product: WinNt, suite: SingleUserTS Personal
Machine Name:
Debug session time: Tue Jul 14 15:03:12.000 2009 (GMT+2)
System Uptime: not available
Process Uptime: 0 days 0:01:15.000
.....................................................
This dump file has an exception of interest stored in it.
The stored exception information can be accessed via .ecxr.
(a14.10f0): Access violation - code c0000005 (first/second chance not available)
eax=00000237 ebx=1ec27530 ecx=1ec282a0 edx=1ec282a6 esi=1ec274f0 edi=14dbbe60
eip=779d0f34 esp=14dbbb20 ebp=14dbbb30 iopl=0         nv up ei pl zr na pe nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs=0000             efl=00000246
*** ERROR: Symbol file could not be found.  Defaulted to export symbols for ntdll.dll - 
ntdll!KiFastSystemCallRet:
779d0f34 c3              ret

victim->ModUnsigned32Value( PLAYER_FIELD_COINAGE, -5000 );

What are the locals?

[Jotox]

mm that dump doesn't help much.

The problem is most likely that you need to clean and rebuild both the core and the scripts.
Try that and see what happens

[gotiefan]

Ok, I'm compiling them again.

Edit:

No succes... still crashing :-S

[gotiefan]

I changed 2 things:

 mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, &OnPlayerKill);

To

 mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, (void*)OnPlayerKill);

And

void OnPlayerKill(Player* attacker, Player* victim)

To

void OnPlayerKill(PlayerPointer attacker, PlayerPointer victim)

And it worked..

Anyone can tell me what one made it work?

[Gastricpenguin]

It would have helped if you told us you were using Aspire...
ArcEmu scripts are NOT compatible for aspire. Aspire uses shared pointers, i.e. the PlayerPointer, GameObjectPointer, etc.

[AzolexX]

No they don't anymore, and even if they do he could not compile it.

EDIT1:

Simple answer, check to see if they have 50 silver...

uint32 coin = victim->GetUInt32Value(PLAYER_FIELD_COINAGE);
if(coin > 5000)
     victim->ModUnsigned32Value( PLAYER_FIELD_COINAGE, -5000 );
else
     victim->SetUInt32Value(PLAYER_FIELD_COINAGE, 0);

If they have more than 50 silver, it removes silver. If they have exactly 50 silver or less, it sets their money to 0.

Thats worst code i ever saw...
should be

uint32 pCoin = victim->GetUInt32Value(PLAYER_FIELD_COINAGE);

if( pCoin <= 5000 )
     victim->SetUInt32Value(PLAYER_FIELD_COINAGE, 0)
else
     victim->SetUInt32Value(PLAYER_FIELD_COINAGE, pCoin - 5000);

[Jotox]

....
There's virtually no difference azolex.
And to correct both of you, you don't need that. ModUnsigned32Value checks to make sure that the value does not go negative, by default.

[Gastricpenguin]

Lol Azolex. Nice try being a smartass.