[EPIC RELEASE] GM Stone C++

[Obsideon]

This is SICK!!! NJ!! +rep

[AngelSandy]

Be nice to recieve some rep for my hard work otherwise I might not bother releasing anything else in the future.

The users of this forum are the judges of the work you release on these forums.
No one forces you to release anything on these forums, and you were stupid to say that you had to give rep to get this specific script and stuff. It's just plain stupid.

Look at the comments and see how much +Rep you missed BECAUSE you said that!
You dug your own grave mate..

[mager1794]

Try READing my post again. I specifically said



In other words, it's even easier to modify a command to work for players, and only work on the person using it.

if you modified it, then the normal GMs wouldn't have it, this really isn't as pointless as everyone thinks depending on what kinda server it is

[The-Eradicator]

if you modified it, then the normal GMs wouldn't have it

Here's a 2 second example, of a command copied straight out of TrinityCore 2 and edited.

bool ChatHandler::HandleDieCommand(const char* /*args*/)
{
	Unit* target = NULL;

	if(m_session->GetSecurity() > SEC_PLAYER) {
		target = getSelectedUnit();
	}else{
		target = (Unit*)m_session->GetPlayer();
	}

    if(!target || !m_session->GetPlayer()->GetSelection())
    {
        SendSysMessage(LANG_SELECT_CHAR_OR_CREATURE);
        SetSentErrorMessage(true);
        return false;
    }

    if(target->GetTypeId()==TYPEID_PLAYER)
    {
        if(HasLowerSecurity((Player*)target,0,false))
            return false;
    }

    if( target->isAlive() )
    {
        //m_session->GetPlayer()->DealDamage(target, target->GetHealth(), NULL, DIRECT_DAMAGE, SPELL_SCHOOL_MASK_NORMAL, NULL, false);
        m_session->GetPlayer()->Kill(target);
    }

    return true;
}

this really isn't as pointless as everyone thinks depending on what kinda server it is

I said it was pointless in my opinion, I still think he put work into this and deserves (or, rather, would have deserved) reputation for it.

[mager1794]

entirely true The-Eradicator, and i think i originally mis-read what you said,and sorry about that

Zellcorp for future reference if you want a chance at all to get rep for something (even though you should release just for rep, do it for the communitys sake) Dont ask for rep

[Zellcorp]

how about people who can't do a core edit? you must admit is easier.

[beltic]

Zellcorp -

Thank you for contributing to the community. However, as it has been pointed out, at least 2x, you should NEVER ask for rep. since you have ignored that advise 2x, it seems to me that your only here for your own personal satisfcation, not that of helping the community.

Like many others, no rep from me either.

[Zellcorp]

be nice

[Zellcorp]

I have updated the GM Stone to Version 2 Enjoy

[Jotox]

This would be nice, however

your code is very poor,
you have sprintf's all over the place for no reason,
you don't delete query results (which causes memory leakage and eventually crashes if it's used often)
you have SQL in almost every command, whether it's even USEFUL or not.

worst of all
YOU MAKE A 50,000 ROW TABLE OF NUMBERS BECAUSE YOU DON'T KNOW HOW TO SET VALUES WITHOUT SQL?
Not only does that create MASSIVE memory leakage but it's just plain dumb.

[Jotox]

I'm sorry this is just... this is awful...

Look at this

QueryResult *rage1 = WorldDatabase.Query("Select `entry` FROM numbers where `entry` = '%s'", Code);

if(rage1)
{
Field *Fields = rage1->Fetch();
uint32 entry = Fields[0].GetUInt32();
Plr->SetUInt32Value(UNIT_FIELD_POWER2, entry);
Plr->SetUInt32Value(UNIT_FIELD_MAXPOWER2, entry);
CharacterDatabase.Execute("UPDATE characters SET current_power = %u WHERE guid = %u", entry, Plr->GetGUID());
Plr->Gossip_Complete();
}

"Select entry from numbers"?
Dude.... there are functions for this. atoi(string) converts a string to a number.

Please, before you release something else, learn some C++, and release something that won't eat up memory until your server crashes.

[Zellcorp]

Gezzz rough, if you bother to know i have been posting in here for months now asking how to make the codebox entries without the numbers table, with the only response being to use a table so I did if you can give me the code to not have to use it I would appreciate it I sure as hell didn't want to use a table when I first thought of making this item. And the Item been on my server for ages now and ive no more crashes than normal.

Also if you are as good at c++ as you say you are, you maybe be able to help me fix my ' in add item by name problem?

[Jotox]

Mm one last thing

there are sql exploits with this too :O, though luckily none for mysql

if somebody were using odbc or oracle or something, you could delete the server's database by simply searching "'; DROP TABLE `items`;--" in the item search

[Zellcorp]

total rubbish if its so possible go do it on my posted server now I have backups and you did not answer my questions so it seems you talk alot about knowing C++ but do not have the answers yourself.

[Jotox]

Mm use WorldDatabase.EscapeString( string ) to prevent SQL exploits.

And delete your queries when you're done with em

and use atoi( string ) instead of querying a database of numbers


And brb im gonna get on ur server :P