[Best solution] Wait for the detour to finish

[Corthezz]

Hello,
in my current bot I hook EndScene to get my codecave executed by the main thread.
My ASM is checking if a certain address is equal 1. If this case occurs the injected code get called and the adress will be set to 0 after execution.

Finally I can use the construction like this:

inject(asm, address) // inject code
write<uint>(codeCaveEnabled, 1) // let the code get executed
while (read<uint>codecaveEnabled == 1); //wait for execution to end

I wonder if there is any more performant way to do this? I talked with a mate a few days ago and he said using the while loop is pretty bad and referred me to Thread.WaitOne and Thread.Set however I cant figure out where the benefit is using this.

In general I am using many while loops in combinisation with timers were I need to wait a bit but dont want to sleep the thread (other thread would work and maybe take to long etc).

Thanks in advance

[Valediction]

What I'm currently doing is setting up a synchronized mechanism in the function, first to check if there is anything to execute, and then to wait for the detour to finish/retrieve retvalues. Indeed, using Wait/Notify or similar synchronization mechanisms seems the most logical approach here.

Goes like:

- Synchronized check to see if there's anything to execute
If so, do it, and use a WAIT primitive.
From the function call requested, place the return value somewhere and use a NOTIFY primitive.
- Retrieve the return value after being waked up.

(I use a generic wrapper function to set up all the synchronization/return values appropriately)

It's basically a simplified producer/consumer. I currently execute one function per tick, but if you need a higher call rate, you could set up a function queue and use a similar scheme, but calling N functions per detour hit.

The benefit is performance (and elegance), busy while-loops are typically one of the worst synchronization methods.

[danwins]

what exactly are you trying to accomplish with this code?

sounds like you would benefit from being in-process, so when your asm is called rather then just setting the variable/address and checking it you can directly call the function that needs to execute.