Avoiding Lua Errors by any price?

[Corthezz]

Hello,
right now I am working with 1.12.1. To archiev certain things I am using Framescript_Execute aswell Framescript_GetText.
When I was thinking about different steps I could take to optimize my code the following Idea came into my mind:

Lets say my bot is executing a Lua statement with Framescript_Execute and the client disconnects at the same time.
In this case WoW will most likely throw some Lua errors cause of function which are nil or better said not avaible while disconnected.

Should I try to avoid such situations by adding some code to prevent execution if not logged in with a character or is it useless effort which wont get me any benefit?

if WorldFrame ~= nil then .... end

[Bananenbrot]

Like for every other race condition, this would not be sufficient. WoW could always exit while you are within that if block.
I'd say you should try wrapping it with pcall, but that wouldn't make it any better for the same reason...

Edit: All of the above of course under the assumption that you are calling lua from another thread... If you are running lua from the main thread, both ways might be valid.

[Corthezz]

Like for every other race condition, this would not be sufficient. WoW could always exit while you are within that if block.
I'd say you should try wrapping it with pcall, but that wouldn't make it any better for the same reason...

Edit: All of the above of course under the assumption that you are calling lua from another thread... If you are running lua from the main thread, both ways might be valid.

Yep I am running Lua from the endscene but thats not my point.
Are a few lua errors affecting anything?

[ck298]

Like for every other race condition, this would not be sufficient. WoW could always exit while you are within that if block.
I'd say you should try wrapping it with pcall, but that wouldn't make it any better for the same reason...

Edit: All of the above of course under the assumption that you are calling lua from another thread... If you are running lua from the main thread, both ways might be valid.

i got main thread TEB->TLS,but there is not CurMgr.
if i will call lua from dll thread than still need update main threads TLS to dll thread?

[Bananenbrot]

Yep I am running Lua from the endscene but thats not my point.
Are a few lua errors affecting anything?

Can't say that, but if you wrap your stuff in a pcall, then no lua error will escape. IMO more elegant than littering your code with if-checks.

i got main thread TEB->TLS,but there is not CurMgr.
if i will call lua from dll thread than still need update main threads TLS to dll thread?

I'm generally doing my stuff from the main thread, so I'm not sure about this.
At least the ObjMgr address isn't saved in TLS anymore nowadays. They are using a regular global.
Ahh wait, this is 1.12, so they probably use TLS. In that case you have to copy the environment into your thread, but I really advise you to call lua only from the main thread for race (condition) reasons.

[flo8464]

Yep I am running Lua from the endscene but thats not my point.
Are a few lua errors affecting anything?

No. FrameScript_Execute uses lua_pcall to execute the buffer.
You might have to pop the error message off the lua stack but I am pretty sure FrameScript_Execute does that for you, you might want to check the disassembly.