[Question] Pet Battle Abilities

[-Ryuk-]

Hi guys,

I seem to be a bit stumped... I am trying to figure out if a Pet Battle Ability is Powerful, Weak, or just normal!

You can see what I mean by the red and green arrows in the picture below:


Does anyone know which lua function I can use to check this? I can't seem to find it.

Note: the lua function C_PetBattles.GetAttackModifier() prototype is as follows, but it does not help in my situation as I need a specific ability modifier.

C_PetBattles.GetAttackModifier(ActiveAllyPetType, ActiveEnemyPetType);

Thanks

[_Mike]

C_PetBattles.GetAttackModifier() wants the ability type, not the pet type. Blizzard's code is a bit confusing because they've named the var petType
For example,

function DumpAbilityStrengths()
   local activePetSlot = C_PetBattles.GetActivePet(LE_BATTLE_PET_ALLY)
   local enemyPetSlot = C_PetBattles.GetActivePet(LE_BATTLE_PET_ENEMY)
   local enemyType = C_PetBattles.GetPetType(LE_BATTLE_PET_ENEMY, enemyPetSlot)
   for i=1,3 do -- only need to check the first 3 buttons
      local abilityName, abilityType, noHints
      _, abilityName, _, _, _, _, abilityType, noHints = C_PetBattles.GetAbilityInfo(LE_BATTLE_PET_ALLY, activePetSlot, i)
      if(noHints) then
         print(abilityName .. " has no modifier")
      else
         local modifier = C_PetBattles.GetAttackModifier(abilityType, enemyType)
         if(modifier < 1) then
            print(abilityName .. " is weak against enemy")
         elseif(modifier > 1) then
            print(abilityName .. " is strong against enemy")
         else
            print(abilityName .. " is normal strength against enemy")
         end
      end
   end
end

[-Ryuk-]

C_PetBattles.GetAttackModifier() wants the ability type, not the pet type. Blizzard's code is a bit confusing because they've named the var petType
For example,

function DumpAbilityStrengths()
   local activePetSlot = C_PetBattles.GetActivePet(LE_BATTLE_PET_ALLY)
   local enemyPetSlot = C_PetBattles.GetActivePet(LE_BATTLE_PET_ENEMY)
   local enemyType = C_PetBattles.GetPetType(LE_BATTLE_PET_ENEMY, enemyPetSlot)
   for i=1,3 do -- only need to check the first 3 buttons
      local abilityName, abilityType, noHints
      _, abilityName, _, _, _, _, abilityType, noHints = C_PetBattles.GetAbilityInfo(LE_BATTLE_PET_ALLY, activePetSlot, i)
      if(noHints) then
         print(abilityName .. " has no modifier")
      else
         local modifier = C_PetBattles.GetAttackModifier(abilityType, enemyType)
         if(modifier < 1) then
            print(abilityName .. " is weak against enemy")
         elseif(modifier > 1) then
            print(abilityName .. " is strong against enemy")
         else
            print(abilityName .. " is normal strength against enemy")
         end
      end
   end
end

Yeah, that makes more sense now... have you noticed anything else that wrong?

Also, how do you decide which more to use, first?
What I mean is, some moves cause a debuff on the enemy which cause x2 damage on your next attack... Do you handle this?


EDIT: I am currently getting my best ability using GetAttackModifier... However this causes issues.

For Example:
Enemy = Squirrel / Critter
Ability Type = Howl / Beast

If I use GetAttackModifier in this situation it returns 1.5 however this move doesn't even cause damage it casts a debuff.