CTM Issue

[wag321]

I've just got into wow memory, and this forum is the best resource I've found, I just started a bot, and had a lot of success OOP, but have decided to try injected / memory writes. I can get simple function like CGPlayer_C::AcceptQuest to work fine but can't get CTM for the life of me.

My code atm is

        public static void CGPlayer_C__ClickToMove(float x, float y, float z, float precision = 2.5f, Int32 clickType = 0x4)
        {
            UInt32 clickPos_P = Memory.AllocateMemory(0x4 * 3);
            UInt32 interactGuid_P = Memory.AllocateMemory(0x8);

            Memory.Write<UInt64>(interactGuid_P, 0);

            Memory.Write<float>(clickPos_P, x);
            Memory.Write<float>(clickPos_P + 0x4, y);
            Memory.Write<float>(clickPos_P + 0x8, z);
            string[] asm = new string[]
            {
                "push, " + precision,
                "push, " + clickPos_P,
                "push, " + interactGuid_P,
                "push, " + clickType,
                "mov ecx, " + ObjectManager.Me.getPointer(),
                "call " + (uint)Offsets.CTM.CGPlayer_C__ClickToMove,
                "retn",
            };

            Hook.InjectAndExecute(asm);

            Memory.FreeMemory(clickPos_P);
            Memory.FreeMemory(interactGuid_P);
        }

Where CGPlayer_C__ClickToMove = 0x001B7D20

Can anyone help?
Thanks.

[JuJuBoSc]

I've just got into wow memory, and this forum is the best resource I've found, I just started a bot, and had a lot of success OOP, but have decided to try injected / memory writes. I can get simple function like CGPlayer_C::AcceptQuest to work fine but can't get CTM for the life of me.

My code atm is

        public static void CGPlayer_C__ClickToMove(float x, float y, float z, float precision = 2.5f, Int32 clickType = 0x4)
        {
            UInt32 clickPos_P = Memory.AllocateMemory(0x4 * 3);
            UInt32 interactGuid_P = Memory.AllocateMemory(0x8);

            Memory.Write<UInt64>(interactGuid_P, 0);

            Memory.Write<float>(clickPos_P, x);
            Memory.Write<float>(clickPos_P + 0x4, y);
            Memory.Write<float>(clickPos_P + 0x8, z);
            string[] asm = new string[]
            {
                "push, " + precision,
                "push, " + clickPos_P,
                "push, " + interactGuid_P,
                "push, " + clickType,
                "mov ecx, " + ObjectManager.Me.getPointer(),
                "call " + (uint)Offsets.CTM.CGPlayer_C__ClickToMove,
                "retn",
            };

            Hook.InjectAndExecute(asm);

            Memory.FreeMemory(clickPos_P);
            Memory.FreeMemory(interactGuid_P);
        }

Where CGPlayer_C__ClickToMove = 0x001B7D20

Can anyone help?
Thanks.

Add base address

[wag321]

I just came back to post that I figured it out although for a while I was doing

Offsets.CTM.CGPlayer_C__ClickToMove + Memory.BaseAddress

without casting to uint :/

Thanks though :-)

[EmilyStrange]

I just came back to post that I figured it out although for a while I was doing

Offsets.CTM.CGPlayer_C__ClickToMove + Memory.BaseAddress

without casting to uint :/

Thanks though :-)

If you embed your offsets into one class or structure, and your absolute addresses in to another class or structure, and write a utility function (or even a static class function) that will determine whether it is an offset or absolute address based on type, and adjust the address accordingly, you can avoid many of these mistakes. No more "baseAddress+someOtherAddress" sprinkled throughout your code.

A strong naming convetion of "Address" and "Offset" to distinguish the two can alleviate some of these problems too.

[wag321]

If you embed your offsets into one class or structure, and your absolute addresses in to another class or structure, and write a utility function (or even a static class function) that will determine whether it is an offset or absolute address based on type, and adjust the address accordingly, you can avoid many of these mistakes. No more "baseAddress+someOtherAddress" sprinkled throughout your code.

A strong naming convetion of "Address" and "Offset" to distinguish the two can alleviate some of these problems too.

That's a great idea, Thanks!

[EmilyStrange]

As an additional thought, and this is serious overkill, but was done on a completely unrelated project to hacking Warcraft, you can create a custom attribute which decorates the address/offset class or structure to ensure that anytime you use the class or structure data members the compiler will generate an error if you do not either a) explicitly add the base address of the game client to the used data member or b) decorate the line of code using the data member with an attribute that acknowledges the use of the data member in an unedited form. Probably more work than you actually want to do, or is even worth doing, but doable nonetheless.

[wag321]

That's an interesting thought though, what is this called so I can look it up?