[Help] TraceLine crashes Wow

[unbekannter2]

Hello,
i just implemented Traceline(CGWorldFrame__Intersect) into my Gatherbot. But everytime i call the function wow crashes. I am calling it from an EndScene hook which works well. Also Framescript_Execute is working with no problems. I cant find the mistake in my code.
Here are some snippets :

[UnmanagedFunctionPointer(CallingConvention.Cdecl)]
private delegate byte TracelineDelegate(ref wowPoint end, ref wowPoint start, ref wowPoint result, ref float distance, uint flags, ref uint Optional);
private static TracelineDelegate WoWTraceLine;

WoWTraceLine = m.RegisterDelegate<TracelineDelegate>(wowGatherMainClass.wowBase + 0x289790);

private static byte LineOfSight(wowPoint pStart, wowPoint pEnd)
{
wowPoint start = pStart;
wowPoint end = pEnd;
wowPoint result;
result.x = 0f;
result.y = 0f;
result.z = 0f;
float distance = 1.0f;
uint dummy = 0;
return WoWTraceLine(ref end, ref start, ref result, ref distance, 0x100011, ref dummy);
}

Hope somebody can help me

[jjaa]

crash dump?

[unbekannter2]

ERROR #132 (0x85100084) Fatal Exception
Program:	D:\World of Warcraft\World of Warcraft\WoW.exe
Exception:	0xC0000005 (ACCESS_VIOLATION) at 0023:431A851A

The instruction at "0x431A851A" referenced memory at "0x431A851A".
The memory could not be "read".

For testing i started calling the function every 100th frame. Seems to work 5-10 times and then crashes.

[jjaa]

Well the only difference i can see between your code and mine, is that i pass the last pram by value, not reference. Also, a crash dump like that does not help without knowing the location of wow module. If you know the base you can check to see were the exception is being thrown (if its in the wow module).

[unbekannter2]

Really crazy, but passing the last parameter by value not ref makes it work 100%!!!

Thank you very much jjaa

[amadmonk]

That surprises you? When you marshal data wrong, bad things happen.

BTW, TraceLine itself is incredibly stable; I call it nearly every frame for hours on end with no stability issues.

[4b2]

Hey folks, first of all i have to say I HATE C#. lol

I am trying to call Tracline from out of process.
I'm creating a Remotethread which calls traceline.
Works properly well, but after some time its crashing.
After some debugging i thought, that the error came due to some parallel calls from the engine. So i hooked traceline and checked for this( i got the same error in my cod hacks, i wanted to call some engine funcs from d3d. solved it with some thread interlock stuff. )

I still get this referenced memory shit error. I dont know the actual function offset. but it was a function which is called by traceline.

I am fkn disappointed. May some of you knows why this happens.

Here is some code from my call(executed in remotethread):

            byte[] functionbytes = { 0x56,                   //push    esi
                                     0x8B, 0x74, 0x24, 0x08, //mov     esi, [esp+8]
                                     0x8B,0x4E,0x28,         //mov     ecx, [esi+28h]
                                     0x8B, 0x46, 0x30,       //mov     eax, [esi+30h]
                                     0x6A, 0x00,             //push    0
                                     0x51,                   //push    ecx
                                     0x8D, 0x56, 0x24,       //lea     edx, [esi+24h]
                                     0x52,                   //push    edx
                                     0x8D,0x4E,0x18,         //lea     ecx, [esi+18h]
                                     0x51,                   //push    ecx
                                     0x8D, 0x56, 0x0C,       //lea     edx, [esi+0Ch]
                                     0x52,                   //push    edx
                                     0x56,                   //push    esi
                                     0xFF, 0xD0,             //call    eax
                                     0x0F, 0xB6, 0xC0,       //movzx   eax, al
                                     0x89, 0x46, 0x34,       //mov     [esi+34h], eax
                                     0xB8, 0x01, 0x00, 0x00, 0x00, // mov     eax, 1
                                     0x5E,                   //pop     esi
                                     0x83, 0xC4, 0x18,       //add     esp, 18h
                                     0xC2, 0x04, 0x00        //retn    4
            };  

Struct:
D3DXVECTOR3 pos1;
D3DXVECTOR3 pos2;
D3DXVECTOR3 pos3;
float distance;
unsigned int flags;
DWORD zero;
DWORD dwWorldframeIntersect;