.NET MpqLib updated for Cataclysm

[caytchen]

Original version can be found at MpqLib
As required by GPL v3, I'm releasing the code including the changes I've made to it. Also included are the StormLib libraries needed (MPQ Archives - StormLib) and binaries.

Note: This isn't a "complete" update; I've merely fixed some API breakage, not implemented new features. I have verified this to successfully read files from 4.0.1.13205 MPQ archives.

Filebeam - Beam up that File Scottie!

[st0724]

Thanks for the build. I was actually just building this with the new StormLib as well =D

[miceiken]

I'm sorry to necrobump this. Is anyone else using MpqLib? How do you deal with StormLib opening files with exclusive read access?

[namreeb]

Well personally, I modified StormLib.

[Bananenbrot]

I'm using crystalmpq - Library and set of tools for reading data from MPQ (MoPaQ) files - Google Project Hosting .
Not sure, if patching works as expected, though.

[miceiken]

Well personally, I modified StormLib.

Care to explain how? Not really that good with C++ - I nailed it down to the CreateFile wrapper, but I have no idea what flags I should and shouldn't be using. Was looking into http://msdn.microsoft.com/en-us/libr...(v=vs.85).aspx but still can't tell why it won't let me open it while WoW uses them as well.

I'm using crystalmpq - Library and set of tools for reading data from MPQ (MoPaQ) files - Google Project Hosting .
Not sure, if patching works as expected, though.

Nice... I'll look into this.

[Frosttall]

Care to explain how? Not really that good with C++ - I nailed it down to the CreateFile wrapper, but I have no idea what flags I should and shouldn't be using. Was looking into CreateFile function but still can't tell why it won't let me open it while WoW uses them as well.

Well as far as I know is there no way to open them as long as WoW is opened. The MPQ files are locked since Cataclysm and in my opinion is there no real need to open them while WoW is opened. Just close it or copy the files

[miceiken]

Well as far as I know is there no way to open them as long as WoW is opened. The MPQ files are locked since Cataclysm and in my opinion is there no real need to open them while WoW is opened. Just close it or copy the files

I need them for the minimap files. Suppose I could use WoW's internal functions but I have the feeling this will go smoother. And yes, it's possible to open them while WoW is open, how else would you be able to run multiple instances of WoW?

[Frosttall]

I need them for the minimap files. Suppose I could use WoW's internal functions but I have the feeling this will go smoother. And yes, it's possible to open them while WoW is open, how else would you be able to run multiple instances of WoW?

Well why don't you just extract them and pass them to the user inside a dll?

And yes, there's always a way, but the Windows API blocks it if you try to open a locked file. I can't tell you which way Blizzard is using, but the StormLib and librarys like this don't support it.


I recomment you to use the dll-way and stop breaking your head on that topic

[miceiken]

Well why don't you just extract them and pass them to the user inside a dll?

And yes, there's always a way, but the Windows API blocks it if you try to open a locked file. I can't tell you which way Blizzard is using, but the StormLib and librarys like this don't support it.


I recomment you to use the dll-way and stop breaking your head on that topic

Why do you keep suggesting a solution that is out of the question? I KNOW it's possible, and extracting the data is just retarded when the data already is there.

[Frosttall]

Why do you keep suggesting a solution that is out of the question? I KNOW it's possible, and extracting the data is just retarded when the data already is there.

Because it's it regard of performance much more worse. You would have to open ~10 MPQs and in general are IO-Actions not the fastest, but reading a single is much faster.

But okay, I'll leave you alone with you problem, if you want to FORCE such exactly that solution. I just told you a workaround...

[Sacred]

I need them for the minimap files. Suppose I could use WoW's internal functions but I have the feeling this will go smoother. And yes, it's possible to open them while WoW is open, how else would you be able to run multiple instances of WoW?

Yes it's possible and i'm using CrystalMpq, there's no need to open 10 MPQ archives, you just need to open one - art.MPQ, this is how i'm doing:

public class Mpq
{
        private static BlpLib.BlpFile _exampleBlp;
        private static readonly MpqArchive Archive = new MpqArchive(Helpers.WowInstallPath + "\\Data\\art.MPQ", false);
        private static MpqFile _file;
        private static MpqFileStream _stream;
        public static readonly Dictionary<string, Image> Images = new Dictionary<string, Image>();

        public static Image GetImage(string mapName, string continent)
        {
            try
            {
                string str = "World\\Minimaps\\" + continent + "\\" + mapName;
                if (!Images.ContainsKey(str))
                {
                      _file = Archive.FindFile(str);
                      _stream = _file.Open();
                      _exampleBlp = new BlpLib.BlpFile(_stream);
                       var bmp = _exampleBlp.GetBitmap(0);
                       Images.Add(str, bmp);
                      _stream.Close();
                      _exampleBlp.Close();

                }
                return Images[str];
            }
            catch
            {
            }
            return null;
        }
}

Using:

Image minimap = Mpq.GetImage("map31_31.blp", "Azeroth");

[miceiken]

Still looking for a solution with StormLib, as it's incorporated into my framework.

[_Mike]

Still looking for a solution with StormLib, as it's incorporated into my framework.

In FileStream.cpp, change the CreateFile call in BaseFile_Open() to use
FILE_SHARE_READ | FILE_SHARE_WRITE
for the share flags. And then call SFileOpenArchive() with STREAM_FLAG_READ_ONLY.

If you want write access you also need to change

DWORD dwDesiredAccess = (dwStreamFlags & STREAM_FLAG_READ_ONLY) ? GENERIC_READ : GENERIC_ALL;

to

DWORD dwDesiredAccess = (dwStreamFlags & STREAM_FLAG_READ_ONLY) ? GENERIC_READ : GENERIC_READ | GENERIC_WRITE;

but wow doesn't react very well if you write to the mpqs while they are opened And iirc you can't use patch archives unless you open the base as read only anyways.

Since it's just a change to the flags you could even do a simple binary patch if you don't feel like recompiling the whole thing.

[miceiken]

Sweet, just what I was looking for. Thank you very much,