[Question] CGObject_SetFacing

[Azzie2k8]

Hi,
first off I know there are couple of Threads that concern facing but none do really touch this or even solve this issue so I hope I am not breaking the rules(Yes, I read them ).
Currently I am trying to set my facing on the current target with the help of CGObject_SetFacing. My Problem is that it has no effect when I call it. No Exceptions, no crashs, no changes in WoW. I am sick of it now and want to see if you guys maybe know whats wrong.

I am using Apoc's WhiteMagic and managed injection. Thanks to Robske007a for showing/helping me with everything.


Here is how I try to call the function.

        [UnmanagedFunctionPointer(CallingConvention.ThisCall)]
        public delegate void CGObject_C__SetFacing(IntPtr __This, float Angle);
        private static Hooks.CGObject_C__SetFacing _SetFacing;

        public float Rotation
        {
            get { return Bot.Memory.Read<float>(((uint)ObjPtr + 0x7A8)); }

            set
            {
                try
                {
                    if (_SetFacing == null)
                    {
                        _SetFacing = Bot.Memory.RegisterDelegate<Hooks.CGObject_C__SetFacing>(Statics.CGObject_SetFacing);
                    }
                    if (ObjPtr == IntPtr.Zero)
                        throw new NullReferenceException("SetFacing invoked on an invalid Object");
                    _SetFacing(this, value);
                }
                catch (Exception Ex)
                {
                    Log.ShowException(Ex);
                }
            }
        }

Here is the rest that sets the facing

        public static void FaceTarget()
        {
            if (Bot.Me.TargetGuid != 0)
            {
                Bot.Target = (WoWUnit)ObjectManager.GetObjectByGuid(Bot.Me.TargetGuid);
                // Calculate Facing

                float DistanceY = Bot.Me.WowPoint.X - Bot.Target.WowPoint.X;
                float DistanceX = Bot.Me.WowPoint.Y - Bot.Target.WowPoint.Y;

                //Note that wow uses X Y different to the normal math !

                double ATan = Math.Abs(Math.Atan(DistanceX / DistanceY));

                double TotalShouldFace = 0;

                if (DistanceX < 0)
                {
                    if (DistanceY > 0)
                    {
                        TotalShouldFace = (2 * Math.PI) - ATan;
                    }
                    else
                    {
                        TotalShouldFace = ATan;
                    }
                }
                else
                {
                    if (DistanceY > 0)
                    {
                        TotalShouldFace = Math.PI + ATan;
                    }
                    else
                    {
                        TotalShouldFace = Math.PI - ATan;
                    }
                }
                Bot.Me.Rotation = (float)TotalShouldFace;
            }
        }

Any Information is welcome

[caytchen]

First of all, It would be helpful to know what SetFacing you exactly use. Everybody seems to use a different one around here.

On the other hand, you're calling it wrong.

_SetFacing(this, value);

You're passing this, which is an object of the wrapper class you built around the real class. You need to pass ObjPtr as this. (I'm just dazzled how you managed to compile that)

[Azzie2k8]

First of all, It would be helpful to know what SetFacing you exactly use. Everybody seems to use a different one around here.

Thanks for the reply. I am using this CGObject_SetFacing = 0x007EB5C0; function.

On the other hand, you're calling it wrong.

You're passing this, which is an object of the wrapper class you built around the real class. You need to pass ObjPtr as this. (I'm just dazzled how you managed to compile that)

Since I am using Apoc's Object Manager I am actually able to pass it this way.

    public class WoWObject
    {
        internal WoWObject(IntPtr objPtr)
        {
            ObjPtr = objPtr;
        }

        public static implicit operator IntPtr(WoWObject obj)
        {
            // Allows us to implicitly cast a WoWObject to an IntPtr (objBase)
            return obj.ObjPtr;
        }
    }

[MaiN]

First of all, It would be helpful to know what SetFacing you exactly use. Everybody seems to use a different one around here.

On the other hand, you're calling it wrong.



You're passing this, which is an object of the wrapper class you built around the real class. You need to pass ObjPtr as this. (I'm just dazzled how you managed to compile that)

It probably implicitly casts to IntPtr.

If you're using the SetFacing function I think you're using, you need to pass *(this + 0xD, not 'this'. this + 0xD8 has a pointer to the movement struct.

[adaephon]

Implicit operators. Presumably his object structure is based around some code Apoc posted (and what is most likely a fairly common pattern with the C# devs writing bots here) that includes something along the lines of:

class WoWObject {
    ...
    public static implicit operator IntPtr(WoWObject obj) {
        return obj.ObjPtr; // or something similar
    }
}

..edit.. and dammit, beaten again :P

[Azzie2k8]

It probably implicitly casts to IntPtr.

True

If you're using the SetFacing function I think you're using, you need to pass *(this + 0xD, not 'this'. this + 0xD8 has a pointer to the movement struct.

Cannot confirm that but thanks for the hint. I tried but it didn't help besides causing an access violation.

[MaiN]

Then tell us what the address of your "CGObject__SetFacing" function is.
Also, your math is very ****ed up. All you have to do is basically:

float requiredFacing = (float)Math.Atan2(faceTarget.Y - me.Y, faceTarget.X - me.X);

[Azzie2k8]

Then tell us what the address of your "CGObject__SetFacing" function is.
Also, your math is very ****ed up. All you have to do is basically:

float requiredFacing = (float)Math.Atan2(faceTarget.Y - me.Y, faceTarget.X - me.X);

I already did in the third post

Thanks for the reply. I am using this CGObject_SetFacing = 0x007EB5C0; function.

Thanks for the stuff with the math. I didnt know about atan2 yet. I know that may be a sign of stupidity or something but now I know, thanks.

[MaiN]

Try the function at 0x7EB570 with *(this + 0xD as 'this'.

[Azzie2k8]

Try the function at 0x7EB570 with *(this + 0xD as 'this'.

Just so I get this right. You want to me to call it this way ?

_SetFacing((IntPtr)((uint)this.ObjPtr + (uint)0xD8), value);

because this is causing an exception

Exception:
Attempted to read or write protected memory. This is often an indication that other memory is corrupt.

StackTrace:
at Framework.Hooks.CGObject_C__SetFacing.Invoke(IntPtr __This, Single Angle)
at Framework.WoWUnit.set_Rotation(Single value)

maybe I misunderstood you...

[MaiN]

Just so I get this right. You want to me to call it this way ?

_SetFacing((IntPtr)((uint)this.ObjPtr + (uint)0xD8), value);

because this is causing an exception



maybe I misunderstood you...

You did, you are not dereferencing the pointer.
*(IntPtr*)((uint)this.ObjPtr + (uint)0xD

[Azzie2k8]

You did, you are not dereferencing the pointer.
*(IntPtr*)((uint)this.ObjPtr + (uint)0xD

Seems like it is working although I dont get why the first approach didnt work. Anyways thank you very much... +Rep