Fishing Bot in Java Help

[Neverdie00]

Hello MMowned!

Recently I decided to try teaching myself Java and made a goal that I would try to make a fishing bot. This I quickly learned can be very dificult for someone just learning the language.

I was wondering if I could get some feedback on the concept I am using in order to search for a pixel of a certain color (in this case it is white). Also, the code compiles and runs but never encounters a white pixel, I cant figure this one out because there are tons of white pixels on my screen!

Any comments, critisicm, feedback or concerns are all welcome!

package fishingbot;

import java.awt.*;
import java.awt.event.*;

public class FishingScanner {

    public static void main(String[] args) 
                      throws AWTException{
        
        int R = 255; int x = 0;
        int G = 255; int y = 0;
        int B = 255;
        
        Robot roboCop = new Robot();
        Color C = roboCop.getPixelColor(x, y);
        if ((C.getRed()==R) && (C.getGreen()==G) && (C.getBlue()==B)){ 
        
            System.out.println("White pixel found. " + x + y);
            
        }else{
       
            if (x == 1280){ //Thats how big my screen resolution is.
                x=0;
                y++;
                C = roboCop.getPixelColor(x, y);
            }else{
                x++;
                C = roboCop.getPixelColor(x, y);
            }
        }
        
        
        
        
       
    }

    }

Thanks to the people in this thread for filling my head with ideas
http://www.mmowned.com/forums/progra...bot-class.html

On a side note I read the the rules section but the link Apoc provides appears to be broken, I apoligize in advance if I have broken any.

[Viano]

So where is the loop going through all your pixels on your screen?

[Neverdie00]

The logic that I am trying to implement works like this.

1. Identify the pixel color of pixel x,y (x = 0, y =0)
2. Check to see if the selected pixel meets the RGB codes for the color white.
3. If it does not, it checks to see if integer "x" is == 1280

3a. TRUE: Return x to other side of screen by setting it to 0 and go up a pixel row by incrementing y, Goto Step 1

3b. FALSE: If x hasnt reached the other side of the screen then keep on going Goto Step 1

I realize that what I have explained may not be indicative of what is written in the code. However from what I see (keep in mind that I picked up a book on java two weeks ago) that is what is represented in the code.

I intend on adding some more code that checks to see if x == 1280 and y == 1024 in which case it would end the loop and say something like "pixel not found".

Thanks a million for your quick response Viano!

[Neverdie00]

I reread the section in my book about the "if" statement and now I feel like a tool : /

I now realize that the "if" statement does not act like a loop :P. While I may have learnt something new, it now leaves me to ponder how to make the loop. What my current train of thought is picturing is a while loop that evaluates true until x == 1280 and y == 1240 which kills too birds with one stone!

Amazing what a third party perspective can bring to a project however simple it may be (thanks again Viano, it may not look like it but your post led me to the right direction).

[Robske]

You might want to learn to program (and I'm not talking about a language's syntax) prior to writing a bot of any kind.

It will save yourself (and us) a severe headache.

[!@^^@!]

The for Statement (The Java™ Tutorials > Learning the Java Language > Language Basics) that's what you'll need

[Neverdie00]

Robske - I'm all for saving the world from a bad headache Are there any resources you would recommend?

!@^^@! - Nifty

[!@^^@!]

I'm feeling nice today so here's some code for ya

Robot roboCop = new Robot();
for(int x = 0; x < ScreenX; x++) //ScreenX is the width of your screen
{
        for(int y = 0; y < ScreenY; y++) //ScreenY is the hight of your screen
        { 
             Color C = roboCop.getPixelColor(x, y);
              if ((C.getRed()==R) && (C.getGreen()==G) && (C.getBlue()==B))
             { 
                     System.out.println("White pixel found. " + x + y);
              }
         }
    }
}

[Neverdie00]

EDIT: Thanks a billion !@^^@! for the source code but its so unsatisfying just ripping it off.
I got it working my own way!

while (x < 1441 && y < 901){
        if ((C.getRed()==R) && (C.getGreen()==G) && (C.getBlue()==B)){

            System.out.println("White pixel found. " + x + ", " + y);
        }
            if (x == 1440){             //Thats how big my screen resolution is.
                x=0;                    //Send x back to left side
                y++;                    //Go up a row
                C = roboCop.getPixelColor(x, y);
            }else{
                x++;
                C = roboCop.getPixelColor(x, y);
            }
        
        }

Victory is sweet!

White pixel found. 1286, 46
White pixel found. 1287, 46
White pixel found. 1288, 46
White pixel found. 1289, 46
White pixel found. 1290, 46
White pixel found. 1291, 46
White pixel found. 1292, 46
White pixel found. 1293, 46
White pixel found. 1294, 46
White pixel found. 1295, 46
White pixel found. 1296, 46
White pixel found. 1297, 46
White pixel found. 1298, 46
White pixel found. 1299, 46
White pixel found. 1300, 46
White pixel found. 1301, 46
White pixel found. 1302, 46
White pixel found. 1303, 46
White pixel found. 1304, 46
White pixel found. 1305, 46
White pixel found. 1306, 46
White pixel found. 1307, 46
White pixel found. 1308, 46