Reading and writing strings

[miceiken]

So last night I decided to change from BlackMagic to Apoc's memory reading sample (http://www.mmowned.com/forums/wow-me...s-botting.html) - I have however, stumble up on a problem on both reading and writing strings.

While reading strings I use the default function:

if (typeof(T) == typeof(string))
{
    ret = Marshal.PtrToStringAnsi(new IntPtr(address));
    //Log.Output("Read<string>({0:X}): {1}", address, (T)ret);
    return (T)ret;
}

This however gives me in most cases a blank result and in some cases some random nonsenseness. Please note that the offsets I use worked fine while using the BlackMagic library and they dont work now.

For writing there isn't a default function so I've tried to make my own (two actually), with no success:

if (typeof(T) == typeof(string))
{
    string encode = (string)val;
    ASCIIEncoding encoding = new ASCIIEncoding();
    bytes = encoding.GetBytes(encode);
    return Native.WriteBytes(address, bytes) == bytes.Length;
}

and

if (typeof(T) == typeof(string))
{
    IntPtr lpBuffer = IntPtr.Zero;
    lpBuffer = Marshal.StringToHGlobalAnsi((string)val);
    Marshal.WriteIntPtr(new IntPtr(address), lpBuffer);
    return lpBuffer != IntPtr.Zero;
}

[Jens]

You are probsably trying to do this out of process? as that is what BlackMagic does, Apocs WhiteMagic however, you need to have injected, So you are probably just reading / writing to your own process with the Marshal

[miceiken]

This isn't the WhiteMagic library as the description suggests (link to post above), if he makes an "out-of-process" example, weird thing he includes in process stuff...

[adaephon]

His OOP example still had remnants of his in-process code, including Marshal.ReadIntPtr stuff. For the reading, Marshal.PtrToStringAnsi(someAddress) will try to read an Ansi string from someAddress in your process space. So if someAddress is an address in WoW's process, you will understandably get gibberish, nothing, or access violation exceptions. You need to use ReadProcessMemory to read the bytes from WoW's memory. You can then convert the byte array to a string using the Encoding class.

Same for writing. Anything involving Marshal is working within your own process space, so unless that process space is the same as WoW's (i.e. you're injected) it won't work. For writing you want WriteProcessMemory

[miceiken]

Oh ok, I'll try when I get home

[misz]

So last night I decided to change from BlackMagic to Apoc's memory reading sample (http://www.mmowned.com/forums/wow-me...s-botting.html) - I have however, stumble up on a problem on both reading and writing strings.

While reading strings I use the default function:

if (typeof(T) == typeof(string))
{
  ret = Marshal.PtrToStringAnsi(new IntPtr(address));
  //Log.Output("Read<string>({0:X}): {1}", address, (T)ret);
  return (T)ret;
}

This however gives me in most cases a blank result and in some cases some random nonsenseness. Please note that the offsets I use worked fine while using the BlackMagic library and they dont work now.

For writing there isn't a default function so I've tried to make my own (two actually), with no success:

if (typeof(T) == typeof(string))
{
  string encode = (string)val;
  ASCIIEncoding encoding = new ASCIIEncoding();
  bytes = encoding.GetBytes(encode);
  return Native.WriteBytes(address, bytes) == bytes.Length;
}

and

if (typeof(T) == typeof(string))
{
  IntPtr lpBuffer = IntPtr.Zero;
  lpBuffer = Marshal.StringToHGlobalAnsi((string)val);
  Marshal.WriteIntPtr(new IntPtr(address), lpBuffer);
  return lpBuffer != IntPtr.Zero;
}

Little tip for you, you can use the "is" keywork instead of using typeof.
ex:

if (T is string)
{

[XTZGZoReX]

Little tip for you, you can use the "is" keywork instead of using typeof.
ex:

False. Only on variables; not generic type parameters.

[Apoc]

Little tip for you, you can use the "is" keywork instead of using typeof.
ex:

if (T is string)
{

Little tip for you: You can't use the 'is' keyword on a generic type parameter. You have to use if (typeof(T) == typeof(string)).

[SinnerG]

if (VARIABLE is string) seems to work for me though (vs200

[Cypher]

if (VARIABLE is string) seems to work for me though (vs200

No shit. (See below)

False. Only on variables; not generic type parameters.