EnumVisibleObjects problem

[draco1219]

If you're in process, why not make it static? It's not like you can have multiple instances of the game's object manager.

You are definitely right, I just don't understand why it calls it once then crashes with absolutely no error message or error dump.

I'll re-design my classes to be all static, but I don't understand why if all my delegates and methods are static it calls it once then closes the client.

[amadmonk]

When you're exiting and entering the runtime (like you would be with an EndScene hook), statics can get very, very interesting if you have multiple AppDomains. I don't know if that's how your code is architected (although it's pretty common), but I figured I'd save you some time.

If you DO use more than one AppDomain, just be aware that you really can't rely upon statics to be initialized unless you use msclr::call_in_appdomain. I've been bitten by this bug a few times.

[draco1219]

When you're exiting and entering the runtime (like you would be with an EndScene hook), statics can get very, very interesting if you have multiple AppDomains. I don't know if that's how your code is architected (although it's pretty common), but I figured I'd save you some time.

If you DO use more than one AppDomain, just be aware that you really can't rely upon statics to be initialized unless you use msclr::call_in_appdomain. I've been bitten by this bug a few times.

Thanks for your response amadmonk

I only create one AppDomain in my domain manager prior to loading up and instantiating my bot.

Just for the heck of it I downloaded cleanCore to see how they do it and their delegates and calling structure is almost identical to mine. I marked my EndScene and EnumVisibleObjectsCallback methods static and I still have the same problem.

The only difference I found is that my classes themselves are not static. I can't see how this would be an issue (since the methods themselves are static) but I am going to rework it a little bit to make the entire class static.

I'll look into msclr::call_in_appdomain some more as I have never heard of it before.

Have a good weekend!

[MaiN]

Thanks for your response amadmonk

I only create one AppDomain in my domain manager prior to loading up and instantiating my bot.

Just for the heck of it I downloaded cleanCore to see how they do it and their delegates and calling structure is almost identical to mine. I marked my EndScene and EnumVisibleObjectsCallback methods static and I still have the same problem.

The only difference I found is that my classes themselves are not static. I can't see how this would be an issue (since the methods themselves are static) but I am going to rework it a little bit to make the entire class static.

I'll look into msclr::call_in_appdomain some more as I have never heard of it before.

Have a good weekend!

Static classes is syntactic sugar by the C# compiler. It won't change anything.
Maybe your delegate signature/calling convention is wrong?

[draco1219]

Static classes is syntactic sugar by the C# compiler. It won't change anything.
Maybe your delegate signature/calling convention is wrong?

I agree, I made the entire library static since it made sense... but even after doing that it still has the issue.

As far as I can tell cleanCore is doing it the same way, the only difference now is that I am using an offset directly instead of finding the pattern.. maybe the offset is wrong?


Here's a little code, maybe something stands out to you. The EndScene is hooked properly and gets called and freezes the client when I put a breakpoint on it so I know it's being called from the main thread.

Thanks again!

        [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
        private delegate uint EnumVisibleObjectsDelegate(IntPtr callback, int filter);
        private static EnumVisibleObjectsDelegate WoWFunction_enumVisibleObjects;

        [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
        private delegate int EnumVisibleObjectsCallBackDelegate(ulong guid, uint filter);
        private static EnumVisibleObjectsCallBackDelegate _ourEnumVisibleObjectsCallBack;
        private static IntPtr _ourEnumVisibleObjectsCallBackPtr;


            // Initialize Object Manager Functions.
            uint enumVisibleObjectsOffset = 0x4962F0;
            WoWFunction_enumVisibleObjects = Memory.RegisterDelegate<EnumVisibleObjectsDelegate>((uint)Memory.MainModule.BaseAddress + enumVisibleObjectsOffset);
            _ourEnumVisibleObjectsCallBack = EnumVisibleObjectsCallBack;
            _ourEnumVisibleObjectsCallBackPtr = Marshal.GetFunctionPointerForDelegate(_ourEnumVisibleObjectsCallBack);


        private static int EndSceneHook(IntPtr device)
        {
            lock (_frameLock)
            {
                 WoWFunction_enumVisibleObjects(_ourEnumVisibleObjectsCallBackPtr, 0);
            }

            return (int)_endSceneHook.CallOriginal(device);
        }

        private static int EnumVisibleObjectsCallBack(ulong guid, uint filter)
        {  
            return 1;
        }

[MaiN]

That offset is wrong for both 13329 and 13596.

[jjaa]

You do realize that offset is based at 0x400000 and not 0 right? unless you have ASLR disabled that will be a problem.

[draco1219]

You do realize that offset is based at 0x400000 and not 0 right? unless you have ASLR disabled that will be a problem.

Thanks that worked!!