Fatal Exception / Unknown Exception

[Viano]

Hello there,

I've run into a strange problem. My applications injects via EasyHook and hooks EndScene via Apoc's WhiteMagic. I open a separated thread for the GUI. As soon as I close the GUI all hooks are removed in Form_Closing() via WhiteMagic.Detours.RemoveAll(). The code for EndScene is as follows.

public static EndScene() 
{
// nothing else here
ObjectManager.Instance.Pulse();
CallOriginalEndScene();
}

Any ideas what the reason might be for WoW crashing after the window form is closed with fatal exception/unknown exception?

If I comment out ObjectManager.Instance.Pulse() WoW is not crashing anymore.

I mean if EndScene is unhooked what can possibly go wrong in WoW's process?

[amadmonk]

Race condition?

[Viano]

Yes, maybe. But why if I am not changing data from other threads. It is EndScene that executes everything.

[amadmonk]

Consider what happens if your EndScene hook code becomes invalid before you remove the hook: WoW might start running (or BE running) the hook at the same time, and crash.

Without seeing your code it's just a SWAG, but in my experience most "unload" type crashes boil down to some race condition or another.

Edit: well, if they're not just something dumb like forgetting to remove a hook or something. But I'm assuming that that's not what's happening here, since that would be boring

[MaiN]

I simply set a bool in my EndScene class that indicates it should shut down at the next frame. Then at the frame, it first calls the original end scene and stores the return value - then it disposes some objects and removes the detour. Finally it returns the stored return value.