[Question][Java] Setting terms for a walk function

[kmJeepers]

Hi everyone!

Well, I managed to build a programm in java that can read offsets properly out of wow... So i tried to code a walkTo() function...
Out of other guids on this board, i managed to do all the math their is to do to calculate the angles to the destination waypoint. I have got 2 variables,
"l" and "r", that show how much the player has to turn to the right or to the left to face the destination Waypoint.
Now, i used the java robot class to send keyactions to the wow window... the player should turn as long as "l" is smaller than "r" to turn left,
and to turn as long as "l" is bigger than "r" to turn right.
Well, at all this works, but it is too imprecise. If the player only has to turn a very small amount of degrees to the destination, the programm turns too much (or too long)...
if i set the delay between the keypress and the keyrelease too short, the player doesn't turn at all, and if i set is too long, it is to imprecise as described before... well i tried using several threads to do the check parallel to turning, but it doesn't work for some reason...
Any suggestions on this?

greets kmJeepers (i hope you dont mind my bad english)



for better understanding my source code(This is an Alterac bot, too ...dont mind that^^):

http://www.mediafire.com/file/ezkljlkctgz/JBot.zip
VirusTotal: http://************/ygjrute

[dna001]

Well, turning like this will ever be less precise than other way (like memory writing, SetFacing or using the CTM function ...) but maybe can you start by posting your turning code, there is maybe something wrong with it.

Sorry but I'm too lazy to download this bot, find the right class...

[kmJeepers]

okay here's my code ;D

The goto function:

public void goTo(double x2,double y2)
{
if (calcangleL(x2,y2) < calcangleR(x2,y2))
	{
		while(calcangleL(x2,y2)<calcangleR(x2,y2))
		{
			robot2.keyPress(KeyEvent.VK_A);
			robot2.delay(25);
			robot2.keyRelease(KeyEvent.VK_A);
		}

	}
	
		
	
	
if (calcangleL(x2,y2) > calcangleR(x2,y2))
	{
		
		
		while(calcangleL(x2,y2)>calcangleR(x2,y2))
		{
			
			robot2.keyPress(KeyEvent.VK_D);
			robot2.delay(25);
			robot2.keyRelease(KeyEvent.VK_D);
		}
	}
}

The calcangleL function:

 	public static float calcangleL(double x2,double y2) throws NativeException, IllegalAccessException
 	{

 		float x=Get_FLOAT.getData(pBasePointer + 0x798);
 		float y=Get_FLOAT.getData(pBasePointer + 0x79C);
 		float l;
 		 
 		float f = (float)Math.atan2(y2 - y, x2 - x);
 		
 		if(f<0)
 		 {
 			 f=(float) (f+Math.PI * 2);
 		 }
 		if (Get_FLOAT.getData(pBasePointer + 0x7E0) > f)
 		{
 		  
 		   l = (float) (((2 * Math.PI) - G  Get_FLOAT.getDatapBasePointer + 0x7E0)) + f);
 		
 		}
 		else
 		{
 		  l = f - Get_FLOAT.getData(pBasePointer + 0x7E0);
 		}
 		return l;
 	}

The calcangleR function:

public static float calcangleR(double x2,double y2)
{
 		float x=Get_FLOAT.getData(pBasePointer + 0x798);
 		float y=Get_FLOAT.getData(pBasePointer + 0x79C);
 		float f = (float)Math.atan2(y2 - y, x2 - x);
 		if(f<0)
		 {
			 f=(float) (f+Math.PI * 2);
		 }
 		
 		float r;
 		
 		if (Get_FLOAT.getData(pBasePointer + 0x7E0) > f)
 		{
 		  r = Get_FLOAT.getData(pBasePointer + 0x7E0) - f;
 		}
 		else
 		{
 		  r = (float) (Get_FLOAT.getData(pBasePointer + 0x7E0) + ((2 * Math.PI) - f));
 		}
 		
 		return r;
 	}

hoping that helps ;D

[dna001]

Well I think your code isn't really good.

I never try this way to turn so I don't really know, but maybe thoses links will help you :



Movement Shynd’s WoW Modification Journal

With the example :

http://go2.wordpress.com/?id=725X134...TestWalkTo.rar

Cheers, hoping this will help !

EDIT: Maybe your sending to faster keyevents to the client, you can try to wait a little moment after sending a key !

[Ellesar1]

since the turning speed is constant, you could calculate how long you have to press the key. if you want to turn just a little bit (like 1 ms) to the left, since it bugs with short delay, just go 25 ms to the right and 26 ms to the left

[mnbvc]

2 things:
turn only as long as the difference from your actual angle to your target angle is >0.2r
turn only if you are >5 yards away from your target

your movement wont be so precise, but i experienced that this is no problem, and this will result in a quite smooth movement

[kmJeepers]

@dna001: exactly that is my code XD I used the page as a guideline ;P
@Ellesar1: sounds interesting, will check that out...
@mnbvc: nice ty ;D

are there some peolpe who have very different methods in mind?

[kmJeepers]

@Ellesar1:
I just checked, and however the turning speed isn't constant oO
if i turn for 1000ms two times, i get different values for the difference oO

[EmilyStrange]

Welcome to programming on a non-deterministic, multi-threaded operating system in a networked environment.

P.S. "Sleep" is merely a suggestion, not an absolute. Especially under Java.

[Ellesar1]

then you won't ever have perfect accuracy with this method.

if you want a perfect solution, you will have to call SetFacing() of WoW

[Xarg0]

Sending mouseinput to turn is better and faster than using the arrow keys, you'll just have to calculate how far you need to move your cursor.
You'll have to find out how many px you need to move your mouse to reach a certain angle.
Once you know how many px to move you'll send a right mouse button down message to wow, then change the cursor coordinates by the px you calculated and send a right mouse button up message.
But be careful, if you're spinning around too fast you'll get disconnected.

[~OddBall~]

what IDE did you use to make this?

[Ellesar1]

just be aware of the mouse acceleration. if you move it fast you'll move farther than if you move it slowly over the same distance.

[kmJeepers]

@~OddBall~: Eclipse.

well i'm actually trying to implement the mouse method, but this is is kind of tricky...
the angle the player moves is relatet to the speed the mouse moves ...
but i'll try that out and post my result ;D