[WoW][3.2.0] Better Object Managment

[flo8464]

Just a question: Is it really faster to check every object if it is still valid and check for every new object if it is not in the current list instead of just wiping the complete list and assign everything EnumObjects has to offer?

[zzgw]

Just a question: Is it really faster to check every object if it is still valid and check for every new object if it is not in the current list instead of just wiping the complete list and assign everything EnumObjects has to offer?

That depends on how much data you pull from each object with option 2). You might be better off with the n^2 iterations for 1) since the n is usually very small (<100) instead of n iterations for 2) but allocating a bunch of memory every step.
Option 1) also makes persistance of references over frames easier, while with 2) you would probably need an additional lookup into a guid table in a bunch of places.
In the end you should go with what you prefer though, since this part is probably not going to be a bottleneck.

[Apoc]

The reason I use the IsValid (and also invalidate -> revalidate each object) is so you can persist a single object instance through multiple frames. Obviously; once the object is created, it's memory location won't change (so that can quite possibly be optimized), however, I tend to keep a reference to an object for minutes/hours at a time. (Eg; a reference to a nearby NPC I'm following, etc.) It saves having the GC fighting with my bot to clean up the resources from constant new WoWObject() calls.

Also; IsValid allows you to do quite a bit more. Such as; if (me.CurrentTarget.IsValid) instead of if (me.CurrentTarget != null). It's a personal thing; but I've found coding with the IsValid check is far 'cleaner' and avoids a lot of workaround that a null check would. (Not to mention, you completely avoid any possible nullrefs )

[flo8464]

but allocating a bunch of memory every step.

Not really sure, but I think its possible to clear a std::vector without freeing the memory. At least with some other container formats it's possible. That would reduce allocations by a lot.

Edit: Oh, didn't see your answer, Apoc. Thanks for clarification.

[swayenvoy]

Hi,

nice post about getting objects, just got a question.
I've updated the addresses to 3.2.2 with a pattern:

<Pattern desc="EnumVisibleObjects" pattern="\x55\x8B\xEC\xA1\x04\x11\x34\x01\x64\x8B\x0D\x2C\x00\x00\x00\x53\x56\x8B\x34\x81\x8B\x86\x08\x00\x00\x00\x05\xA8\x00\x00\x00\x8B\x40\x04\xA8\x01\x57\x75\x04" mask="xxxx????xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" />
<Pattern desc="ClntObjMgrObjectPtr" pattern="\x55\x8B\xEC\x64\x8B\x0D\x2C\x00\x00\x00\xA1\x04\x11\x34\x01\x8B\x14\x81\x8B\x8A\x08\x00\x00\x00\x83\xEC\x08\x85\xC9\x74\x2D" mask="xxxxxxxxxxx????xxxxxxxxxxxxxxxx" />
<Pattern desc="ClntObjMgrGetActivePlayer" pattern="\x64\x8B\x0D\x2C\x00\x00\x00\xA1\x04\x11\x34\x01\x8B\x14\x81\x8B\x8A\x08\x00\x00\x00\x85\xC9\x75\x05" mask="xxxxxxxx????xxxxxxxxxxxxx" />

the result seems to be ok, the real addresses i get are:

EnumVisibleObjects -> 004778D0
ClntObjMgrGetActivePlayer -> 00476580
ClntObjMgrObjectPtr -> 00477B50

but whenever I make a call to EnumVisibleObjects i get an System.AccessViolationException with the "Message Attempted to read or write protected memory. This is often an indication that other memory is corrupt." I've tried several callbacks with no change. Anyone has an idea what to look for?

best regards sway

[Cypher]

Hi,

nice post about getting objects, just got a question.
I've updated the addresses to 3.2.2 with a pattern:

<Pattern desc="EnumVisibleObjects" pattern="\x55\x8B\xEC\xA1\x04\x11\x34\x01\x64\x8B\x0D\x2C\x00\x00\x00\x53\x56\x8B\x34\x81\x8B\x86\x08\x00\x00\x00\x05\xA8\x00\x00\x00\x8B\x40\x04\xA8\x01\x57\x75\x04" mask="xxxx????xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" />
<Pattern desc="ClntObjMgrObjectPtr" pattern="\x55\x8B\xEC\x64\x8B\x0D\x2C\x00\x00\x00\xA1\x04\x11\x34\x01\x8B\x14\x81\x8B\x8A\x08\x00\x00\x00\x83\xEC\x08\x85\xC9\x74\x2D" mask="xxxxxxxxxxx????xxxxxxxxxxxxxxxx" />
<Pattern desc="ClntObjMgrGetActivePlayer" pattern="\x64\x8B\x0D\x2C\x00\x00\x00\xA1\x04\x11\x34\x01\x8B\x14\x81\x8B\x8A\x08\x00\x00\x00\x85\xC9\x75\x05" mask="xxxxxxxx????xxxxxxxxxxxxx" />

the result seems to be ok, the real addresses i get are:

EnumVisibleObjects -> 004778D0
ClntObjMgrGetActivePlayer -> 00476580
ClntObjMgrObjectPtr -> 00477B50

but whenever I make a call to EnumVisibleObjects i get an System.AccessViolationException with the "Message Attempted to read or write protected memory. This is often an indication that other memory is corrupt." I've tried several callbacks with no change. Anyone has an idea what to look for?

best regards sway

Are we expected to hack your computer in order to look at your code? Or just debug it telepathically?

[swayenvoy]

Surly not Cypher

[UnmanagedFunctionPointer(CallingConvention.Cdecl)]
        private delegate int EnumVisibleObjectsDelegate(IntPtr callback, int filter);
        /// <summary>
        /// Acts as the callback from WoW. This function will be called for each object
        /// during the enumeration. A GUID will be passed back that you can then use in the
        /// ClntObjMgrGetObjectPtr function to get the actual pointer.
        /// </summary>
        /// <param name="guid">A GUID to use.</param>
        /// <param name="filter">A filter for the object type.</param>
        /// <returns>
        /// Returns 0 when the enumeration should be stopped or
        /// 1 when the enumeration should continue.
        /// </returns>
        /// <remarks>
        /// If no objects are left to enumerate, the function will no longer be called.
        /// </remarks>
        [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
        private delegate int EnumObjectsCallbackDelegate(ulong guid, int filter);
        /// <summary>
        /// Returns a pointer to an object based on GUID, IntPtr.Zero if no object exists.
        /// </summary>
        /// <param name="guid">The GUID of the object.</param>
        /// <param name="filter">A filter for the object type.</param>
        /// <returns>An pointer to the actual object.</returns>
        /// <remarks>
        /// This function works from the object descriptor GUID (OBJECT_FIELD_GUID).
        /// Not the typical obj+0x32 GUID.
        /// </remarks>
        [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
        private delegate IntPtr ClntObjMgrGetObjectPtrDelegate(ulong guid, int filter);
        /// <summary>
        /// Retrives the GUID of the active player which can then be passed 
        /// to the ClntObjMgrGetObjectPtr function.
        /// </summary>
        /// <returns>The GUID of the active player.</returns>
        [UnmanagedFunctionPointer(CallingConvention.Cdecl)]
        private delegate ulong ClntObjMgrGetActivePlayerDelegate();

        private readonly EnumObjectsCallbackDelegate _Callback;
        private readonly IntPtr _CallbackPtr;
        private readonly ClntObjMgrGetObjectPtrDelegate ClntObjMgrGetObjectPtrWow;
        private readonly ClntObjMgrGetActivePlayerDelegate ClntObjMgrGetActivePlayerWow;
        private readonly EnumVisibleObjectsDelegate EnumObjects;
        private readonly Dictionary<ulong, WowObject> _RealObjects = new Dictionary<ulong, WowObject>();
        private ulong _frameCounter = 1;
        public WowObject Me
        {
            get
            {
                return _RealObjects[_PlayerGuid];
            }
        }
        private ulong _PlayerGuid = 0;

        public ObjectManager(Wow wow, TequilaSunrise.Core.TequilaSunrise sun)
        {
            _Sunrise = sun;
            _Wow = wow;
            

            _Callback = ObjectManager.EnumObjectsCallbackTest;
            _CallbackPtr = Marshal.GetFunctionPointerForDelegate(_Callback);

            _Sunrise.PatternManager.LoadFile(new FileInfo(Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "ObjectMgrPatterns.xml")), (uint)Process.GetCurrentProcess().Modules[0].BaseAddress, (uint)Process.GetCurrentProcess().Modules[0].ModuleMemorySize);

            ClntObjMgrGetActivePlayerWow = _Sunrise.MemoryManager.RegisterDelegate<ClntObjMgrGetActivePlayerDelegate>(_Sunrise.PatternManager["ClntObjMgrGetActivePlayer"]);
            ClntObjMgrGetObjectPtrWow = _Sunrise.MemoryManager.RegisterDelegate<ClntObjMgrGetObjectPtrDelegate>(_Sunrise.PatternManager["ClntObjMgrObjectPtr"]);
            EnumObjects = _Sunrise.MemoryManager.RegisterDelegate<EnumVisibleObjectsDelegate>(_Sunrise.PatternManager["EnumVisibleObjects"]);

            _Wow.Pulse += _Wow_Pulse;
        }

        private static int EnumObjectsCallbackTest(ulong guid, int filter)
        {
            return 1;
        }

        private int EnumObjectsCallbackHandler(ulong guid, int filter)
        {
            IntPtr objPtr = GetPtrByGuid(guid);

            if (!_RealObjects.ContainsKey(guid))
            {
                WowObject tmp = new WowObject(objPtr);

                switch (tmp.Type)
                {
                    case Enums.WowObjectType.AllTypes:

                        break;
                    case Enums.WowObjectType.Object:

                        break;
                    case Enums.WowObjectType.Item:

                        break;
                    case Enums.WowObjectType.Container:

                        break;
                    case Enums.WowObjectType.Unit:

                        break;
                    case Enums.WowObjectType.Player:

                        break;
                    case Enums.WowObjectType.GameObject:

                        break;
                    case Enums.WowObjectType.DynamicObject:

                        break;
                    case Enums.WowObjectType.Corpse:

                        break;
                    case Enums.WowObjectType.AiGroup:

                        break;
                    case Enums.WowObjectType.AreaTrigger:

                        break;
                }

                _RealObjects.Add(guid, tmp);
            }
            else if (_RealObjects[guid] != objPtr)
            {
                _RealObjects[guid].UpdateObjectPointer(objPtr);
            }
            return 1;
        }

        private void _Wow_Pulse(Microsoft.DirectX.Direct3D.Device DirectXDevice)
        {
            if (_PlayerGuid == 0)
                _PlayerGuid = ClntObjMgrGetActivePlayerWow();

            foreach (WowObject value in _RealObjects.Values)
            {
                value.UpdateObjectPointer(IntPtr.Zero);
            }

            EnumObjects(_CallbackPtr, 0); //here it gets ****ed up

            if (_frameCounter++ % 10 == 0)
                RemoveInvalidEntries();

            OnPropertyChanged(new PropertyChangedEventArgs("Me"));
            OnCollectionChanged(new System.Collections.Specialized.NotifyCollectionChangedEventArgs(System.Collections.Specialized.NotifyCollectionChangedAction.Reset));
        }

        private void OnCollectionChanged(NotifyCollectionChangedEventArgs notifyCollectionChangedEventArgs)
        {
            //if (CollectionChanged != null)
                //CollectionChanged(this, notifyCollectionChangedEventArgs);
        }

        private void OnPropertyChanged(PropertyChangedEventArgs propertyChangedEventArgs)
        {
            //if (PropertyChanged != null)
                //PropertyChanged(this, propertyChangedEventArgs);
        }

Delicios Copy & Pasta incoming

Edit: I've found the Problem the CallbackDelegate is causing the Problem. Changed from: private delegate int EnumObjectsCallbackDelegate(ulong guid, int filter); to private delegate int EnumObjectsCallbackDelegate(int lowGuid, int hightGuid, int filter); and everything works now

[Xarg0]

doesn't that framecounter overflow if you don't resett it at some point or does the clr take care of that for you?

[Robske]

doesn't that framecounter overflow if you don't resett it at some point or does the clr take care of that for you?

After 18,446,744,073,709,551,615 frames it will throw an overflow exception.

[Xarg0]

After 18,446,744,073,709,551,615 frames it will throw an overflow exception.

sounds like a serious bug to me, so you'd better resett that counter @18,446,744,073,709,551,610

[flo8464]

Btw, anyone ever tried storing objects in a database?

Im trying SQLite at the moment, with a database kept completly in memory.

Things like

GameObject fishingBobber = queryObject("SELECT * FROM objectlist WHERE displayId=" + FISHINGBOBBER_DID + " AND createdBy=" + Player.guid());

(Pseudocode) seem more comfortable than implementing new list iterations for everything you have to look for.

[swayenvoy]

At the moment i'm just playing around with the riped of code from apoc and do a little testing, and yes framecount will overflow^^

[flo8464]

At the moment i'm just playing around with the riped of code from apoc and do a little testing, and yes framecount will overflow^^

After a few million years running with 50 fps.

[Robske]

Btw, anyone ever tried storing objects in a database?

Im trying SQLite at the moment, with a database kept completly in memory.

Things like

GameObject fishingBobber = queryObject("SELECT * FROM objectlist WHERE displayId=" + FISHINGBOBBER_DID + " AND createdBy=" + Player.guid());

(Pseudocode) seem more comfortable than implementing new list iterations for everything you have to look for.

If only .NET had such a feature They could call it Language INtegrated Query! That sure would be revolutionairy!

It might even look something like this

var Bobber = (from foo in ObjectManager
              where foo.DisplayId == FishingBobberId && foo.CreatedBy == Player.Guid
              select foo).FirstOrDefault();

LINQ

[Cypher]

After 18,446,744,073,709,551,615 frames it will throw an overflow exception.

ITS OVER NINE THOUSAND!!!!111oneoneone

If only .NET had such a feature They could call it Language INtegrated Query! That sure would be revolutionairy!

It might even look something like this

var Bobber = (from foo in ObjectManager
              where foo.DisplayId == FishingBobberId && foo.CreatedBy == Player.Guid
              select foo).FirstOrDefault();

LINQ

C# and LINQ is the work of Satan.