IsSpellUsable (Lua)

[Gorzul]

Since GetLocalizedText seems to be a __thiscall, remove the "cave.AsmAddLine("add esp, 0xC");".

[ramey]

Since GetLocalizedText seems to be a __thiscall, remove the "cave.AsmAddLine("add esp, 0xC");".

It's a _cdecl function.

[HapaHaoleVA]

It's a _cdecl function.

Duh. That was it - much thanks.

[Gorzul]

@ramey
Are you sure? I don't see any "caller" stack cleanup in the wow code.

.text:006B79EE                 mov     ecx, [ebp+var_20]
.text:006B79F1                 push    0FFFFFFFFh
.text:006B79F3                 lea     eax, [ebp+var_164]
.text:006B79F9                 push    eax
.text:006B79FA                 call    GetLocalizedText
.text:006B79FF                 push    eax
.text:006B7A00                 push    esi
.text:006B7A01                 push    0
.text:006B7A03                 push    0FFFFFFFFh
.text:006B7A05                 push    offset aItem_req_reput ; "ITEM_REQ_REPUTATION"
.text:006B7A0A                 call    sub_49B170
.text:006B7A0F                 add     esp, 0Ch

[Cypher]

It's a _cdecl function.

No. It's __thiscall.

.text:005A8500 push ebp
.text:005A8501 mov ebp, esp
.text:005A8503 push ebx
.text:005A8504 push esi
.text:005A8505 mov esi, ecx

Use of ECX.

.text:005A8557 retn 8

Callee stack cleanup.

It's not even CLOSE to __cdecl. Mistaking it for __stdcall is understandable, but __cdecl just makes zero sense.

[ramey]

I was talking about the IsSpellUsable, was late and I misread Gorzul's post! sorry :x