[C++] PlayerBase problems

[0_00_0]

So I've just figured out how to get the player base and read values from it. However, whenever I enter a battleground my program cannot read the Player Base and returns 0's for everything . Is there a better way of re-scanning for playerbase? What changes when I enter a battleground? Is it still at the same memory location?

here's the code I've been using for getting my player base

DWORD lvl1Pointer=0x010B65F4;
DWORD lvl2PointerOffset = 0x34;
DWORD playerBaseOffset = 0x24;

//get player base
DWORD getPlayerBase(HANDLE hProcess){
     DWORD playerBase;
     DWORD buffer = 0;
     if(ReadProcessMemory(hProcess, (LPCVOID)lvl1Pointer, &buffer, sizeof(buffer), NULL)==0)
                                   return 0;
    if(ReadProcessMemory(hProcess, (LPCVOID)(buffer+lvl2PointerOffset), &buffer, sizeof(buffer), NULL)==0)
                                   return 0;
    if(ReadProcessMemory(hProcess, (LPCVOID)(buffer+playerBaseOffset), &playerBase, sizeof(playerBase), NULL)==0)
                                   return 0;
    return playerBase;
}

[wraithZX]

errrr.... Apoc?

[Cypher]

Where did all the good C++ bot/hack programmers go?

[korknob]

/dance....

[0_00_0]

well.. Those weren't very productive comments. I'm really trying to learn here. I can take abuse, just so long as it comes with suggestions. I've really got past this problem, its not really an issue anymore. However, I am having difficulty finding the object manager in similar fashion that you guys mocked. Please let me know what I'm doing wrong this time. The program has debug and administrator privileges.

I also need the offsets for the first and next objects. Please be helpful this time I'm trying to learn.

DWORD clientConn    = 0x01132F60;
DWORD cur_MgrOffset = 0x2C24;

DWORD getObjectManager(HANDLE hProcess){
      DWORD buffer, objMgr;
      if(ReadProcessMemory(hProcess, (LPCVOID)clientConn, &buffer, sizeof(buffer), NULL)==0)
                                   return 0;
      if(ReadProcessMemory(hProcess, (LPCVOID)(buffer+cur_MgrOffset), &objMgr, sizeof(objMgr), NULL)==0)
                                   return 0;
      return objMgr;
}

edit: the error is the function always returns 0, meaning the readprocessmemory()'s failed.

[lanman92]

Make sure you have the SeDebugPrivilege. Run as admin. Use GetLastError() to see what's going on.

[0_00_0]

I have debug priviliges. It's worked for me many times and my vista's UAC is turned off. GetLastError() reports error 6.

[Opul3nt]

You've set those conditionals to return '0' in the event of a variety of unexpected results.

Set breakpoints and debug your sh**. Then look at the point at which this code fails. If it fails on the first read, you probably don't have a valid handle or debug privileges. In those cases your problem is out of the scope you've provided here.

Good Luck.

[boomingranny]

don't worry about everyone here, everyone answers your question with:
"you are stupid to ask such a basic question (even if you question isn't basic to normal humans) but here is a hint at the answer"

anyway, when your gameworld reloads (that progress bar/loading screen) the part of memory that you are reading (which the player object is part of) is destroyed then the new "gameworld" is loaded (so its location will move)
so reload your player base from your static pointers.

i Currently just do it when my mapID changes, but i am sure there is a much smarter way of doing it...

Anyway, good luck

[dekz]

or read the stickies

[deCutter]

GetLastError() reports error 6.

Well,

//
// MessageId: ERROR_INVALID_HANDLE
//
// MessageText:
//
// The handle is invalid.
//
#define ERROR_INVALID_HANDLE 6L

To be sured that this is your problem, in debug mode add "@err,hr" to your watch list, this will show you error from last winapi call. You must be sured that there was no more winapi calls between your error call and GetLastError() call. Also, if u want to manually check GetLastError(), you can call

DWORD WINAPI FormatMessage(
  __in      DWORD dwFlags,
  __in_opt  LPCVOID lpSource,
  __in      DWORD dwMessageId,
  __in      DWORD dwLanguageId,
  __out     LPTSTR lpBuffer,
  __in      DWORD nSize,
  __in_opt  va_list *Arguments
);

to get string representation of your error.

[0_00_0]

Well, To be sured that this is your problem, in debug mode add "@err,hr" to your watch list, this will show you error from last winapi call. You must be sured that there was no more winapi calls between your error call and GetLastError() call. Also, if u want to manually check GetLastError(), you can call

DWORD WINAPI FormatMessage(
  __in      DWORD dwFlags,
  __in_opt  LPCVOID lpSource,
  __in      DWORD dwMessageId,
  __in      DWORD dwLanguageId,
  __out     LPTSTR lpBuffer,
  __in      DWORD nSize,
  __in_opt  va_list *Arguments
);

to get string representation of your error.

This was the problem. It was an invalid handle, i didnt notice but two of my lines had swapped somehow and I added priviliges after i called OpenProcess(). Dumb mistake, there's technically nothing wrong with that code, although it's sloppy.

Now to start looping through the game objects. I'm already having trouble but I'll spend my day off trying to figure this out!

[lanman92]

Looping through objects is cake. Look up "shynd wow modification" on google. It's a great guide, just update the offsets from here(most should be the same though, other than the ObjMgr offsets).