[Help] PlayerAdress

[dante020]

amadmonk thank you for your detailed answer, but what is with Glider. Glider didnt inject code it was just a memory reader, too. There i never had this problem that i had to start the program many times until it gets the right hwnd.

Just because a ReadProcessMemory fails doesn't mean that your program should crash. If you properly handle the failed read, you should attempt to re-read the same memory at some later time until it is successful. There are many different ways of handling failed reads but that is up to you.

As stated above, never assume that it WILL work and check values after every step. In the case that something does fail, have code to deal with it.

[unbekannt1]

My Problem is not that ReadProcessMemory isnt working...its that i sometimes get the wrong hwnd. But i have no clue how to check if the hwnd is valid or not, because it is not NULL or empty or like that, it just contains a wrong value...

[kakamunsug]

My Problem is not that ReadProcessMemory isnt working...its that i sometimes get the wrong hwnd. But i have no clue how to check if the hwnd is valid or not, because it is not NULL or empty or like that, it just contains a wrong value...

How are you catching the handle?
Does it work sometimes?
Is something in your source overwriting the handle?
Do you run the segment of code that tries to find the handle more than once, thus overwriting with possible faulty result?

...etc.
Please give yourself a good thinker, programming is never "mysteriously" wrong, it's always logical.
I've had problems that makes no sense, and then you go away - come back and there you have the solution.

[unbekannt1]

Code to get handle :

hwnd = FindWindow(NULL, TEXT("World of Warcraft"));

I just get the handle at the beginning of the programm one time. Sometimes it has the right value, sometimes not.

[amadmonk]

amadmonk thank you for your detailed answer, but what is with Glider. Glider didnt inject code it was just a memory reader, too. There i never had this problem that i had to start the program many times until it gets the right hwnd.

dante020 nailed it in one: Glider was (IIRC) very well written code, and I assume that it had "sane" failsafes for when data got tromped on mid-read. You can recover from it, if you're careful.

Also, you might want to skip the window handle read (unless you need it for some other purpose). For my memory reads I just directly get the process from a process list enumeration (since I'm too lazy to write C++ for out-of-process code, I just use C# or IronPython to do the enumeration for me with Process.GetProcesses()). You don't need the extra layer of abstraction that using hwnd's adds, unless you're using it for something else (windows message hooking or something like that).

[kakamunsug]

Code to get handle :

hwnd = FindWindow(NULL, TEXT("World of Warcraft"));

I just get the handle at the beginning of the programm one time. Sometimes it has the right value, sometimes not.

I forgot which language you were using, but can't you just return your windowhandle from your process? It seems like you're not catching the right window sometimes, perhaps by having another window (maybe the wow folder?) up with the same title, idk.

I'll give you my code for this because people has helped me out here (exception of Cypher being a total ****off "de-repping" me for whatever ****ed up reason he had there.)

Process[] processes;
processes = Process.GetProcessesByName(pName);

WindowHandle = processes[0].MainWindowHandle;

You could make this into an array which holds numerous amounts of wow.exe's and put up several bots in a serie.
pName being the process' NAME.

Example of writing a function for this (make use for the process ID/handle as well in this since you can do it all with System.Process;

public int returnHandle(string pName) {
Process[] processes;
processes = Process.GetProcessesByName(pName);

return processes[0].MainWindowHandle;
}

enjoy.

[SKU]

<snip>

I'll give you my code for this because people has helped me out here (exception of Cypher being a total ****off "de-repping" me for whatever ****ed up reason he had there.)

<snip>

Rofl, I know. Cypher's such an ass! He NEVER helps out!

Also, since he's programming in unmanaged C++, this will hardly help him.

CodeProject: API Hooking with MS Detours. Free source code and programming help has a nice example of a process enumeration.

[unbekannt1]

Ok your codes are working well for getting the process id, but i need the window handle for sending keys to wow.

[apollo0510]

Ok your codes are working well for getting the process id, but i need the window handle for sending keys to wow.

unbekannt1,

I have some trouble to understand whats going on in your mind, but on the other side its somehow funny.

You posted the code:

hwnd = FindWindow(NULL, TEXT("World of Warcraft"));

And then you are asking for the handle to the wow window ?


Hrhr.

[unbekannt1]

hwnd = FindWindow(NULL, TEXT("World of Warcraft"));

is just working sometimes. And because i got the process handle out of the hwnd i hat sometimes the problem with reading memory. And now i am searching for an alternative of FindWindow. I know how to get process handle without window handle, but i need the hwnd to send keys to wow.

[kakamunsug]

hwnd = FindWindow(NULL, TEXT("World of Warcraft"));

is just working sometimes. And because i got the process handle out of the hwnd i hat sometimes the problem with reading memory. And now i am searching for an alternative of FindWindow. I know how to get process handle without window handle, but i need the hwnd to send keys to wow.

WindowHandle = processes[0].MainWindowHandle;

This gives you the windowhandle. You have no use for FindWindow() API when C# already has a managed code function for that. Just draw it out of the process ID (which was in the example I gave to you).

To put it in your "hwnd" variable (I'm not sure you know the language enough to understand that, or you're not understanding what the code does) you do this:

int hWnd = 0;
hWnd = processes[0].MainWindowHandle;
MessageBox.Show(hWnd.ToString(), "WindowHandle");

:wave::wave::wave::wave:

[opulent]

Just to reiterate...

Also, since he's programming in unmanaged C++, this will hardly help him.

Managed C# might not yield the solution here.

[SKU]

Just to reiterate...

Managed C# might not yield the solution here.

Hehe, yeah. Well, I give up, well played kakamunsug. No way I'm going down on that level.

[Zombie911]

hwnd = FindWindow(NULL, TEXT("World of Warcraft"));

is just working sometimes. And because i got the process handle out of the hwnd i hat sometimes the problem with reading memory. And now i am searching for an alternative of FindWindow. I know how to get process handle without window handle, but i need the hwnd to send keys to wow.

Alternative of FindWindow

DWORD wowpid = ...
HWND hWnd = GetTopWindow(NULL);
HANDLE WindowHandle = NULL;
while(hWnd)
{
    DWORD pid;
    DWORD dwTheardId = GetWindowThreadProcessId(hWnd, &pid);
    if(pid == wowpid) ///<-- WoW PID here
    {
        WindowHandle = hWnd;
        break;
    }
    Sleep(1);
    hWnd = ::GetNextWindow(hWnd, GW_HWNDNEXT);
}

[Shynd]

Calling GetNextWindow (which is the same as calling GetWindow with the next-window flag set) in a loop is a particularly bad process because it can cause your code to get stuck in an infinite loop which can be a pain in the ass to debug. Really, if you're enumerating windows, you should be using EnumWindows with a proper callback. Something, however, tells me that may be a wee-bit above the difficulty level of this thread, though I may be wrong.