BlackMagic Memory Read - Error

[Cryptography]

I know this is a simple question however I don't know the answer. I have been trying to use Shnyd's BlackMagic memory reader. Unfortunately I cannot seem to get things to work like I would expect..

The following code uses the memory addresses specified in the 3.0.9 Memory offsets page to attempt to get the currentPlayers XYZ location and the current targets guid. The Current Target returns somthing that only changes when i change targets so It may well be the guid, however the code as written causes an exception when creating the player base...

This same exception is called effectively anytime I call a Nested memory read. I am sure I am doing something wrong, but I don't know what it is. Please enlighten me.

namespace BlackMagicTest
{
    class Program
    {
		static void Main(string[] args)
		{
            uint CLIENT_CONNECTION;

			BlackMagic wow = new BlackMagic();
			if (wow.OpenProcessAndThread(SProcess.GetProcessFromProcessName("wow")))
			{

                uint playerBase = wow.ReadUInt(wow.ReadUInt(wow.ReadUInt(0x127F3C) + 0x30) + 0x28);
                
                float x = wow.ReadFloat(playerBase + 0x7D0);
                float y = wow.ReadFloat(playerBase + 0x7D4);
                float z = wow.ReadFloat(playerBase + 0x7D8);

                UInt64 CurTargetGuid = wow.ReadUInt64(0x10A68E0);

                Console.WriteLine("Loc: {0}, {1}, {2} | {3}", x, y, z, CurTargetGuid);
            }
            else
            {
                Console.WriteLine("World of Warcraft could not be opened for read/write.");
            }

            Console.ReadLine();

		}
	}
}

Edit:

Note, Attached Process is running in debug mode.

The error, which I should have specified more percisely earlier is the exception thrown from this function included in SMemory.cs of Black Magic.

		public static uint ReadUInt(IntPtr hProcess, uint dwAddress, bool bReverse)
		{
			byte[] buf = ReadBytes(hProcess, dwAddress, sizeof(uint));
			if (buf == null)
				throw new Exception("ReadUInt failed.");

			if (bReverse)
				Array.Reverse(buf);

			return BitConverter.ToUInt32(buf, 0);
		}

Robske007a, Thanks for the note on the address. I have changed it, but cannot test till servers are online.

[JuJuBoSc]

You need to read first 0x127F3C, then result + 0x30, then result + 0x28 for the player base imo.

[Nesox]

I have another question.
If you change somehing in the .rdata section you first need to change the Acess to let's say PAGE_EXECUTE_READWRITE
and then i write the new value and then when i try to read it i get an error saying it cant be read. Anyone who know's why? here some of the code

using Magic;
using System;
using System.Diagnostics;
using System.Runtime.InteropServices;


namespace MrHackIt.Jumping
{
    class Jumping
    {
        [DllImport("kernel32.dll")]
        static extern bool VirtualProtectEx(IntPtr hProcess, IntPtr lpAddress,
        UIntPtr dwSize, uint flNewProtect, out uint lpflOldProtect);

        private BlackMagic wow { get; set; }
        public uint landjmp_patch { get; set; }
        public uint waterjmp_patch {get; set;}

         public Jumping(BlackMagic _BlackMagic)
        {
            this.wow = _BlackMagic;

            this.landjmp_patch = 0x9A9A7C;
            this.waterjmp_patch = 0x9A9A80;
        }

        public float jmpheight_land 
        { 
            get
            {
                uint old;
                VirtualProtectEx(wow.ProcessHandle, (IntPtr)this.landjmp_patch, (UIntPtr)0x4, 0x02, out old);
                return wow.ReadFloat(landjmp_patch);   
            }
            set
            {
                uint old;
                VirtualProtectEx(wow.ProcessHandle, (IntPtr)this.landjmp_patch, (UIntPtr)0x4, 0x40, out old);
                wow.WriteFloat(landjmp_patch, value);
                VirtualProtectEx(wow.ProcessHandle, (IntPtr)this.landjmp_patch, (UIntPtr)0x4, old, out old);
            }
        
        }
        public float jmpheight_water 
        { 
            get
            {
                uint old;
                VirtualProtectEx(wow.ProcessHandle, (IntPtr)this.waterjmp_patch, (UIntPtr)0x4, 0x02, out old);
                return wow.ReadFloat(waterjmp_patch);   
            }
            set
            {
                uint old;
                VirtualProtectEx(wow.ProcessHandle, (IntPtr)this.waterjmp_patch, (UIntPtr)0x4, 0x40, out old);
                wow.WriteFloat(waterjmp_patch, value);
                VirtualProtectEx(wow.ProcessHandle, (IntPtr)this.waterjmp_patch, (UIntPtr)0x4, old, out old);
            }
        }
    }
}

[SKU]

Uhm.. so what does the exception say exactly? (to the OP) I somehow missed that part, might be helpful.

Edit: Also, Process.EnterDebugMode(); might help, dunno.

[Robske]

You need to read first 0x127F3C, then result + 0x30, then result + 0x28 for the player base imo.

uint playerBase = wow.ReadUInt( wow.ReadUInt( wow.ReadUInt(0x127F3C) + 0x30 ) + 0x28 );

That's what he's doing... but with a wrong pointer to the playerbase.

0x00127F3C : wrong
0x0127F13C : correct

[Nesox]

Uhm.. so what does the exception say exactly? (to the OP) I somehow missed that part, might be helpful.

Edit: Also, Process.EnterDebugMode(); might help, dunno.

read Float failed, and yes ive tried to enter debug mode but it didnt help i think i need to change the Acess type

[SKU]

read Float failed, and yes ive tried to enter debug mode but it didnt help i think i need to change the Acess type

I'm sorry if I was confusing, I meant the thread-starter. I really have no idea concerning your problem, sorry.

[Cryptography]

uint playerBase = wow.ReadUInt( wow.ReadUInt( wow.ReadUInt(0x127F3C) + 0x30 ) + 0x28 );

That's what he's doing... but with a wrong pointer to the playerbase.

0x00127F3C : wrong
0x0127F13C : correct

Thanks. That worked. +Rep

For the one that asked about the exception thrown... I updated the post above but it was a generic exception created by BlackMagic. Somthing like Read Uint64 Failure.

This Code Works in 3.0.9 with the BlackMagic Libraries.

namespace BlackMagicTest
{
    class Program
    {
		static void Main(string[] args)
		{
            uint CLIENT_CONNECTION;

			BlackMagic wow = new BlackMagic();
			if (wow.OpenProcessAndThread(SProcess.GetProcessFromProcessName("wow")))
			{

                wow.SuspendThread(wow.ThreadHandle);

                float x = 0, y = 0, z =0;
                try
                {
                    uint playerBase = wow.ReadUInt(wow.ReadUInt(wow.ReadUInt(0x0127F13C) + 0x30) + 0x28);

                    x = wow.ReadFloat(playerBase + 0x7D0);
                    y = wow.ReadFloat(playerBase + 0x7D4);
                    z = wow.ReadFloat(playerBase + 0x7D8);
                }
                catch (Exception e)
                {

                }
                finally
                {
                    wow.ResumeThread();
                }
                UInt64 CurTargetGuid = wow.ReadUInt64(0x10A68E0);

                Console.WriteLine("Loc: {0}, {1}, {2} | {3}", x, y, z, CurTargetGuid);
            }
            else
            {
                Console.WriteLine("World of Warcraft could not be opened for read/write.");
            }

            Console.ReadLine();

		}
	}
}

[Robske]

Why would you suspend WoW's thread for some mere memory reads?

And

uint CLIENT_CONNECTION;

Is looking rather silly there

[Cryptography]

Why would you suspend WoW's thread for some mere memory reads?

And

uint CLIENT_CONNECTION;

Is looking rather silly there

Right now I am just happy that it works... Anyway I suspended the process for the memory read yesterday just to see if that helped. Hadn't removed it yet. Though as you say it isn't needed... Thanks again.

[bhpushnslide]

Thanks! Just robbed this as a working example of using the BlackMagic Lib... and it worked!!

:-D

Understand it all so much better now :-)