GetPlayerName()

[cloud_wizard]

I attempted to make a rough translation of the AutoIt code I found at

NoMorePasting.com

These are the results, but it's not working for me. I think it has something to do with my misuse of &=.

Not familiar with bitwise AND operators. Then again, the compiler isn't complaining... But just because the compiler isn't telling me my code is broken doesn't mean it's gonna do what I want it to do.

Anyway...

string GetPlayerName(DWORD pGUID)
{
	using namespace std;
	string Name;

	DWORD nameStorePtr = 0x11AE3D0 + 0x8;
	DWORD nameMaskOffset = 0x24;
	DWORD nameBaseOffset = 0x1C;
	DWORD nameStringOffset = 0x20;
	DWORD Mask = MemoryRead(HBAI.Handle,(nameStorePtr+nameMaskOffset)* 4);
	DWORD Base = MemoryRead(HBAI.Handle,(nameStorePtr+nameBaseOffset)* 4);

	DWORD shortGUID = pGUID &= 0xFFFFFFFF;
	if (Mask == 0xFFFFFFFF)
	{
		Name = "";
		return false;
	}

	DWORD Offset  = 12 *(Mask &= shortGUID);
	DWORD Current = MemoryRead(HBAI.Handle,(Base+Offset+8));
	Offset = MemoryRead(HBAI.Handle,(Base+Offset));

	if ((Current == 0) || (Current &= 0x1))
	{
		Name = "";
		return false;
	}

	DWORD TestGUID = MemoryRead(HBAI.Handle,Current);
	while(TestGUID != Current)
	{
		Current=MemoryRead(HBAI.Handle,(Current+Offset+0x4));
		if ((Current == 0) || (Current &= 0x1))
		{
			Name = "";
			return false;
		}
		TestGUID = MemoryRead(HBAI.Handle,Current);
	}
	Name = MemoryReadString(HBAI.Handle,(Current+nameStringOffset));
	return Name;
}

Where did I go wrong?

[cloud_wizard]

Nvm, before you say anything, I'm an idiot.

& is what I needed to use, not &=.

However, now I'm getting an access violation in strlen.asm

main_loop:
        mov     eax,dword ptr [ecx]     ; read 4 bytes  <----- ON THIS LINE
        mov     edx,7efefeffh
        add     edx,eax
        xor     eax,-1
        xor     eax,edx
        add     ecx,4
        test    eax,81010100h
        je      short main_loop
        ; found zero byte in the loop
        mov     eax,[ecx - 4]
        test    al,al                   ; is it byte 0
        je      short byte_0
        test    ah,ah                   ; is it byte 1
        je      short byte_1
        test    eax,00ff0000h           ; is it byte 2
        je      short byte_2
        test    eax,0ff000000h          ; is it byte 3
        je      short byte_3
        jmp     short main_loop         ; taken if bits 24-30 are clear and bit
                                        ; 31 is set

[Shynd]

Probably has to do with your MemoryReadString function.

[alek900]

isent AND operators in c++ just a '&'??

so

DWORD shortGUID = pGUID &= 0xFFFFFFFF;

should be

DWORD shortGUID = pGUID & 0xFFFFFFFF;

etc..

edit: to slow again :S

[cloud_wizard]

Alright. Mind taking a look for me please?

string MemoryReadString(HANDLE Handle, DWORD ReadAddress)
{
	SIZE_T BytesRead;
	int BytesToRead = sizeof(ReadAddress);
	string ContentsOfAddress;
	ReadProcessMemory(Handle,(LPCVOID)ReadAddress,&ContentsOfAddress,BytesToRead,&BytesRead);
	return ContentsOfAddress;
}

[cloud_wizard]

After an agonizingly thorough trace, discovered that it bombed out on me hwne I tried to return false from a function whose return type is string.

Now it doesn't crash, rather it just gets stuck in the loop.

[Nesox]

it's easier if you call GetObjectName vmt 47

[cloud_wizard]

...

...

...huh?

What do you mean? What is vmt 47?

[Robske]

it's easier if you call GetObjectName vmt 47

He said that he only wants to read memory in another thread.

[Sillyboy72]

Alright. Mind taking a look for me please?

string MemoryReadString(HANDLE Handle, DWORD ReadAddress)
{
	SIZE_T BytesRead;
	int BytesToRead = sizeof(ReadAddress);
	string ContentsOfAddress;
	ReadProcessMemory(Handle,(LPCVOID)ReadAddress,&ContentsOfAddress,BytesToRead,&BytesRead);
	return ContentsOfAddress;
}

ReadProcessMemory tries to copy memory from one process space... to another. The 3rd param is the address to copy the memory to. However, you need to have some space allocated to store the memory.

I am not super familiar w/ the "string" class in c++, but I would more typically expect the buffer to be a byte array.
BYTE *ContentsOfAddress = new BYTE[BytesToRead];

actually, your BytesToRead looks weird too (always going to be 4... the sizeof a dword).

-Silly

[cloud_wizard]

Alright, and thanks for the effort. Nevermind trying to do it this way though. It's too complicated. Would be much easier to just get the unit name by calling an LUA function (I hope.)

[Shynd]

Everything is complicated when you don't know what the hell you're doing. Why don't you learn some basic programming before tackling something this large.

[cloud_wizard]

ReadProcessMemory tries to copy memory from one process space... to another. The 3rd param is the address to copy the memory to. However, you need to have some space allocated to store the memory.

I am not super familiar w/ the "string" class in c++, but I would more typically expect the buffer to be a byte array.
BYTE *ContentsOfAddress = new BYTE[BytesToRead];

actually, your BytesToRead looks weird too (always going to be 4... the sizeof a dword).

-Silly

Alright, now I've got:

char * Name = (char *)malloc(13);
~~~~~~~~~~~~~~~~~~~~
char* MemoryReadString(HANDLE Handle, DWORD ReadAddress)
{
	SIZE_T BytesRead;
	int BytesToRead = 13;
	char * ContentsOfAddress = (char *)malloc(13);
	ReadProcessMemory(Handle,(LPCVOID)ReadAddress,&ContentsOfAddress,BytesToRead,&BytesRead);
	return ContentsOfAddress;
}
~~~~~~~~~~~~~~~~~~~~
char * GetPlayerName(DWORD pGUID)
{
	HANDLE Handle = OpenProcess(PROCESS_ALL_ACCESS,FALSE,HBAI.Instance[HBAI.CurrentWoWInstance].PID);
	using namespace std;
	Name = "";

	DWORD nameStorePtr = 0x011AE3D0 + 0x8;
	DWORD nameMaskOffset = 0x24;
	DWORD nameBaseOffset = 0x1C;
	DWORD nameStringOffset = 0x20;
	DWORD Mask = MemoryRead(Handle,(nameStorePtr+nameMaskOffset));
	DWORD Base = MemoryRead(Handle,(nameStorePtr+nameBaseOffset));

	DWORD shortGUID = pGUID & 0xFFFFFFFF;
	if (Mask == 0xFFFFFFFF)
	{
		Name = "";
		return Name;
	}

	DWORD Offset  = 12 *(Mask & shortGUID);
	DWORD Current = MemoryRead(Handle,(Base+Offset+8));
	Offset = MemoryRead(Handle,(Base+Offset));

	if ((Current == 0) || (Current & 0x1))
	{
		Name = "";
		return Name;
	}

	DWORD TestGUID = MemoryRead(Handle,Current);
	while(TestGUID != Current)
	{
		Current=MemoryRead(Handle,(Current+Offset+0x4));
		if ((Current == 0) || (Current & 0x1))
		{
			Name = "";
			return Name;
		}
		TestGUID = MemoryRead(Handle,Current);
	}
	Name = MemoryReadString(Handle,(Current+nameStringOffset));
	return Name;
	CloseHandle(Handle);
}

Name is returning (has been for a while now) but always blank.

[Sillyboy72]

Surprised it doesn't crash

char * ContentsOfAddress = (char *)malloc(13);
ReadProcessMemory(Handle, LPCVOID)ReadAddress,&ContentsOfAddress,BytesToRead,&BytesRead);

ContentsOfAddress is the address of your buffer;so you don't need to pass a reference to it in the 3rd param (nuke off the &)

[cloud_wizard]

Alright, duly noted, done. Now stop. It has yet to even CALL the function MemoryReadString. The GetPlayerName function is the only function in which MemoryReadString is called, and it fails to call it because I'm reading the memory incorrectly. You're fixing a lot of mistakes in my code, but ones I haven't even gotten to yet. The main problem I'm having is with how I screwed up translating the code I found here: NoMorePasting.com to C++. Except I have no idea where I went wrong.

Also... Why are you telling me how I need to allocate memory for a string when:

I am not super familiar w/ the "string" class in c++

It took me until now to realize this, but I've used strings without any kind of prior memory allocation several other places in my code with no problems. This should be no different. IDK what you do or don't know, but I kinda doubt you're "super familiar" with C++ (which makes asking for your help translating the code a dangerous endeavor in itself), but this problem (in fact, this whole forum) is about reading WoW's memory.

A for effort, but I've just spent the last 4 hours chasing imaginary bugs through working code rather than focusing on what actually needs to be fixed.