[PQR] PvP Skill Amplifier: BG Killing Blow Leecher

[RedRussian]

http://www.ownedcore.com/forums/worl...ation-bot.html is required

Hi everyone!
This is my new project and it may be useful for PQR PvP profile authors. This code attempts to steal killing blows from your BG teammates making your final score ~25% (according to my tests in actual BGs) more impressive!

Principle of work
Some of your teammates spots an enemy player who has low HP - my profile casts an instant ability (depending on enemy's HP) attempting to finish him off.

How to use it
You can create a new ability in your PvP profile and put my code there.
Ability selection logic for all classes isn't ready yet and I'd be really grateful if you can help me.
This is the function responsible for ability selection, it might look familiar for those who has tried my Stealther's Bane profile. It will explain spell selection mechanic on a paladin example.

local function Finisher() --returns spellID, health threshold
    local _, playerClass = UnitClass("player")
    if playerClass == "PALADIN" then
        if PQR_SpellAvailable(24275) then
            return  24275 , 35000    --Hammer Of Wrath (ALL SPECS). This is the most powerful ability in your arsenal.
        elseif PQR_SpellAvailable(879) then
            return 879, 30000        --Exorcism (RET). Spec-bound ability weaker than Hammer but stronger than Judgement.
        elseif PQR_SpellAvailable(31935) then
            return 31935, 30000      --Avenger's Shield (PROT). Another spec-bound ability.
        elseif PQR_SpellAvailable(20271) then
            return 20271, 25000      --Judgement (ALL SPECS). The weakest instant ability you've got.
        else
            return 0, -1             --Just do nothing. 0 means ID of non-existant ability and -1 means unreachable HP level.
        end
    else
        return 0, -1
    end    
end

This function returns ID of an instant spell used for finishing your foe and it's estimated damage. As you can notice these spells are arranged from higher to lower damage. This is the crucial principle of building spell selection logic. I have no idea about actual PvP damage at lvl 90 as I play only my lower level twinks so these green numbers are just examples.
I hope you can help me with completing spell/damage list so I can add it to my profile. (example for mage: Instant pyro (FIRE) > Instant FFB (FROST) > Arcane Barrage (ARCANE) > Ice Lance (ALL SPECS) )

DOWNLOAD

[lostinthewoodslol]

interesting

[jackus]

Good idea But I guess this is range classes mostly. Not very good for a warrior e.g

[CrippledCyclone]

Good idea But I guess this is range classes mostly. Not very good for a warrior e.g

I guess theoretically you could have it cast charge and then another spell.

[RedRussian]

This is what I wanted to post. Charge + execute > slam is a good combo. I just need you to post some info about damage at lvl 90 - I have no idea about how hard execute or slam can hit.

[Partykilla]

Once again RedRussian did it <3
+Rep!

[Ekkard]

prist -Shadow Word: Death
warlock-Shadowburn

[CrippledCyclone]

This is what I wanted to post. Charge + execute > slam is a good combo. I just need you to post some info about damage at lvl 90 - I have no idea about how hard execute or slam can hit.

At 35k Attack Power 96K average. That's at 485ivl

[vitalic]

Damn this, I hate ranged classes stealing my KBs as a Rogue. I do all the work to get them in execute range and then some Shadow Priest steals my kill with a single cast.

[Partykilla]

An starter for warrior:

local function Finisher() --returns spellID, health threshold
    local _, playerClass = UnitClass("player")
    if playerClass == "WARRIOR" then
    
        if PQR_SpellAvailable(5308) then
            return 5308, 55000    --Execute        
                
        elseif PQR_SpellAvailable(100) and IsSpellInRange(5308) then
            return 100, 34000    --Charge
                        
        elseif PQR_SpellAvailable(5246) then
            return 5246, 19000    --Intimidating Shout
                        
        elseif PQR_SpellAvailable(107570) then
            return 107570, 15000    --Stormbolt
            
        elseif PQR_SpellAvailable(57755) then
            return 57755, 4000    --Heroic Throw
            
        elseif PQR_SpellAvailable(122475) and not PQR_IsMoving(0.1) then
            return 122475, 1700    --Throw
                    
        else
            return 0, -1        --Nothing
        end
    else
        return 0, -1
    end    
end

local finisherID, criticalHealth = Finisher()
local finishername = GetSpellInfo(finisherID) --localized name for use with IsSpellInRange

if PQR_SpellAvailable(finisherID) then
    for i=1,40 do
        local unitID = "raid"..i.."target"
        if UnitExists(unitID) then
            local health = UnitHealth(unitID)
            if health <= criticalHealth and IsSpellInRange(finishername, unitID) and not PQR_IsOutOfSight(unitID, 1) then
                CastSpellByID(finisherID, unitID)
                return true
            end
        end    
    end
end 

Seems to work VERY nice, except it nukes totems etc too :P

[RedRussian]

Thanks a lot. Totem issue will be fixed by adding IsPlayer check along with UnitExists.

[Partykilla]

Mate is really nice, wish I could give u more rep
BUT can you make this % based too? So it can be used for other stuff would be nice!

[Aegeus]

This is the ****ing BOMB with regards to getting Bloody coins on the timeless Isle!

[xNotta]

I tired to make one for a shaman.
We have like 2 instant cast spells: Earthshock and Unleash Elements.

I added them to your script and it makes my game play choppy. FPS sits at 60+ but feels like it's stop motion.

Here's the code I tried:
DO NOT USE THIS!!!!

local function Finisher() --returns spellID, health threshold
    local _, playerClass = UnitClass("player")
    if playerClass == "SHAMAN" then
        if PQR_SpellAvailable(8042) then
            return 8042, 35000    --EarthShock
        elseif PQR_SpellAvailable(73680) then
            return 73680, 40000    --Unleash Elements
        else
            return 0, -1        --Nothing
        end
end

local finisherID, criticalHealth = Finisher()
local finishername = GetSpellInfo(finisherID) --localized name for use with IsSpellInRange

if PQR_SpellAvailable(finisherID) then
    for i=1,40 do
        local unitID = "raid"..i.."target"
        if UnitIsPlayer(unitID) then
            local health = UnitHealth(unitID)
            if health <= criticalHealth and IsSpellInRange(finishername, unitID) and not PQR_IsOutOfSight(unitID, 1) then
                CastSpellByID(finisherID, unitID)
                return true
            end
        end    
    end
end 

See any problems?
Where should this be placed in the rotation editor?

[RedRussian]

local function Finisher() --returns spellID, health threshold
    local _, playerClass = UnitClass("player")
    if playerClass == "SHAMAN" then
        if PQR_SpellAvailable(8042) then
            return 8042, 35000    --EarthShock
        elseif PQR_SpellAvailable(73680) then
            return 73680, 40000    --Unleash Elements
        else
            return 0, -1        --Nothing
        end
    else
       return 0, -1
    end
end

There's an error in the function you've modified. I've marked the missing part red.