Mavmins' Destruction Warlock

[deathndecay]

Profile just says Nil, in chat after i try to run it after update from .6 Back to using blythes for the mean time i guess.

[LazyRaider]

Mavmin its still getting hung up on the execute phase. Something with shadowburn logic is throwing off the profile causing nothing to be cast or for it to be very intermittent. And now its freezing during non-execute phases as well, sometimes it needs to be jumpstarted again with CoE

[billybuffalo]

odd, I am not having any of these issues.

will update after a few pulls.

[LazyRaider]

Maybe my PQInterface is messed up then, other than that I'm not running any addons that should conflict with PQR

odd how I'm the only one experiencing issues with it stopping rotation...maybe I'm expecting too much? I have to manually cast something liek Curse of Ele or Conflag to get it to start up again usually

edit: whoever was talking about the nil, I'm getting that as well in the PQI chat message... don't know if that means anything

[demonmeh]

i'm on 0.8 haven't had any issues. but i also don't use auto rain of fire.

[deathndecay]

Yeah getting NIL, and its not even casting anything just sits there. I do like how when FnB is kicked on it says AOE ROTATION. but sad if I cant even use the profile.

PQI says that PQR is on standby when I use the profile.

It's definitely an issue with the profile , Blythes works fine.

i'm on 0.8 haven't had any issues. but i also don't use auto rain of fire.

Please post a download link to version .8

Getting sick of using buggy blythe.

[billybuffalo]

actually, I am having issues. jin roch gets to about 30% and it just stops.....

and then on the 2nd pull, I just had ZERO issues... strange... I def. do think it has something to do with Shadowburn...

[deathndecay]

please add If health over X,XXX,XXX apply Curse of Elements

[billybuffalo]

I for the most part do use auto rof, and only had the profile stop on me that one time tonight. The boss was under 20% so i think that points to an issue with shadow burn logic. I was not seeing it actually cast shadow for awhile either.

But did a few more pulls downed some bosses and did not have anymore issues with it.

[Mavmins]

If it isn't working during execute please update to 0.895 which I hope will solve the shadowburn problem. The issues have come out of trying to maximise bloody cleave damage. If it IS working for you then please backup that version and update and test this one. I don't have a lot of time to actually play, mainly because im doing this and shadowburn cant be tested on raider dummy.

Here is the new code

local Targethealth = 100 * UnitHealth("target") / UnitHealthMax("target")
local havoc = UnitBuffID("target",80240)
local SpellStart, SpellDuration = GetSpellCooldown(113858)
local HavocStart, SpellDuration = GetSpellCooldown(80240)
local darksoul = SpellStart + SpellDuration - GetTime()
local havocCD = SpellStart + SpellDuration - GetTime()

-------V0.8 test---------------

if UnitExists("focus") == nil then
	if PQ_SoulShard >= 1 then 
		return true
	end
end

if Targethealth < 7 then
	return true
end

if UnitExists("focus") ~= nil and (PQ_SoulShard >= 1) and Targethealth < 20 then 
	if havoc == nil  and PQR_SpellAvailable(80240) then
		CastSpellByName(GetSpellInfo(80240),"focus")
		PQR_DelayRotation(0.3)
		return true
	end
end
	
if UnitExists("focus") ~= nil and (PQ_SoulShard >= 1) and Targethealth < 20 then 
	if havoc ~= nil then
		return true
	end
end
	
if UnitExists("focus") ~= nil and (PQ_SoulShard >= 1) and Targethealth < 20 then
	if havoc == nil then
		if not PQR_SpellAvailable(80240) and havocCD > 10 then
			return true
		end
	end
end
	

---------------------------------------------------------

Which is checking if we have a focus target, if we don't it will shadowburn under 20%
If we do and Havoc is available it will cast Havoc THEN shadowburn
If we have some stacks of Havoc already it will Shadowburn
If we dont have havoc and Havoc won't be off cooldown for more than 10 seconds it will Shadowburn
If Target is under 7% it will Shadowburn anyway

[billybuffalo]

I am sure it is just because i am not a developer but, i dont see where in that code it says to actually cast shadowburn. I am assuming that SB spell id is 113858. If this is correct, then that code just looks like it checks for all the right times to cast shadowburn but, never actually gets the ok to do so.

Im sure i am just missing something....

[novicane]

I am sure it is just because i am not a developer but, i dont see where in that code it says to actually cast shadowburn. I am assuming that SB spell id is 113858. If this is correct, then that code just looks like it checks for all the right times to cast shadowburn but, never actually gets the ok to do so.

Im sure i am just missing something....

^ return true = CAST

[billybuffalo]

^ return true = CAST

Thanks for that...


In this line:

if UnitExists("focus") ~= nil and (PQ_SoulShard >= 1) and Targethealth < 20 then
if havoc == nil and PQR_SpellAvailable(80240) then
CastSpellByName(GetSpellInfo(80240),"focus")
PQR_DelayRotation(0.3)
return true
end

Shouldnt it specifically say to cast SB on our "Target"? I can see where it says to cast havoc on our focus target, or does it by default cast on our target unless told to do otherwise?

Sorry for the noob, developer questions...just trying to learn a little something.



Edit:


Here is a scenario to consider, which is something I think could cause trouble with the profile.

What if your target is less than 20% health, and your focus target is above 20% health? Do we think that could cause a hiccup in the profile during its checks? I dont see where in the code that it accounts for that.

Perhaps a extra check is needed to check the health of the focus target as well? I use Horridon as an example. I put him on focus and then target adds/dinomancer. If Dino is at 19% health but horridon is at 90%, that is not gonna be able to cast shadowburn on horridon is it? Or do I just not know the warlock class well enough, and it will?

[Mavmins]

On the left hand side in PQR there is a small box when you go into ability editor and in there it is set to 'target' so it will cast on your target.

the HP of your Focus target doesn't matter and isnt checked, provided the HP of your target is under 20% the shadowburn will still damage your focus as well

Interested if anyone has tested 0.895 yet, i will be raiding tonight hopefully so i'll check it, im sure the problem is fixed tho as it had

if UnitExists("focus") == nil then
	if PQ_SoulShard > 1 then 
		return true
	end
end

and not how it is now which is

if UnitExists("focus") == nil then
	if PQ_SoulShard >= 1 then 
		return true
	end
end

The fix was the >=
before it was only shadowburning if you had more than 1 ember, and because PQR only checks in integers (whole numbers) greater than 1 ember can only be 2 so it wouldnt SB until you had 2 embers

now it will SB if you have 1 OR more embers



Once this issue is resolved and I've stuck in a couple more features like pet summons, grimoire support and talent checks I will call it version 1 stop developing it.

Version 1.xx -> v2 will be me adding PQInterface support and tidying up all the code of each ability

[billybuffalo]

On the left hand side in PQR there is a small box when you go into ability editor and in there it is set to 'target' so it will cast on your target.

the HP of your Focus target doesn't matter and isnt checked, provided the HP of your target is under 20% the shadowburn will still damage your focus as well

Interested if anyone has tested 0.895 yet, i will be raiding tonight hopefully so i'll check it, im sure the problem is fixed tho as it had

if UnitExists("focus") == nil then
	if PQ_SoulShard > 1 then 
		return true
	end
end

and not how it is now which is

if UnitExists("focus") == nil then
	if PQ_SoulShard >= 1 then 
		return true
	end
end

The fix was the >=
before it was only shadowburning if you had more than 1 ember, and because PQR only checks in integers (whole numbers) greater than 1 ember can only be 2 so it wouldnt SB until you had 2 embers

now it will SB if you have 1 OR more embers



Once this issue is resolved and I've stuck in a couple more features like pet summons, grimoire support and talent checks I will call it version 1 stop developing it.

Version 1.xx -> v2 will be me adding PQInterface support and tidying up all the code of each ability

Excellent. Thank you for the clarification. Was in no way saying you didnt know what you were doing. I just didnt know how the code works, and was unsure about how shadow burn would work on your focus target. Thanks very much Mav!