[PQR] Gabbz Mage Profiles

[beck3210]

Ok I'm really confused, I put the Event Loader and Function at the top tier of my rotation. I created a macro for combustion which /cast combustion -- then I made an ability called combustion with the following:

if IgniteLastDamage > 9000 and UnitDebuffID("target", 11366,"player")then RunMacro("Combustion") return true end


The rotation casts everything but combustion after the ignite reaches past 9000, nothing happens.

Please help,

Thanks,
-beck3210

[bbrainey1995]

Is there a Lua file for balance?

[Gabbz]

Ok I'm really confused, I put the Event Loader and Function at the top tier of my rotation. I created a macro for combustion which /cast combustion -- then I made an ability called combustion with the following:

if IgniteLastDamage > 9000 and UnitDebuffID("target", 11366,"player")then RunMacro("Combustion") return true end


The rotation casts everything but combustion after the ignite reaches past 9000, nothing happens.

Please help,

Thanks,
-beck3210

the "--" means that all after that on that line will be ignored.

if IgniteLastDamage > 9000 --Change this to suit your gear
then RunMacro("Combustion") return true end

this should be your code and it would work
You can change 9000 to suit your gear. My Mage is BiS Geared

BTW the Combustion macro should have /stopcasting so you sure it cast directly

[expunge]

Hey Gabbz, just wondering if there was some place you take donations?

[handnavi]

Hey gabbz,

i've seen that you might need a function to determine target.timetodie :

if (guid ~= UnitGUID("target")) or (guid == UnitGUID("target") and UnitHealth("target") == _firstLifeMax) then
               guid = UnitGUID("target")
               _firstLife = UnitHealth("target")
               _firstLifeMax = UnitHealthMax("target")
               _firstTime = GetTime()
            end             
            _currentLife = UnitHealth("target")
            _currentTime = GetTime()
            timeDiff = _currentTime - _firstTime
            hpDiff = _firstLife - _currentLife
            if hpDiff > 0 then
               fullTime = timeDiff*_firstLifeMax/hpDiff
                pastFirstTime = (_firstLifeMax - _firstLife)*timeDiff/hpDiff
                calcTime = _firstTime - pastFirstTime + fullTime - _currentTime
                if calcTime < 1 then
               		calcTime = 1
               	end
           		timeToDie = calcTime
            end
            if hpDiff <= 0 then
            guid = UnitGUID("target")
            _firstLife = UnitHealth("target")
            _firstLifeMax = UnitHealth("target")
            _firstTime = GetTime()
            end
            -- dummy
            if UnitHealthMax("target") == 1 then
            	timeToDie = 99
            end

this function will calculate this for you. The estimated time is stored in timeToDie

maybe your also interested in:

local EnergyRegen = GetPowerRegen("player")
local timetoEnergyCap = (100 - PlayerEnergy) * (1.0 / EnergyRegen)

so you could get rid of "if energy >80..." because EnergyRegen is not always the same... :-)
just replace this with "timetoEnergyCap < 1.0"

Cheers.

[cahe]

Can u add option to manual burn CD?

[kabman]

Two things... One when it was working its spamming my chat with ignite amounts which is what i have combustion helper for so if you could help me get rid of that. I would be very much happy and two it randomly stopped working and ... it wont do anything unless im the one spamming fireball... Also the profile works just fine if Combustion is on CD.
Oh and have a rep cookie.

[kabman]

Could you post your mage profile maybe

[Ninjaderp]

I actually modified the Kittybear version to pause rotation whenever I had leftshift down, is there anything I could edit to make that work for your Guardian as well? (to be able to click Ursols Vortex without having to Alt+X shut off the rotation). It would be really sweet.

Btw, I ran LFR with this other full BiS 408ilvl Guardian, and he did 58k on Madness. Vengeance is badass is what I've heard ^^

[Voli]

For boomkin when you use incarnation it seems to pause the rotation. Is the incarnation a different form thus causing it to be paused?

[Gabbz]

No i dont take donations, the only thing i want from you guys is comments and feedback how to enhance the profiles and rep.

Will upload the mage rotation today after i have cleaned it up a bit.

@Handnavi, thanks for the suggestions. I will update the rotation with your suggestions, rep incoming.

@Ninja: Left control is used for berserk toggling, use right one instead. Will add a comment for you dependent on what key you want.

[Gabbz]

Two things... One when it was working its spamming my chat with ignite amounts which is what i have combustion helper for so if you could help me get rid of that. .

put -- before the print in event function.

			if subEvent == "SPELL_PERIODIC_DAMAGE" then
			--	print("Mage Functions Periodic.")
				if UnitName("player") == sourceName and destName == UnitName("target") then
					if spellName == GetSpellInfo(12654) then  
						IgniteLastDamage = spellAmount 
				------------> HERE	print("Mage Functions Ignite. " ..IgniteLastDamage) 
					end
				end
			end

Combustion helper etc predicts the ignite damage. The ignite you see in chat is the real damage. Sometimes this fails due to getting a tick before script can fire off a combustion so i will check on that later

[kabman]

Oh i just sent you a long message haha didnt see that your going to post your mage profile soooo that makes me happy. ignore my message. Ill just wait. Nice work sir.

[jcslim]

Hey Gabbz

I just downloaded your profile pack to try out Moonkin/balance. I've selected both profiles and neither do anything. Do I need to change something within them or are you still working on them.

Thanks

[average]

Few more suggestions
Shred/Mangle/Ravage all in one

local AttackingFromTheFront = PQR_UnitFacing("target", "player")
local HasGlyphOfShred = HasGlyph(114234)
local EnergyRegen = GetPowerRegen("player")
local timetoEnergyCap = (100 - PlayerEnergy) * (1.0 / EnergyRegen)

if AoE then return false end
if Berserk
or TigersFury
or (ComboPoints < 5 and RipTimeLeft < 3)
or (ComboPoints == 0 and SavageRoarTimeLeft < 2)
or TigersFuryCooldownLeft <= 3
or ComboPoints < 5
or timetoEnergyCap <= 1.2
then
    if Incarnation then
        CastSpellByName(tostring(GetSpellInfo(6785))) -- Ravage
    else    
        if (TigersFury or Berserk) and HasGlyphOfShred then
            CastSpellByName(tostring(GetSpellInfo(114236))) -- Glyphed Shred
        else
            if not PQR_NotBehindTarget() 
            -- AttackingFromTheFront 
            then        
                CastSpellByName(tostring(GetSpellInfo(5221))) -- Shred
            else
                CastSpellByName(tostring(GetSpellInfo(33876))) -- Mangle
            end
        end
    end
    return true
end

For feral its might better to use PQR_NotBehindTarget() then PQR_UnitFacing because some mobs (like in DS and DW encounter) are facing player but Shred is usable.
For AoE it might be better to use single Rotation with a hotkey in --Functions

if IsLeftShiftKeyDown() and GetTime() - modkeytime > 0.3  then
    modkeytime = GetTime()
    
    if AoE == nil then
        AoE = 1
        print("Rotation mode: \124cFFFA652AAOE")
    else
        AoE = nil
        print("Rotation mode: \124cFF1874CDSingle Target")
    end    
end

Add "AoE" check for abilities to use and disable in others. At the moment Swipe generated combo points goes to waste besides Savage Roar usage. Should use Rip/FB