[PQR] Gabbz Mage Profiles

[Apsalaar]

Just did Ultraxion and still get this lua error.

Talent:
Incarnation(I didn't use it though)

Glyph:

Savagery
Shred


Message: [string "if PQR_Addon_Loaded == nil then..."]:1451: GetSpellBookItemName(): Invalid spell slot
Time: 08/29/12 22:10:38
Count: 44
Stack: [C]: ?
[C]: in function `GetSpellBookItemName'
[string "if PQR_Addon_Loaded == nil then..."]:1451: in function `PQR_GetSpellID'
[string "if PQR_Addon_Loaded == nil then..."]:1437: in function <[string "if PQR_Addon_Loaded == nil then..."]:1435>
[C]: in function `CastSpellByName'
[string "local PredatorySwiftness, _, _, _, _, _, Pr..."]:237: in function `?'
[string "if PQR_Addon_Loaded == nil then..."]:760: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:533: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>

[Gabbz]

Guardian glyphs is Frenzied Regen and Rebirth. Nothing that the profile needs in order to work.

Rake is ticking for alot for me,, often the highest damage. Make sure to reforge to Mastery and Crit.

Just did a DS 25 HM and it works ok. I sometime switch to caster or bear, dont know why. Ultraxion seems to have changed the Hour of Twillight spellid so i need to change that as well.

I have not added a combat check and i dont think i will since
1: I use ahk to start rotation, the manual way, so it is not on automatic.
2: Its easy enough to just target a friend or noone at all.

Will do some more test and check the rotation. But i dont get any error running the script.

[cukiemunster]

Possible noob question, but what is ahk?

[Gabbz]

Auto Hot Key, its a scripting language. So basically i have ahk script that look like this

~w::
While GetKeyState("w","P")
{
SendInput !{8}
Sleep 50
}
return

~e::
While GetKeyState("e","P")
{
SendInput !{9}
Sleep 50
}
return

Pressing "w" then i single target and pressing "e" i will AoE.

Regarding the error with spellid, someone noted that if you glyph Shred then its changes the spellid. So dont glyph shred.

[Ninjaderp]

Hi Gabbz! Really like the guardian profile so far, and Im gonna test your keybinds for SD & FR out.
One thing I would like though would be the ability to toggle AOE&Single target for Guardian with one key such as LeftCtrl (my preferation)
I see you have that for calm/normal/berserk now but I dont think its working in guardian if Im right. Once again thx, allways used your feral tankprofiles!

[Gabbz]

Updated the Feral Profile now. It is more stable and should show a DPS increase. The chill/normal/berserk toggle now works in aoe as well. Also changed the spellid for Ultraxion so it should work.
Still there is some issues with the spellids. So use Savage Roar Glyph, do not use Shred.

Next step is to enhance guardian a bit first and second to add some of the talents choices to Feral.

[Gabbz]

Added support for Incarnation now. Please test it and see how it goes. Still no fix for the Glyph of Shred. The issues is that it morps the spell id for Shred during Tigers Fury and therefore it is not possible to use the old spellid. Dont really have the will power to fix a bad glyph for content that is farmville.

Also redid Guardian, still its only Rage generation and threat, all defensive CD is left out.

[Ninjaderp]

Good to hear! How does it use Incarnation? I suggest you put rotation-information inside the profiles so you can read them in PQR. Gonna update the profiles then via PQR.
By the way I was gonna switch out my OS for Feral Cat now (currently mainspeccing Guardian with Moonkin OS) What talents do you recommend? Or does it matter?

Cheers!

[Gabbz]

Incarnation is used aligned to Berserk. So pretty much asap Berserk is used then Incarnation is used as well. I have not really tought that much about it but since Ravage is high on energy then we want to use it as often as possible?

Talents: Not really. Only Incarnation and SotF that are any dps increase, FoN is kind of hard with PQR since u need to place them on the ground. Dont glyph Shred! Savage Roar glyph is a must.

[Ninjaderp]

Allright thanks, I'll see if I can try this out in a raid later. Still gonna be gemmed & reforged for Guardian at least until they sort out Reforge-lite. Using the scrollwheel for SD & FR was an awesome idea btw

[Gabbz]

Updated: Glyphs of SavageRoar and Shred is now supported. Fixed some logic issues as well
Tested DPS and
Incarnation around 42.5k dps after 40 million damage done
SotF around 41.5k dps after 40 million damage done.

Please have a look and please see if there is some issues. I think i can do better with uptime and synching with TF better.

[PrimoPie]

Your profile needs to be using maul on cooldown, otherwise your constantly rage cap, is there anyway you can add maul into the rotation.

[average]

Sent a suggestion to PM how to do Rip extend counting

[Gabbz]

Your profile needs to be using maul on cooldown, otherwise your constantly rage cap, is there anyway you can add maul into the rotation.

Maul is just bad dps boost. You should use all rage on Savage Defense or Frenzied Regen dependent on the damage you take. I could add a toggle for Maul but as i do with the defensive CD is just to use mouse scropp up or down.

[Gabbz]

Ok im just trying to edit Sherons mage profile. And i'm wondering if there is anyway to have it check how much dmg per tick combustion is going to do before it actually cast combustion. So like a built in Combustion Helper. Would anyone know how to put that into programming language?


If you can't do that then at least making sure the pyro dot is on before it cast combustion... This is what i have so far. Not sure if i put it in correct.

if HaveBuff("player",48107)
and HaveBuff("target",11366)

and select(2,GetSpellCooldown(108853)) > 2
then return true end

i have made one similiar but what i do is check the ignite damage and if its above a certain number i will cast combustion. You dont need to check for pyroblast pn target cause ignite wont be high if its not based on a pyroblast afaik

My code is working atm if you cast first fireballs until there is a ignite on target but you cane asily code that in if you want. I dont bother atm cause i dont get rep !!!

btw you need to make 2 abilities named
Event loader and event functions

Event loader:

if XelperDruidEvents == nil then
	XelperDruidEvents = true
	print("Mage Events Loaded.")

	local xelperFrame = CreateFrame("Frame")
	xelperFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
	xelperFrame:SetScript("OnEvent", xelperFrame_OnEvent)
	xelperFrame:Show()

end

Event functions

if MageFunctions == nil then
	MageFunctions = true
	print("Mage Functions Loadeds.")
	function xelperFrame_OnEvent(self,event,...)
		if event == "COMBAT_LOG_EVENT_UNFILTERED" then
			--print("Mage Functions Combatlog.")
			local subEvent = select(2, ...)
			local sourceName = select(5, ...)
			local destName = select(9, ...)
			local spellName = select(13, ...)
			local spellAmount = select(15, ...)
			local spellCrit = select(21, ...)
			
			if subEvent == "SPELL_PERIODIC_DAMAGE" then
			--	print("Mage Functions Periodic.")
				if UnitName("player") == sourceName and destName == UnitName("target") then
					if spellName == GetSpellInfo(12654) then  
						IgniteLastDamage = spellAmount 
						print("Mage Functions Ignite. " ..IgniteLastDamage)
					end
				end
			end
			if subEvent == "SPELL_AURA_REMOVED" then
			--	print("Mage Functions Aura Removed.")
				if UnitName("player") == sourceName then
					if spellName == GetSpellInfo(12654) then  
						IgniteLastDamage = 0 
				--		print("Mage Functions resetting ignite. ")
					end
				end
			end
			if subEvent == "SPELL_DAMAGE" then
		--		print("Mage Functions Damage.")
				if UnitName("player") == sourceName and destName == UnitName("target") then
					if spellName == GetSpellInfo(133) then  
						Fireballdamage = spellAmount
						if spellCrit == 1	then
							FireballCrit = 1
							else
							FireballCrit = 0
						--	print("Mage Functions FireBall CRITTED. " ..Fireballdamage)
						end
					end
				end
			end
		end
	end
end

Combustion: you need to make a macro named combustion or change the code

if IgniteLastDamage > 9000 --Change this to suit your gear
--and UnitDebuffID("target", 92315,"player") -- this isnt working atm in mop change this to check for pyroblast dot
then RunMacro("Combustion") return true end

BTW my Fire mage script isnt on dropbox atm but im around 43K DPS with HC gear

TO CLARIFY:

You need to put event loader and functions at start of rotation
Then you need to put combustion as usual in rotation and then start casting pyroblast/fireball until you get your first Ignite and after that the rotation will start. I will fix my fire mage script soonish and put it on drop box. And the ground work on Mage script is sheuron´s