PQR - Rotation Bot

[vitalic]

@CharleyWex

Two things.

1. PQR_IsOutOfSight() returns true if the unit has received an out of sight error within the specified interval, so you should be checking the negation of it (i.e. not PQR_IsOutOfSight(...)). At the moment it won't cast the spell so you won't get any errors and the condition will never pass.

2. Don't use PQR_UnitDistance() unless you absolutely have to, it's expensive compared to IsSpellInRange() or CheckInteractDistance()

[CharleyWex]

Thanks Vitalic for the feedback, I totally forgot the not. I can't use IsSpellInRange() for this guy unfortunately as it isn't checking for a specific spell but checking for untargeted friendly players position within 40 yards at a certain hp and then running a macro.

EDIT: BTW Creepy that you have 666 posts when I read that.

[CharleyWex]

Okay I figured it out. @Vitalic, I did use a IsSpellInRange(), I just used a different spell with the same range check and it worked out fine.

if UnitExists("player") then
if not PQR_IsOutOfSight("player")
and not UnitIsDeadOrGhost ("player")
and IsSpellInRange(GetSpellInfo(111111),"player") == 1 then
if 100 * UnitHealth("player") / UnitHealthMax("player") < 90 then
RunMacroText("/macro")
RunMacroText("/stopspelltarget")
return true
end
end
end

Now I have one more question. Is there a simple way to get this to apply to a whole party/raid without having to substitute in "party1";"party2","raid1", etc for "player"?

[troxxer]

You could define a table like

local members = { "player" }
if IsInRaid() then
    for i=1, 25 do
        table.insert(members, "raid"..i)
    end
elseif IsInGroup() then
    for i=1, 5 do
        table.insert(members, "party"..i)
    end
end

and then iterate over it with another for loop.

[WWF]

@CharleyWex

Two things.

1. PQR_IsOutOfSight() returns true if ...

Are you sure? true? This function has been fixed?

[vitalic]

Are you sure? true? This function has been fixed?

Well it's supposed to but not sure tbh.

[kuukuu]

Wasn't aware it was even broken... but I've never had need to use that function so no idea. It's supposed to return true when out of sight though.

[CharleyWex]

Yeah, I just tested the out of sight function and its not working.

[WizKhalifa610]

Nvm I got it working thank you

[crystal_tech]

need to call PQR_UnitInfo() at least once for distance and facing checks

[Stikz]

It worked fine yesterday, I have the addon Suddenly mavmim's destro profile only casts rof and shadowburn. I reinstalled everything and still... any ideas?

[Kaylo]

Looking for help with creating a toggable function.
I want to have the function FireNovaHigh "true" when I click mousebutton 5 and toggled to "false" when I click mousebutton 5 again. I also want to put the status out in chat when it changes.
I tried to copy code and modify it but I havent had any luck. Wondering if someone can post an edited version. I want to add hotkeys to different rotations.I hope this shows somewhat what I want done:

--binds
FireNovaHigh		= IsMouseButtonDown(5)

FireNovaHigh =  false 


--FireNovaHigh
if not FireNovaHighdown then FireNovaHighdown = 0 end
if not GetCurrentKeyBoardFocus() and FireNovaHigh and GetTime() - FireNovaHighdown > 1 then
	FireNovaHighdown = GetTime()
  	if FireNovaHigh  then 
		FireNovaHigh  = false 
		PQR_WriteToChat("FireNovaHigh: |cFFFF0000Disabled")
		PQR_Event("PQR_Text","FireNovaHigh: Disabled",nil,"FF0000")
  	else 
		FireNovaHigh  = true 
		PQR_WriteToChat("FireNovaHigh: |cFF00FF00Enabled")
		PQR_Event("PQR_Text","FireNovaHigh: Enabled",nil,"00FF00")
  	end
end

[troxxer]

Your problem lies mostly here:

FireNovaHigh		= IsMouseButtonDown(5)

FireNovaHigh =  false

First you initialize FireNovaHigh to be the value of whether Mouse Button 5 is pressed or not, but on the next line you're setting it instantly back to false, so your MB5 check wont fire at all.
Additionally your logic is a bit flawed - as that code would switch your FireNovaHigh state every second, even if you won't press your MB5.

Something like this should work:

--FireNovaHigh
FireNovaHigh = FireNovaHigh or false
FireNovaHighdown = FireNovaHighdown or 0

if not GetCurrentKeyBoardFocus() and IsMouseButtonDown(5) and GetTime() - FireNovaHighdown > 1 then
    FireNovaHighdown = GetTime()
    FireNovaHigh = not FireNovaHigh
    PQR_WriteToChat("FireNovaHigh: "..(FireNovaHigh and "|cFF00FF00Enabled" or "|cFFFF0000Disabled"))
    PQR_Event("PQR_Text","FireNovaHigh: "..(FireNovaHigh and "Enabled" or "Disabled"),nil,(FireNovaHigh and "00FF00" or "FF0000"))
end

[Pdey]

i need your help ^^

for this kind of problem or so ^^

cast Mind Flay when Devouring Plague (id: 2944) is as (de-)buff on target

what i have to change on the normal mindflay spell?

CastSpellByName("Gedankenschinden")
return true

(i know i have to add an xtra ability-entry)

[Kaylo]

Your problem lies mostly here:

FireNovaHigh		= IsMouseButtonDown(5)

FireNovaHigh =  false

First you initialize FireNovaHigh to be the value of whether Mouse Button 5 is pressed or not, but on the next line you're setting it instantly back to false, so your MB5 check wont fire at all.
Additionally your logic is a bit flawed - as that code would switch your FireNovaHigh state every second, even if you won't press your MB5.

Something like this should work:

--FireNovaHigh
FireNovaHigh = FireNovaHigh or false
FireNovaHighdown = FireNovaHighdown or 0

if not GetCurrentKeyBoardFocus() and IsMouseButtonDown(5) and GetTime() - FireNovaHighdown > 1 then
    FireNovaHighdown = GetTime()
    FireNovaHigh = not FireNovaHigh
    PQR_WriteToChat("FireNovaHigh: "..(FireNovaHigh and "|cFF00FF00Enabled" or "|cFFFF0000Disabled"))
    PQR_Event("PQR_Text","FireNovaHigh: "..(FireNovaHigh and "Enabled" or "Disabled"),nil,(FireNovaHigh and "00FF00" or "FF0000"))
end

Works great with your code troxxer, thanks a lot for helping me out. +repped.