PQR - Rotation Bot

[Ninjaderp]

A

Sent from my GT-I9100 using Tapatalk 2

[Rubim]

What happens if i use PQR_SpellAvailable on a spell that i dont have?

[crystal_tech]

What happens if i use PQR_SpellAvailable on a spell that i dont have?

like to check if a spell is rdy on another unit?

hmm it seems my sig was edited/filtered so i'll update it.

[Kinkeh]

What happens if i use PQR_SpellAvailable on a spell that i dont have?

I'm assuming it would return null and do nothing and skip that ability(until it's learned or you enter something with it), or pause the rotation at that ability. I'm thinking the first thing though.

[Xelper]

As long as it is a valid spell ID (in WoW) it will return false.

	function PQR_SpellAvailable(spellID)
		local gcdSpell = PQR_GCDSpellID()
		local gcdStartTime, gcdDuration = GetSpellCooldown(gcdSpell)
		local spellStartTime, spellDuration = GetSpellCooldown(spellID)
		local spellUsable = IsUsableSpell(spellID)
		local spellAvailable = false


		if spellUsable then
			if spellStartTime ~= nil and gcdStartTime ~= nil then
				local spellTimeLeft = spellStartTime + spellDuration - GetTime()
				local gcdTimeLeft = gcdStartTime + gcdDuration - GetTime()
				if gcdTimeLeft <= 0 then
				
					--Our GCD spell is not on CD.
					if spellTimeLeft <= PQR_SpellAvailableTime then
						--spell will be off CD within 50ms.
						spellAvailable = true 
					end
				else
					--Out GCD spell is on CD.
					if spellTimeLeft <= gcdTimeLeft + PQR_SpellAvailableTime then
						--spell time left is less than GCD time left + 50ms.
						spellAvailable = true
					end
				end
			end
		end


		return spellAvailable
	end

[Rubim]

As long as it is a valid spell ID (in WoW) it will return false.

	function PQR_SpellAvailable(spellID)
		local gcdSpell = PQR_GCDSpellID()
		local gcdStartTime, gcdDuration = GetSpellCooldown(gcdSpell)
		local spellStartTime, spellDuration = GetSpellCooldown(spellID)
		local spellUsable = IsUsableSpell(spellID)
		local spellAvailable = false


		if spellUsable then
			if spellStartTime ~= nil and gcdStartTime ~= nil then
				local spellTimeLeft = spellStartTime + spellDuration - GetTime()
				local gcdTimeLeft = gcdStartTime + gcdDuration - GetTime()
				if gcdTimeLeft <= 0 then
				
					--Our GCD spell is not on CD.
					if spellTimeLeft <= PQR_SpellAvailableTime then
						--spell will be off CD within 50ms.
						spellAvailable = true 
					end
				else
					--Out GCD spell is on CD.
					if spellTimeLeft <= gcdTimeLeft + PQR_SpellAvailableTime then
						--spell time left is less than GCD time left + 50ms.
						spellAvailable = true
					end
				end
			end
		end


		return spellAvailable
	end

Thats exactly what i need.

By returning false, i can make nice leveling profile.

[Kinky]

@Rubim: You nut. It's already in PQR itself.
@Ralphiuss: It's hard to make. I'll see what I can do if it's not already inside the Data file. However, you could add to your a simple line like:

if UnitDebuffID(target,spellID) then return false end

Almost at the very top of your profile, before you execute your healing code.

[Rubim]

@Rubim: You nut. It's already in PQR itself.
@Ralphiuss: It's hard to make. I'll see what I can do if it's not already inside the Data file. However, you could add to your a simple line like:

if UnitDebuffID(target,spellID) then return false end

Almost at the very top of your profile, before you execute your healing code.

I know

Dunno why you think that i was not aware of that!

I trough that it would return nil, but since he made 'false' by default then that will do it.

[Kinky]

@Rubim: Ah, alrighty! I'm just tired, haha.

[daveyboyuk]

@mentally gettin a error with ur new profiles , its asking for the data file however its in the correct place and is deffinatly there also it is the updated one . tried update through pqr and svn doesnt make any difference

[darksahde]

I've got an update planned for the data file soon which should improve all the Nova profiles' DPS. It should for Demonology, make Dark Soul: Knowledge usage more efficient and allow all our profiles to (if coded for it) to be used during leveling and properly take into account "all" bosses. (Dungeon, World and Raid Bosses.)

Stay tuned.

@Darksahde: Your code is flawed. You're not encapsulating it correctly and it has no sanity check. Topped off, you're trying to cast Steady Shot on no target!

if (UnitBuffID("player",53224) and select(7,UnitBuffID("player",53224)) - GetTime() < 3
		or not UnitBuffID("player",53224))
	and not PQR_IsMoving(0.3)
then CastSpellByName(GetSpellInfo(56641),"target") return true end

This piece of code does the following:
- Checks to see if you actually have Steady Focus first, then checks if the timer is 3 seconds or less
- If none of the above is true, you've establied for a fact that we have no Steady Focus active
- After the above two checks, it checks if you're not moving before executing the cast code.
- Note: when using CastSpellByName() it's important to remember that it takes 2 inputs. Either GetSpellInfo(ID) or the spell name and your desired target.

Thank you very much.

[Kinky]

@To everyone who's been getting errors with my new profile! It's because of me being tired and writing a function wrong. I'll have a SVN update in a few minutes which should fix all errors AND make the Demonology Warlock profile (in the beginning) usable on any level as it now properly determines Normal and Heroic Dungeon bosses and of course Raid bosses. This should greatly improve performance on all the cooldowns and not make you waste them on trash, for example.

Edit: The changes are up.
Update your SVN and/or Update the Demonology Warlock profile through the PQR Rotation Manager!
This will fix the issues people were having with the Data file not loading AND further improve the Demonology Profile's DPS as you can now run with the AoE/Standard profile -everywhere- without being afraid of it blowing your cooldowns. It'll check your target first.

As always, if you want to help me out and keep me motivated to create bigger and better profiles, you can make a donation or +Rep me! - It will not go unnoticed.

[Kinkeh]

@To everyone who's been getting errors with my new profile! It's because of me being tired and writing a function wrong. I'll have a SVN update in a few minutes which should fix all errors AND make the Demonology Warlock profile (in the beginning) usable on any level as it now properly determines Normal and Heroic Dungeon bosses and of course Raid bosses. This should greatly improve performance on all the cooldowns and not make you waste them on trash, for example.

Edit: The changes are up.
Update your SVN and/or Update the Demonology Warlock profile through the PQR Rotation Manager!
This will fix the issues people were having with the Data file not loading AND further improve the Demonology Profile's DPS as you can now run with the AoE/Standard profile -everywhere- without being afraid of it blowing your cooldowns. It'll check your target first.

As always, if you want to help me out and keep me motivated to create bigger and better profiles, you can make a donation or +Rep me! - It will not go unnoticed.

Wooo! result time, I only got screen caps of two fights, both of which I guess you can't really get an accurate DPS result but it seems to be pretty awesome. =]
Grand Empress Shek'zeer(Under me is a feral druid, who is an item level above me):

Amber-shaper Un'sok (After looking up both of the mages, they both fairly out gear me):

[snowhawk]

@To everyone who's been getting errors with my new profile! It's because of me being tired and writing a function wrong. I'll have a SVN update in a few minutes which should fix all errors AND make the Demonology Warlock profile (in the beginning) usable on any level as it now properly determines Normal and Heroic Dungeon bosses and of course Raid bosses. This should greatly improve performance on all the cooldowns and not make you waste them on trash, for example.

Edit: The changes are up.
Update your SVN and/or Update the Demonology Warlock profile through the PQR Rotation Manager!
This will fix the issues people were having with the Data file not loading AND further improve the Demonology Profile's DPS as you can now run with the AoE/Standard profile -everywhere- without being afraid of it blowing your cooldowns. It'll check your target first.

As always, if you want to help me out and keep me motivated to create bigger and better profiles, you can make a donation or +Rep me! - It will not go unnoticed.

Had a UI lock up during wind lord after updating to 1.4.3 through PQR, so I reverted back to 1.4.2.

[Kinky]

@snowhawk: Yeah. After updating you have to physically restart PQR and do a /reload within World of Warcraft to "reload" the Data file. (The lockups was probably because a new function was introduced which the Demonology Warlock profile is using!)

@Kinkeh: Awesome! Fire Mages molest everyone on the meters though if they're anywhere near half-decent. :x Or using PQR!