PQR - Rotation Bot

[lolomo2003]

Is there any way of checking if a spell has been succesful, or even better, how many times a certain spell has been executed succesfully?

I'm working on a personal rotation for feral dps, and i'm trying to work in glyph of bloodletting: mangle and shred extend the duration of rip by 2 seconds, up to a max of 6 seconds. If a shred or mangle will be able to extend the duration of the current rip and the rip is about to fall off, it should get higher priority in the rotation.

My idea was to maintain some sort of counter that gets reset on every rip cast, and incremented everytime a shred or mangle succesfully hits.

You can use a ingame addon ''PQInterface''

[kickmydog]

has anyone made a MoP rogue prof? i just got my rogue to 90 ill be lvling monk next if there r any up to date profs to test out for that to

I'm pretty sure the post just above you linked to the rogue profiles.

[Karil2]

Yeah didn't get too far .. I can get it to run with no errors but when in group it only heals myself .. lol so taking a break and will dive in again later and see what I can do.

---------------------------------------------------------

Edit: Ok looks like I got something working .. still doing some testing. Heals other people fine in battlegrounds but when running dungeons it doesn't heal anyone except myself.

Cool i am hoping that it goes well i am having a hard time with it myself of late....

[amw]

You can use a ingame addon ''PQInterface''

so how do i check this addon from pqr? ;p

[lolomo2003]

so how do i check this addon from pqr? ;p

Well not direct from PQR but in game you can check your rotation, spell time (start/end), missed spells, stuck spells/buffs etc and make changes according with in PQR. After changes are made /console reloadui in game and see how your changes work.

[Mpzor]

Is there any good guides out there for someone who wants to learn how to make their own profiles and have no previous experience with coding?

Cheers

Edit: Been reading up on the basics from this site (http://pqrotation.wikia.com/wiki/Profile_Writing_Basics) but I still wonder what certain things mean.

Like this:

local _, BlackArrowCD = GetSpellCooldown(3674)

if IsSpellInRange(GetSpellInfo(3044), "target") ~= 1 or IsLeftShiftKeyDown() then return false end

F_SwitchToHawk()

-- use if you do not have 2t13
--if BlackArrowCD < 5 and UnitPower("player") > 80 then return true end
--if BlackArrowCD > 5 and UnitPower("player") > 60 then return true end

if UnitPower("player") > 60 then return true end

I understand that it will cast black arrow if all of the above is correct, but what does the "~= 1" mean? and I see alot of "(1)" aswell.

[crystal_tech]

Is there any good guides out there for someone who wants to learn how to make their own profiles and have no previous experience with coding?

Cheers

Edit: Been reading up on the basics from this site (Profile Writing Basics - PQRotation Wiki) but I still wonder what certain things mean.

Like this:

local _, BlackArrowCD = GetSpellCooldown(3674)

if IsSpellInRange(GetSpellInfo(3044), "target") ~= 1 or IsLeftShiftKeyDown() then return false end

F_SwitchToHawk()

-- use if you do not have 2t13
--if BlackArrowCD < 5 and UnitPower("player") > 80 then return true end
--if BlackArrowCD > 5 and UnitPower("player") > 60 then return true end

if UnitPower("player") > 60 then return true end

I understand that it will cast black arrow if all of the above is correct, but what does the "~= 1" mean? and I see alot of "(1)" aswell.

~=1 means not equal to 1
==1 means equal to 1
so its saying

save variable locally (aka just this ability) placeholder(the _ ) and name the second call BlackArrowCD but use GetSpellCooldown(id) to set the info i need when i need it.

if spellinrange(lookupaspell, current target) returns 0(aka out of range) or if the left shift key is down then skip this ability

F_SwitchToHawk() is a custom function for switching from fox to hawk and back

[amw]

Well not direct from PQR but in game you can check your rotation, spell time (start/end), missed spells, stuck spells/buffs etc and make changes according with in PQR. After changes are made /console reloadui in game and see how your changes work.

So that doesn't help me in any way then.

Is there any way of checking if a spell has been succesful, or even better, how many times a certain spell has been executed succesfully?

I'm working on a personal rotation for feral dps, and i'm trying to work in glyph of bloodletting: mangle and shred extend the duration of rip by 2 seconds, up to a max of 6 seconds. If a shred or mangle will be able to extend the duration of the current rip and the rip is about to fall off, it should get higher priority in the rotation.

My idea was to maintain some sort of counter that gets reset on every rip cast, and incremented everytime a shred or mangle succesfully hits.

PQR needs to be able to count successful shreds/mangles automatically. Editing the profile everytime i press shred isn't really what i had in mind.

[lolomo2003]

Is there any way of checking if a spell has been succesful, or even better, how many times a certain spell has been executed succesfully?

This was your original question if you are able to check if a spell has been successful or how many times. Anyway maybe I misunderstood. Sorry for not being more helpful.

[Mpzor]

Thank you But i'm still abit confused, why is the "~= 1" even there? I mean, why dont just leave it out? Or does it have to be there so that the program will know to skip it if it doesnt return as...? Now im confused again :P Why 1? Does 1 mean that its in range? Might have something with me being realy tired after working a double shift so I might feel stupid when I wake up

[crystal_tech]

Thank you But i'm still abit confused, why is the "~= 1" even there? I mean, why dont just leave it out? Or does it have to be there so that the program will know to skip it if it doesnt return as...? Now im confused again :P Why 1? Does 1 mean that its in range? Might have something with me being realy tired after working a double shift so I might feel stupid when I wake up

its ok take your time with it.

1 is the same to saying 'true' and 0 is the same as saying 'false'

both these statements will do the same thing

if not UnitBuffID("player", someid) then return true end
 
if UnitBuffID("player", someid) ~= 1 then return true end

heres the switch if the buff is there or true:

if UnitBuffID("player", someid) == 1 then return false end

if UnitBuffID("player", someid) then return false end

---------------------------

if you need to count stacks of a debuff/buff you need to use the call for stacks.

this is the webpage for UnitBuff and Debuff
UnitBuff - World of Warcraft Programming: A Guide and Reference for Creating WoW Addons

http://wowprogramming.com/docs/api/UnitDebuff

so if you want say stop casting at 5 stacks of something it will look like this

-- I'm using select to pick the call of the api I want to use instead of using local _,_,_,count,_,_, timeleft = UnitBuffID("target", somespellid)
-- both ways are valid and its up to you

local count = select(4, UnitBuffID("target", somespellid))
local timeleft = select(7, UnitBuffID("target", somespellid))

if not timeleft then
     return true
else
     if timeleft - GetTime() > 2 then
          if count < 4 then return true end
     end
end

[amw]

This was your original question if you are able to check if a spell has been successful or how many times. Anyway maybe I misunderstood. Sorry for not being more helpful.

Alright, no hard feelings

I figured something out already. I check the expiration time of rip on the target, and whenever the expiration time changes, i check how many combopoints are active on the target. If the # of CP is 0, I assume rip was refreshed with rip or fericous bite, and reset the shredcounter to 0. If the # of CP is not 0, the rip was extended through GoBL and thus shredcounter is increased by 1.

Testing it atm and looks very promising

[averykey]

Is this correct?

local artOfWar = UnitBuffID("player", 87138)
local crusaderStrike = GetSpellInfo(35395)
local undead = UnitCreatureType("target") == "Undead
local demon = UnitCreatureType("target") == "Demon"
local outOfRange = IsSpellInRange(crusaderStrike, "target") == 0

if artOfWar == nil then
	return false
end

if artOfWar ~= nil and undead or demon
else if artOfWar ~= nil and outOfRange and undead or demon then
		return true
	end
end

Can I just do this instead?

--WIll this always return true if no value is given?
if artOfWar  then
	return false
end

edit: I want it like this, but I am not sure if it will work.

local artOfWar = UnitBuffID("player", 87138)
local crusaderStrike = GetSpellInfo(35395)
local undead = UnitCreatureType("target") == "Undead"
local demon = UnitCreatureType("target") == "Demon"
local outOfRange = IsSpellInRange(crusaderStrike, "target") == 0

if artOfWar == nil then
	return false
else if outOfRange artOfWar ~= nil and undead or demon then
	return true
		else if artOfWar ~= nil and undead or demon then
			return true
				else if outOfRange and artOfWar ~= nil then
					return true
						else if artOfWar ~= nil then
							return true
				end
			end
		end
	end
end

If anyone wants to give the above a go the spell code is 879.

This is not ideal because undead is higher up in the ret rotation.


Undead

if artOfWar == nil then
	return false
		else if outOfRange and artOfWar ~= nil and undead or demon
			return true
				else if artOfWar ~= nil and undead or demon then
					return true
		end
	end
end

[firepong]

Is this correct?

local artOfWar = UnitBuffID("player", 87138)
local crusaderStrike = GetSpellInfo(35395)
local undead = UnitCreatureType("target") == "Undead
local demon = UnitCreatureType("target") == "Demon"
local outOfRange = IsSpellInRange(crusaderStrike, "target") == 0

if artOfWar == nil then
	return false
end

if artOfWar ~= nil and undead or demon
else if artOfWar ~= nil and outOfRange and undead or demon then
		return true
	end
end

Can I just do this instead?

--WIll this always return true if no value is given?
if artOfWar  then
	return false
end

edit: I want it like this, but I am not sure if it will work.

local artOfWar = UnitBuffID("player", 87138)
local crusaderStrike = GetSpellInfo(35395)
local undead = UnitCreatureType("target") == "Undead"
local demon = UnitCreatureType("target") == "Demon"
local outOfRange = IsSpellInRange(crusaderStrike, "target") == 0

if artOfWar == nil then
	return false
else if outOfRange artOfWar ~= nil and undead or demon then
	return true
		else if artOfWar ~= nil and undead or demon then
			return true
				else if outOfRange and artOfWar ~= nil then
					return true
						else if artOfWar ~= nil then
							return true
				end
			end
		end
	end
end

If anyone wants to give the above a go the spell code is 879.

This is not ideal because undead is higher up in the ret rotation.


Undead

if artOfWar == nil then
	return false
		else if outOfRange and artOfWar ~= nil and undead or demon
			return true
				else if artOfWar ~= nil and undead or demon then
					return true
		end
	end
end

Give:

local artOfWar = UnitBuffID("Player", 87138)
local crusaderStrike = GetSpellInfo(35395)
local undead = UnitCreatureType("Target") == "Undead"
local demon = UnitCreatureType("Target") == "Demon"
local outOfRange = IsSpellInRange(crusaderStrike, "Target") == 0

if artOfWar == nil then
	return false
elseif outOfRange and artOfWar ~= nil and (undead or demon) then
	return true
elseif artOfWar ~= nil and (undead or demon) then
	return true
elseif outOfRange and artOfWar ~= nil and (undead or demon) then
	return true
elseif outOfRange and artOfWar ~= nil then
	return true
elseif artOfWar ~= nil then
	return true
end

A whirl and let me know how it goes. The way you had it just made it look more complicated than it should

[averykey]

Give:

local artOfWar = UnitBuffID("Player", 87138)
local crusaderStrike = GetSpellInfo(35395)
local undead = UnitCreatureType("Target") == "Undead"
local demon = UnitCreatureType("Target") == "Demon"
local outOfRange = IsSpellInRange(crusaderStrike, "Target") == 0

if artOfWar == nil then
	return false
elseif outOfRange and artOfWar ~= nil and (undead or demon) then
	return true
elseif artOfWar ~= nil and (undead or demon) then
	return true
elseif outOfRange and artOfWar ~= nil and (undead or demon) then
	return true
elseif outOfRange and artOfWar ~= nil then
	return true
elseif artOfWar ~= nil then
	return true
end

A whirl and let me know how it goes. The way you had it just made it look more complicated than it should

Works, thanks.

Anyone who wants it.

local bloodlust = UnitBuffID("player", 2825)
local timewarp = UnitBuffID("player", 80353)

if bloodlust ~= nil or timewarp ~= nil then
return true
end