PQR - Rotation Bot

[metazcq]

Nice to see a new and clean post, hope this makes easier to find profiles

[zeromaster]

new PTR Version ; ) anyone got the new Offset for it ?

[vergil10]

hi
anyone know a great unholy profile ?

[Holobyte]

try this:
Lua Unofficial FAQ (uFAQ)

and reading

Lua for Beginners

sounds like your trying to grow your tables after they are created and you should cap them at so many lines, and delay your updates to the tables a bit more.

I have one single table with variable size, but it's not being changed too often. All other tables are of fixed size.
About delaying updates, I tought about updating tables using event handlers, like hooking COMBAT_LOG_EVENT_UNFILTERED and watching for buffs being applied or removed instead of checking for them every time.

[Vinshom]

What and how Jukeboxes work? can someone show me a sample code plz?

I found it thnx deadpanstiffy http://www.ownedcore.com/forums/worl...file-free.html ([PQR] PVP Spell Cast Fake/Juke Code (Any Profile) (FREE))

[CodeMyLife]

My new profile runs fine on 10man raids but during certain 25man encounters (mostly Primordius) I face some major slowdowns that go away when I pause the profile. I have a good computer (core i5 3570K / 8GB RAM) and other profiles (from other authors) do not give me any slowdowns, ever.

Does using Lua tables affect profile performance? For my current profile I decided to make use of Lua tables. It has 6 global tables that are read and updated by a number of functions and abilities. I'm not creating any other tables, not even local ones. Some tables have subtables, others don't.
An example:

    Runes = {
        ["b"] = { Up = 0, CdLeft = 10 },
        ["u"] = { Up = 0, CdLeft = 10 },
        ["f"] = { Up = 0, CdLeft = 10 },
    }

This table is updated at every PQR cycle by a function (ability check delay is at 20ms):

function Hf_UpdateRunes()
    if not Runes then
        Hf_AddLog("Error", "'Runes' table does not exists.", "Hf_UpdateRunes")
        return
    end


    local runeSlots = { "b", "u", "f"}
    local r = 1
    for slot=1, 6 do
        local start, cd, up = GetRuneCooldown(slot)
        local left = start + cd - GetTime()
        if not up then -- on Cd
            if Runes[runeSlots[r]].CdLeft > left then
                Runes[runeSlots[r]].CdLeft = left
            end
        else -- off Cd
            Runes[runeSlots[r]].Up = Runes[runeSlots[r]].Up + 1
        end
        if slot % 2 == 0 then
            r = r + 1
        end
    end
end

I have similar tables and functions to handle player buffs and target debuffs.

So, do you think that I should drop tables and simply return multiple values? I don't really want to make this change and see no performance gain at all so I tought I should ask first.

I experienced issues when using PQR_UnitFacing in heavy adds fights. This function seems broken right now and alter badly framerate. Open your ability.lua and ctrl+f PQR_UnitFacing to make sure you do not have any of those. If none of those, might be related to table but... Your code seems clean.

[CaptnHaddock]

I want to make my warrior use taunt, like if my target isn't targeting me then cast taunt.. how am I gonna do that?
ye i'm useless ....

Help would be appreciated

[kuukuu]

I want to make my warrior use taunt, like if my target isn't targeting me then cast taunt.. how am I gonna do that?
ye i'm useless ....

Help would be appreciated

You could use API UnitThreatSituation - WoWWiki - Your guide to the World of Warcraft or simply check if your target is targeting you and then cast whatever your taunt is if it is targeting something else.

[Holobyte]

I experienced issues when using PQR_UnitFacing in heavy adds fights. This function seems broken right now and alter badly framerate. Open your ability.lua and ctrl+f PQR_UnitFacing to make sure you do not have any of those. If none of those, might be related to table but... Your code seems clean.

I don't make use of PQR_UnitFacing(). It may be useful for some abilities of some classes but that does not applies to this profile I'm making.
Anyway, people are missing the point of my question. I ask for opinions on performance impact of Lua tables on PQR profiles and I get a link for LUA FOR BEGUINNERS. :P
I know I have to avoid table rehashing, I know that adding items to tables (making them grow) causes rehashing, what I need is to have feedback from people that may have had performance issues in their profiles due to using tables.
I want to avoid premature optimization. Lua is one of the fastest scripting languages so I wanted to push it and now I know that the code needs optimization, I just need to find out where and I don't want to do it by trial and error. Like, refactoring the whole code just to find out that tables were fine and the problem was elsewhere. I remember that Valma had a profile that made heavy use of tables and that it performed gracefully.

[CaptnHaddock]

You could use API UnitThreatSituation - WoWWiki - Your guide to the World of Warcraft or simply check if your target is targeting you and then cast whatever your taunt is if it is targeting something else.

Thanks. I tried, but it doesn't make sense to me.... Actually was I hoping for a code which was done so I could just copy paste and then change it abit for my needs

[crystal_tech]

I don't make use of PQR_UnitFacing(). It may be useful for some abilities of some classes but that does not applies to this profile I'm making.
Anyway, people are missing the point of my question. I ask for opinions on performance impact of Lua tables on PQR profiles and I get a link for LUA FOR BEGUINNERS. :P
I know I have to avoid table rehashing, I know that adding items to tables (making them grow) causes rehashing, what I need is to have feedback from people that may have had performance issues in their profiles due to using tables.
I want to avoid premature optimization. Lua is one of the fastest scripting languages so I wanted to push it and now I know that the code needs optimization, I just need to find out where and I don't want to do it by trial and error. Like, refactoring the whole code just to find out that tables were fine and the problem was elsewhere. I remember that Valma had a profile that made heavy use of tables and that it performed gracefully.

lol, i didn't mean your a beginner, its just the sites name and still has some good info that you may have missed.

[kickmydog]

Thanks. I tried, but it doesn't make sense to me.... Actually was I hoping for a code which was done so I could just copy paste and then change it abit for my needs

Try something like

 if UnitThreatSituation("player","target") ~= 3 then return true end 

or

  if UnitThreatSituation("player","mouseover") ~= 3 then return true end 

[JoseGildardoRamirez]

Kickmydog, Thanks so much, you are the best

[kickmydog]

That reminds me, any ideas on a fix for this.

local InParty = GetNumGroupMembers()
if InParty > 0 and UnitInRaid("player") then
  for i = 1, InParty, 1 do
  local member = "party"..tostring(i)
  if UnitGroupRolesAssigned(member) == "TANK"
  and UnitThreatSituation(member,"target") ~= 3
  then CastSpellByName(GetSpellInfo(34477),member)
  end
end 

It is for an auto misdirect to the tank when threat is low.

[markbro]

I've made a few of my own profiles with random level characters. I decided to start a leveling profile for the Warrior from level 1. I'm already having issues. I can't seem to get anything going where I can Auto Attack to build rage for Heroic Strike.
I've tried making an Ability for Auto Attack (spell id 6603) and even for the Warrior's Attack (spell id 88163) but neither of them seem to do anything. It just sits there because enough rage isn't built up for Heroic Strike.
Any help getting an Auto Attack script would be greatly appreciated.

I am trying to make it available to where you just click an enemy and it attacks (unchecked requires combat)